[PATCH 0/1] Move DG2 to GuC v70.4.1

[PATCH 0/1] Move DG2 to GuC v70.4.1

[John.C.Harrison]

From: John Harrison <John.C.Harrison@Intel.com>

The latest GuC release contains a bunch of fixes for DG2. Start using
it.

Note that some of these fixes require i915 side support which will
follow in separate patches.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (1):
  drm/i915/dg2: Update DG2 to GuC v70.4.1

 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.37.1

[PATCH 1/1] drm/i915/dg2: Update DG2 to GuC v70.4.1

[John.C.Harrison]

From: John Harrison <John.C.Harrison@Intel.com>

New release of GuC with a bunch of fixes specific to DG2. Some of
these require follow up i915 changes to enable.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
index d5fca1f68eff2..58547292efa0a 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
@@ -53,7 +53,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
  * firmware as TGL.
  */
 #define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_def) \
-	fw_def(DG2,          0, guc_def(dg2,  70, 1, 2)) \
+	fw_def(DG2,          0, guc_def(dg2,  70, 4, 1)) \
 	fw_def(ALDERLAKE_P,  0, guc_def(adlp, 70, 1, 1)) \
 	fw_def(ALDERLAKE_S,  0, guc_def(tgl,  70, 1, 1)) \
 	fw_def(DG1,          0, guc_def(dg1,  70, 1, 1)) \
-- 
2.37.1

Re: [PATCH 0/1] Move DG2 to GuC v70.4.1

[Niranjana Vishwanathapura]

On Thu, Jul 28, 2022 at 04:07:21PM -0700, John.C.Harrison@Intel.com wrote:
>From: John Harrison <John.C.Harrison@Intel.com>
>
>The latest GuC release contains a bunch of fixes for DG2. Start using
>it.
>
>Note that some of these fixes require i915 side support which will
>follow in separate patches.

So, this patch series has a dependency on those i915 fixes required?

Niranjana

>
>Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>
>
>John Harrison (1):
>  drm/i915/dg2: Update DG2 to GuC v70.4.1
>
> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>-- 
>2.37.1
>

Re: [PATCH 0/1] Move DG2 to GuC v70.4.1

[John Harrison]

On 8/1/2022 10:28, Niranjana Vishwanathapura wrote:
> On Thu, Jul 28, 2022 at 04:07:21PM -0700, John.C.Harrison@Intel.com 
> wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> The latest GuC release contains a bunch of fixes for DG2. Start using
>> it.
>>
>> Note that some of these fixes require i915 side support which will
>> follow in separate patches.
>
> So, this patch series has a dependency on those i915 fixes required?
>
> Niranjana
Other way around. The i915 side changes require this firmware to be 
present before they can be enabled.

John.


>
>>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>>
>>
>> John Harrison (1):
>>  drm/i915/dg2: Update DG2 to GuC v70.4.1
>>
>> drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> -- 
>> 2.37.1
>>

Re: [PATCH 1/1] drm/i915/dg2: Update DG2 to GuC v70.4.1

[Ceraolo Spurio, Daniele]

On 7/28/2022 4:07 PM, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
>
> New release of GuC with a bunch of fixes specific to DG2. Some of
> these require follow up i915 changes to enable.

This needs a note to explain that we don't need to maintain 70.1 
compatibility because DG2 is still under force_probe. Don't need to 
re-send, just add it on when merging.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

>
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
> ---
>   drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> index d5fca1f68eff2..58547292efa0a 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
> @@ -53,7 +53,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,
>    * firmware as TGL.
>    */
>   #define INTEL_GUC_FIRMWARE_DEFS(fw_def, guc_def) \
> -	fw_def(DG2,          0, guc_def(dg2,  70, 1, 2)) \
> +	fw_def(DG2,          0, guc_def(dg2,  70, 4, 1)) \
>   	fw_def(ALDERLAKE_P,  0, guc_def(adlp, 70, 1, 1)) \
>   	fw_def(ALDERLAKE_S,  0, guc_def(tgl,  70, 1, 1)) \
>   	fw_def(DG1,          0, guc_def(dg1,  70, 1, 1)) \