* [PATCH -next] drm/msm/adreno: Switch to memdup_user_nul() helper
@ 2022-08-26 8:45 Yang Yingliang
2022-08-26 10:12 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-08-26 8:45 UTC (permalink / raw)
To: linux-kernel, freedreno, dri-devel, linux-arm-msm; +Cc: quic_abhinavk
Use memdup_user_nul() helper instead of open-coding to
simplify the code.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
index 382fb7f9e497..50b33e14237b 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
@@ -339,17 +339,9 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_file_private *ctx,
case MSM_PARAM_CMDLINE: {
char *str, **paramp;
- str = kmalloc(len + 1, GFP_KERNEL);
- if (!str)
- return -ENOMEM;
-
- if (copy_from_user(str, u64_to_user_ptr(value), len)) {
- kfree(str);
- return -EFAULT;
- }
-
- /* Ensure string is null terminated: */
- str[len] = '\0';
+ str = memdup_user_nul(u64_to_user_ptr(value), len);
+ if (IS_ERR(str))
+ return PTR_ERR(str);
if (param == MSM_PARAM_COMM) {
paramp = &ctx->comm;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/msm/adreno: Switch to memdup_user_nul() helper
2022-08-26 8:45 [PATCH -next] drm/msm/adreno: Switch to memdup_user_nul() helper Yang Yingliang
@ 2022-08-26 10:12 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2022-08-26 10:12 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, freedreno, dri-devel, linux-arm-msm
Cc: quic_abhinavk
On 26/08/2022 11:45, Yang Yingliang wrote:
> Use memdup_user_nul() helper instead of open-coding to
> simplify the code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 382fb7f9e497..50b33e14237b 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -339,17 +339,9 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_file_private *ctx,
> case MSM_PARAM_CMDLINE: {
> char *str, **paramp;
>
> - str = kmalloc(len + 1, GFP_KERNEL);
> - if (!str)
> - return -ENOMEM;
> -
> - if (copy_from_user(str, u64_to_user_ptr(value), len)) {
> - kfree(str);
> - return -EFAULT;
> - }
> -
> - /* Ensure string is null terminated: */
> - str[len] = '\0';
> + str = memdup_user_nul(u64_to_user_ptr(value), len);
> + if (IS_ERR(str))
> + return PTR_ERR(str);
>
> if (param == MSM_PARAM_COMM) {
> paramp = &ctx->comm;
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-26 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-26 8:45 [PATCH -next] drm/msm/adreno: Switch to memdup_user_nul() helper Yang Yingliang
2022-08-26 10:12 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).