* [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale
@ 2022-08-28 16:45 José Expósito
2022-08-28 16:45 ` [PATCH v3 1/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888() José Expósito
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: José Expósito @ 2022-08-28 16:45 UTC (permalink / raw)
To: javierm
Cc: dri-devel, tzimmermann, magalilemes00, airlied, maira.canal,
dlatypov, linux-kernel, geert, tales.aparecida, davidgow,
José Expósito, isabbasso, kunit-dev
Hello everyone,
This series is a follow up on my work adding KUnit test to the XRGB8888
conversion functions. This time RGB888, XRGB2101010 and gray8 are added.
Best wishes,
Jose
v1 -> v2:
Tested-by: Maíra Canal <mairacanal@riseup.net>
Reviewed-by: David Gow <davidgow@google.com>
v2 -> v3:
Export symbol drm_fb_xrgb8888_to_xrgb2101010()
José Expósito (3):
drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888()
drm/format-helper: Add KUnit tests for
drm_fb_xrgb8888_to_xrgb2101010()
drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8()
drivers/gpu/drm/drm_format_helper.c | 1 +
.../gpu/drm/tests/drm_format_helper_test.c | 190 ++++++++++++++++++
2 files changed, 191 insertions(+)
base-commit: 61a9fa154d217c13eea90aa5bc635bc4b1fcb66e
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 1/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888()
2022-08-28 16:45 [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
@ 2022-08-28 16:45 ` José Expósito
2022-08-28 16:45 ` [PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010() José Expósito
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: José Expósito @ 2022-08-28 16:45 UTC (permalink / raw)
To: javierm
Cc: dri-devel, tzimmermann, magalilemes00, airlied, maira.canal,
dlatypov, linux-kernel, Maíra Canal, geert, tales.aparecida,
davidgow, José Expósito, isabbasso, kunit-dev
Extend the existing test cases to test the conversion from XRGB8888 to
RGB888.
Tested-by: Maíra Canal <mairacanal@riseup.net>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
.../gpu/drm/tests/drm_format_helper_test.c | 65 +++++++++++++++++++
1 file changed, 65 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
index 828487071796..08d08e7ab19a 100644
--- a/drivers/gpu/drm/tests/drm_format_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
@@ -27,6 +27,11 @@ struct convert_to_rgb565_result {
const u16 expected_swab[TEST_BUF_SIZE];
};
+struct convert_to_rgb888_result {
+ unsigned int dst_pitch;
+ const u8 expected[TEST_BUF_SIZE];
+};
+
struct convert_xrgb8888_case {
const char *name;
unsigned int pitch;
@@ -34,6 +39,7 @@ struct convert_xrgb8888_case {
const u32 xrgb8888[TEST_BUF_SIZE];
struct convert_to_rgb332_result rgb332_result;
struct convert_to_rgb565_result rgb565_result;
+ struct convert_to_rgb888_result rgb888_result;
};
static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
@@ -51,6 +57,10 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
.expected = { 0xF800 },
.expected_swab = { 0x00F8 },
},
+ .rgb888_result = {
+ .dst_pitch = 0,
+ .expected = { 0x00, 0x00, 0xFF },
+ },
},
{
.name = "single_pixel_clip_rectangle",
@@ -69,6 +79,10 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
.expected = { 0xF800 },
.expected_swab = { 0x00F8 },
},
+ .rgb888_result = {
+ .dst_pitch = 0,
+ .expected = { 0x00, 0x00, 0xFF },
+ },
},
{
/* Well known colors: White, black, red, green, blue, magenta,
@@ -109,6 +123,15 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
0xE0FF, 0xFF07,
},
},
+ .rgb888_result = {
+ .dst_pitch = 0,
+ .expected = {
+ 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0xFF, 0x00, 0xFF, 0x00,
+ 0xFF, 0x00, 0x00, 0xFF, 0x00, 0xFF,
+ 0x00, 0xFF, 0xFF, 0xFF, 0xFF, 0x00,
+ },
+ },
},
{
/* Randomly picked colors. Full buffer within the clip area. */
@@ -141,6 +164,17 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
0x00A8, 0x8E6B, 0x330A, 0x0000, 0x0000,
},
},
+ .rgb888_result = {
+ .dst_pitch = 15,
+ .expected = {
+ 0x9C, 0x44, 0x0E, 0x05, 0x4D, 0x11, 0x03, 0x03, 0xA8,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x73, 0x70, 0x6C, 0x9C, 0x44, 0x0E, 0x05, 0x4D, 0x11,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x03, 0x03, 0xA8, 0x73, 0x70, 0x6C, 0x9C, 0x44, 0x0E,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ },
+ },
},
};
@@ -255,9 +289,40 @@ static void xrgb8888_to_rgb565_test(struct kunit *test)
KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected_swab, dst_size), 0);
}
+static void xrgb8888_to_rgb888_test(struct kunit *test)
+{
+ const struct convert_xrgb8888_case *params = test->param_value;
+ const struct convert_to_rgb888_result *result = ¶ms->rgb888_result;
+ size_t dst_size;
+ __u8 *buf = NULL;
+ __u32 *xrgb8888 = NULL;
+ struct iosys_map dst, src;
+
+ struct drm_framebuffer fb = {
+ .format = drm_format_info(DRM_FORMAT_XRGB8888),
+ .pitches = { params->pitch, 0, 0 },
+ };
+
+ dst_size = conversion_buf_size(DRM_FORMAT_RGB888, result->dst_pitch,
+ ¶ms->clip);
+ KUNIT_ASSERT_GT(test, dst_size, 0);
+
+ buf = kunit_kzalloc(test, dst_size, GFP_KERNEL);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf);
+ iosys_map_set_vaddr(&dst, buf);
+
+ xrgb8888 = le32buf_to_cpu(test, params->xrgb8888, TEST_BUF_SIZE);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, xrgb8888);
+ iosys_map_set_vaddr(&src, xrgb8888);
+
+ drm_fb_xrgb8888_to_rgb888(&dst, &result->dst_pitch, &src, &fb, ¶ms->clip);
+ KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);
+}
+
static struct kunit_case drm_format_helper_test_cases[] = {
KUNIT_CASE_PARAM(xrgb8888_to_rgb332_test, convert_xrgb8888_gen_params),
KUNIT_CASE_PARAM(xrgb8888_to_rgb565_test, convert_xrgb8888_gen_params),
+ KUNIT_CASE_PARAM(xrgb8888_to_rgb888_test, convert_xrgb8888_gen_params),
{}
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010()
2022-08-28 16:45 [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
2022-08-28 16:45 ` [PATCH v3 1/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888() José Expósito
@ 2022-08-28 16:45 ` José Expósito
2022-08-28 16:45 ` [PATCH v3 3/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8() José Expósito
2022-09-18 13:22 ` [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
3 siblings, 0 replies; 7+ messages in thread
From: José Expósito @ 2022-08-28 16:45 UTC (permalink / raw)
To: javierm
Cc: dri-devel, tzimmermann, magalilemes00, airlied, maira.canal,
dlatypov, linux-kernel, Maíra Canal, geert, tales.aparecida,
davidgow, José Expósito, isabbasso, kunit-dev
Extend the existing test cases to test the conversion from XRGB8888 to
XRGB2101010.
In order to be able to call drm_fb_xrgb8888_to_xrgb2101010() when
compiling CONFIG_DRM_KMS_HELPER as a module export the symbol.
Tested-by: Maíra Canal <mairacanal@riseup.net>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
drivers/gpu/drm/drm_format_helper.c | 1 +
.../gpu/drm/tests/drm_format_helper_test.c | 63 +++++++++++++++++++
2 files changed, 64 insertions(+)
diff --git a/drivers/gpu/drm/drm_format_helper.c b/drivers/gpu/drm/drm_format_helper.c
index 56642816fdff..b9a9fea0f6f1 100644
--- a/drivers/gpu/drm/drm_format_helper.c
+++ b/drivers/gpu/drm/drm_format_helper.c
@@ -553,6 +553,7 @@ void drm_fb_xrgb8888_to_xrgb2101010(struct iosys_map *dst, const unsigned int *d
drm_fb_xfrm(dst, dst_pitch, dst_pixsize, src, fb, clip, false,
drm_fb_xrgb8888_to_xrgb2101010_line);
}
+EXPORT_SYMBOL(drm_fb_xrgb8888_to_xrgb2101010);
static void drm_fb_xrgb8888_to_gray8_line(void *dbuf, const void *sbuf, unsigned int pixels)
{
diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
index 08d08e7ab19a..d8536db4de1e 100644
--- a/drivers/gpu/drm/tests/drm_format_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
@@ -32,6 +32,11 @@ struct convert_to_rgb888_result {
const u8 expected[TEST_BUF_SIZE];
};
+struct convert_to_xrgb2101010_result {
+ unsigned int dst_pitch;
+ const u32 expected[TEST_BUF_SIZE];
+};
+
struct convert_xrgb8888_case {
const char *name;
unsigned int pitch;
@@ -40,6 +45,7 @@ struct convert_xrgb8888_case {
struct convert_to_rgb332_result rgb332_result;
struct convert_to_rgb565_result rgb565_result;
struct convert_to_rgb888_result rgb888_result;
+ struct convert_to_xrgb2101010_result xrgb2101010_result;
};
static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
@@ -61,6 +67,10 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
.dst_pitch = 0,
.expected = { 0x00, 0x00, 0xFF },
},
+ .xrgb2101010_result = {
+ .dst_pitch = 0,
+ .expected = { 0x3FF00000 },
+ },
},
{
.name = "single_pixel_clip_rectangle",
@@ -83,6 +93,10 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
.dst_pitch = 0,
.expected = { 0x00, 0x00, 0xFF },
},
+ .xrgb2101010_result = {
+ .dst_pitch = 0,
+ .expected = { 0x3FF00000 },
+ },
},
{
/* Well known colors: White, black, red, green, blue, magenta,
@@ -132,6 +146,15 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
0x00, 0xFF, 0xFF, 0xFF, 0xFF, 0x00,
},
},
+ .xrgb2101010_result = {
+ .dst_pitch = 0,
+ .expected = {
+ 0x3FFFFFFF, 0x00000000,
+ 0x3FF00000, 0x000FFC00,
+ 0x000003FF, 0x3FF003FF,
+ 0x3FFFFC00, 0x000FFFFF,
+ },
+ },
},
{
/* Randomly picked colors. Full buffer within the clip area. */
@@ -175,6 +198,14 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
},
},
+ .xrgb2101010_result = {
+ .dst_pitch = 20,
+ .expected = {
+ 0x03844672, 0x0444D414, 0x2A20300C, 0x00000000, 0x00000000,
+ 0x1B1705CD, 0x03844672, 0x0444D414, 0x00000000, 0x00000000,
+ 0x2A20300C, 0x1B1705CD, 0x03844672, 0x00000000, 0x00000000,
+ },
+ },
},
};
@@ -319,10 +350,42 @@ static void xrgb8888_to_rgb888_test(struct kunit *test)
KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);
}
+static void xrgb8888_to_xrgb2101010_test(struct kunit *test)
+{
+ const struct convert_xrgb8888_case *params = test->param_value;
+ const struct convert_to_xrgb2101010_result *result = ¶ms->xrgb2101010_result;
+ size_t dst_size;
+ __u32 *buf = NULL;
+ __u32 *xrgb8888 = NULL;
+ struct iosys_map dst, src;
+
+ struct drm_framebuffer fb = {
+ .format = drm_format_info(DRM_FORMAT_XRGB8888),
+ .pitches = { params->pitch, 0, 0 },
+ };
+
+ dst_size = conversion_buf_size(DRM_FORMAT_XRGB2101010,
+ result->dst_pitch, ¶ms->clip);
+ KUNIT_ASSERT_GT(test, dst_size, 0);
+
+ buf = kunit_kzalloc(test, dst_size, GFP_KERNEL);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf);
+ iosys_map_set_vaddr(&dst, buf);
+
+ xrgb8888 = le32buf_to_cpu(test, params->xrgb8888, TEST_BUF_SIZE);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, xrgb8888);
+ iosys_map_set_vaddr(&src, xrgb8888);
+
+ drm_fb_xrgb8888_to_xrgb2101010(&dst, &result->dst_pitch, &src, &fb, ¶ms->clip);
+ buf = le32buf_to_cpu(test, buf, TEST_BUF_SIZE);
+ KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);
+}
+
static struct kunit_case drm_format_helper_test_cases[] = {
KUNIT_CASE_PARAM(xrgb8888_to_rgb332_test, convert_xrgb8888_gen_params),
KUNIT_CASE_PARAM(xrgb8888_to_rgb565_test, convert_xrgb8888_gen_params),
KUNIT_CASE_PARAM(xrgb8888_to_rgb888_test, convert_xrgb8888_gen_params),
+ KUNIT_CASE_PARAM(xrgb8888_to_xrgb2101010_test, convert_xrgb8888_gen_params),
{}
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v3 3/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8()
2022-08-28 16:45 [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
2022-08-28 16:45 ` [PATCH v3 1/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888() José Expósito
2022-08-28 16:45 ` [PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010() José Expósito
@ 2022-08-28 16:45 ` José Expósito
2022-09-18 13:22 ` [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
3 siblings, 0 replies; 7+ messages in thread
From: José Expósito @ 2022-08-28 16:45 UTC (permalink / raw)
To: javierm
Cc: dri-devel, tzimmermann, magalilemes00, airlied, maira.canal,
dlatypov, linux-kernel, Maíra Canal, geert, tales.aparecida,
davidgow, José Expósito, isabbasso, kunit-dev
Extend the existing test cases to test the conversion from XRGB8888 to
grayscale.
Tested-by: Maíra Canal <mairacanal@riseup.net>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
.../gpu/drm/tests/drm_format_helper_test.c | 62 +++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
index d8536db4de1e..2f548aa51a30 100644
--- a/drivers/gpu/drm/tests/drm_format_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
@@ -37,6 +37,11 @@ struct convert_to_xrgb2101010_result {
const u32 expected[TEST_BUF_SIZE];
};
+struct convert_to_gray8_result {
+ unsigned int dst_pitch;
+ const u8 expected[TEST_BUF_SIZE];
+};
+
struct convert_xrgb8888_case {
const char *name;
unsigned int pitch;
@@ -46,6 +51,7 @@ struct convert_xrgb8888_case {
struct convert_to_rgb565_result rgb565_result;
struct convert_to_rgb888_result rgb888_result;
struct convert_to_xrgb2101010_result xrgb2101010_result;
+ struct convert_to_gray8_result gray8_result;
};
static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
@@ -71,6 +77,10 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
.dst_pitch = 0,
.expected = { 0x3FF00000 },
},
+ .gray8_result = {
+ .dst_pitch = 0,
+ .expected = { 0x4C },
+ },
},
{
.name = "single_pixel_clip_rectangle",
@@ -97,6 +107,10 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
.dst_pitch = 0,
.expected = { 0x3FF00000 },
},
+ .gray8_result = {
+ .dst_pitch = 0,
+ .expected = { 0x4C },
+ },
},
{
/* Well known colors: White, black, red, green, blue, magenta,
@@ -155,6 +169,15 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
0x3FFFFC00, 0x000FFFFF,
},
},
+ .gray8_result = {
+ .dst_pitch = 0,
+ .expected = {
+ 0xFF, 0x00,
+ 0x4C, 0x99,
+ 0x19, 0x66,
+ 0xE5, 0xB2,
+ },
+ },
},
{
/* Randomly picked colors. Full buffer within the clip area. */
@@ -206,6 +229,14 @@ static struct convert_xrgb8888_case convert_xrgb8888_cases[] = {
0x2A20300C, 0x1B1705CD, 0x03844672, 0x00000000, 0x00000000,
},
},
+ .gray8_result = {
+ .dst_pitch = 5,
+ .expected = {
+ 0x3C, 0x33, 0x34, 0x00, 0x00,
+ 0x6F, 0x3C, 0x33, 0x00, 0x00,
+ 0x34, 0x6F, 0x3C, 0x00, 0x00,
+ },
+ },
},
};
@@ -381,11 +412,42 @@ static void xrgb8888_to_xrgb2101010_test(struct kunit *test)
KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);
}
+static void xrgb8888_to_gray8_test(struct kunit *test)
+{
+ const struct convert_xrgb8888_case *params = test->param_value;
+ const struct convert_to_gray8_result *result = ¶ms->gray8_result;
+ size_t dst_size;
+ __u8 *buf = NULL;
+ __u32 *xrgb8888 = NULL;
+ struct iosys_map dst, src;
+
+ struct drm_framebuffer fb = {
+ .format = drm_format_info(DRM_FORMAT_XRGB8888),
+ .pitches = { params->pitch, 0, 0 },
+ };
+
+ dst_size = conversion_buf_size(DRM_FORMAT_R8, result->dst_pitch,
+ ¶ms->clip);
+ KUNIT_ASSERT_GT(test, dst_size, 0);
+
+ buf = kunit_kzalloc(test, dst_size, GFP_KERNEL);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buf);
+ iosys_map_set_vaddr(&dst, buf);
+
+ xrgb8888 = le32buf_to_cpu(test, params->xrgb8888, TEST_BUF_SIZE);
+ KUNIT_ASSERT_NOT_ERR_OR_NULL(test, xrgb8888);
+ iosys_map_set_vaddr(&src, xrgb8888);
+
+ drm_fb_xrgb8888_to_gray8(&dst, &result->dst_pitch, &src, &fb, ¶ms->clip);
+ KUNIT_EXPECT_EQ(test, memcmp(buf, result->expected, dst_size), 0);
+}
+
static struct kunit_case drm_format_helper_test_cases[] = {
KUNIT_CASE_PARAM(xrgb8888_to_rgb332_test, convert_xrgb8888_gen_params),
KUNIT_CASE_PARAM(xrgb8888_to_rgb565_test, convert_xrgb8888_gen_params),
KUNIT_CASE_PARAM(xrgb8888_to_rgb888_test, convert_xrgb8888_gen_params),
KUNIT_CASE_PARAM(xrgb8888_to_xrgb2101010_test, convert_xrgb8888_gen_params),
+ KUNIT_CASE_PARAM(xrgb8888_to_gray8_test, convert_xrgb8888_gen_params),
{}
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale
2022-08-28 16:45 [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
` (2 preceding siblings ...)
2022-08-28 16:45 ` [PATCH v3 3/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8() José Expósito
@ 2022-09-18 13:22 ` José Expósito
2022-09-18 16:26 ` Maíra Canal
3 siblings, 1 reply; 7+ messages in thread
From: José Expósito @ 2022-09-18 13:22 UTC (permalink / raw)
To: javierm
Cc: dri-devel, tzimmermann, magalilemes00, airlied, maira.canal,
dlatypov, linux-kernel, geert, tales.aparecida, davidgow,
isabbasso, kunit-dev
Hi!
On Sun, Aug 28, 2022 at 06:45:14PM +0200, José Expósito wrote:
> Hello everyone,
>
> This series is a follow up on my work adding KUnit test to the XRGB8888
> conversion functions. This time RGB888, XRGB2101010 and gray8 are added.
>
> Best wishes,
> Jose
>
> v1 -> v2:
>
> Tested-by: Maíra Canal <mairacanal@riseup.net>
> Reviewed-by: David Gow <davidgow@google.com>
>
> v2 -> v3:
>
> Export symbol drm_fb_xrgb8888_to_xrgb2101010()
This patchset is being in the mailing list for a while. Unless someone
has a reason to not merge it, I'd like to push it next week.
Thanks,
Jose
> José Expósito (3):
> drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888()
> drm/format-helper: Add KUnit tests for
> drm_fb_xrgb8888_to_xrgb2101010()
> drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8()
>
> drivers/gpu/drm/drm_format_helper.c | 1 +
> .../gpu/drm/tests/drm_format_helper_test.c | 190 ++++++++++++++++++
> 2 files changed, 191 insertions(+)
>
>
> base-commit: 61a9fa154d217c13eea90aa5bc635bc4b1fcb66e
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale
2022-09-18 13:22 ` [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
@ 2022-09-18 16:26 ` Maíra Canal
2022-09-19 6:29 ` José Expósito
0 siblings, 1 reply; 7+ messages in thread
From: Maíra Canal @ 2022-09-18 16:26 UTC (permalink / raw)
To: José Expósito, javierm
Cc: davidgow, magalilemes00, airlied, maira.canal, dlatypov,
linux-kernel, dri-devel, geert, tzimmermann, tales.aparecida,
isabbasso, kunit-dev
Hi Jose,
On 9/18/22 10:22, José Expósito wrote:
> Hi!
>
> On Sun, Aug 28, 2022 at 06:45:14PM +0200, José Expósito wrote:
>> Hello everyone,
>>
>> This series is a follow up on my work adding KUnit test to the XRGB8888
>> conversion functions. This time RGB888, XRGB2101010 and gray8 are added.
>>
>> Best wishes,
>> Jose
>>
>> v1 -> v2:
>>
>> Tested-by: Maíra Canal <mairacanal@riseup.net>
>> Reviewed-by: David Gow <davidgow@google.com>
>>
>> v2 -> v3:
>>
>> Export symbol drm_fb_xrgb8888_to_xrgb2101010()
>
> This patchset is being in the mailing list for a while. Unless someone
> has a reason to not merge it, I'd like to push it next week.
I believe this patchset doesn't apply anymore due to this patch [1],
that applied a naming convention for the DRM tests. Maybe you could send
a v3 rebasing the patchset.
[1]
https://lore.kernel.org/dri-devel/20220911191756.203118-1-mairacanal@riseup.net/T/#mb794103c8e39cdb76734f4e22ce90806f11d99bc
Best Regards,
- Maíra Canal
>
> Thanks,
> Jose
>
>> José Expósito (3):
>> drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888()
>> drm/format-helper: Add KUnit tests for
>> drm_fb_xrgb8888_to_xrgb2101010()
>> drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8()
>>
>> drivers/gpu/drm/drm_format_helper.c | 1 +
>> .../gpu/drm/tests/drm_format_helper_test.c | 190 ++++++++++++++++++
>> 2 files changed, 191 insertions(+)
>>
>>
>> base-commit: 61a9fa154d217c13eea90aa5bc635bc4b1fcb66e
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale
2022-09-18 16:26 ` Maíra Canal
@ 2022-09-19 6:29 ` José Expósito
0 siblings, 0 replies; 7+ messages in thread
From: José Expósito @ 2022-09-19 6:29 UTC (permalink / raw)
To: Maíra Canal
Cc: davidgow, magalilemes00, airlied, maira.canal, dlatypov, javierm,
dri-devel, linux-kernel, geert, tzimmermann, tales.aparecida,
isabbasso, kunit-dev
On Sun, Sep 18, 2022 at 01:26:06PM -0300, Maíra Canal wrote:
> Hi Jose,
>
> On 9/18/22 10:22, José Expósito wrote:
> > Hi!
> >
> > On Sun, Aug 28, 2022 at 06:45:14PM +0200, José Expósito wrote:
> >> Hello everyone,
> >>
> >> This series is a follow up on my work adding KUnit test to the XRGB8888
> >> conversion functions. This time RGB888, XRGB2101010 and gray8 are added.
> >>
> >> Best wishes,
> >> Jose
> >>
> >> v1 -> v2:
> >>
> >> Tested-by: Maíra Canal <mairacanal@riseup.net>
> >> Reviewed-by: David Gow <davidgow@google.com>
> >>
> >> v2 -> v3:
> >>
> >> Export symbol drm_fb_xrgb8888_to_xrgb2101010()
> >
> > This patchset is being in the mailing list for a while. Unless someone
> > has a reason to not merge it, I'd like to push it next week.
>
> I believe this patchset doesn't apply anymore due to this patch [1],
> that applied a naming convention for the DRM tests. Maybe you could send
> a v3 rebasing the patchset.
>
> [1]
> https://lore.kernel.org/dri-devel/20220911191756.203118-1-mairacanal@riseup.net/T/#mb794103c8e39cdb76734f4e22ce90806f11d99bc
>
> Best Regards,
> - Maíra Canal
Thanks for the heads up Maíra, I didn't noticed that you patches were
already merged.
I'll rebase on top of your work and send v4.
Best wishes,
Jose
> >
> > Thanks,
> > Jose
> >
> >> José Expósito (3):
> >> drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888()
> >> drm/format-helper: Add KUnit tests for
> >> drm_fb_xrgb8888_to_xrgb2101010()
> >> drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8()
> >>
> >> drivers/gpu/drm/drm_format_helper.c | 1 +
> >> .../gpu/drm/tests/drm_format_helper_test.c | 190 ++++++++++++++++++
> >> 2 files changed, 191 insertions(+)
> >>
> >>
> >> base-commit: 61a9fa154d217c13eea90aa5bc635bc4b1fcb66e
> >> --
> >> 2.25.1
> >>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-19 6:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-28 16:45 [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
2022-08-28 16:45 ` [PATCH v3 1/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb888() José Expósito
2022-08-28 16:45 ` [PATCH v3 2/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_xrgb2101010() José Expósito
2022-08-28 16:45 ` [PATCH v3 3/3] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_gray8() José Expósito
2022-09-18 13:22 ` [PATCH v3 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale José Expósito
2022-09-18 16:26 ` Maíra Canal
2022-09-19 6:29 ` José Expósito
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).