From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: devicetree@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>,
David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>,
freedreno@lists.freedesktop.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml
Date: Thu, 1 Sep 2022 13:23:04 +0300 [thread overview]
Message-ID: <20220901102312.2005553-5-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20220901102312.2005553-1-dmitry.baryshkov@linaro.org>
Move properties common to all DPU DT nodes to the dpu-common.yaml.
Note, this removes description of individual DPU port@ nodes. However
such definitions add no additional value. The reg values do not
correspond to hardware INTF indices. The driver discovers and binds
these ports not paying any care for the order of these items. Thus just
leave the reference to graph.yaml#/properties/ports and the description.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
.../bindings/display/msm/dpu-common.yaml | 44 ++++++++++++++++++
.../bindings/display/msm/dpu-msm8998.yaml | 46 ++-----------------
.../bindings/display/msm/dpu-qcm2290.yaml | 41 ++---------------
.../bindings/display/msm/dpu-sc7180.yaml | 45 ++----------------
.../bindings/display/msm/dpu-sc7280.yaml | 45 ++----------------
.../bindings/display/msm/dpu-sdm845.yaml | 46 ++-----------------
6 files changed, 64 insertions(+), 203 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-common.yaml
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-common.yaml b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
new file mode 100644
index 000000000000..bf5764e9932b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/dpu-common.yaml
@@ -0,0 +1,44 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/dpu-common.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Display DPU dt properties (common properties)
+
+maintainers:
+ - Krishna Manikandan <quic_mkrishn@quicinc.com>
+ - Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
+ - Rob Clark <robdclark@gmail.com>
+
+description: |
+ Common properties for QCom DPU display controller.
+
+properties:
+ interrupts:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ operating-points-v2: true
+ opp-table:
+ type: object
+
+ ports:
+ $ref: /schemas/graph.yaml#/properties/ports
+ description: |
+ Contains the list of output ports from DPU device. These ports
+ connect to interfaces that are external to the DPU hardware,
+ such as DSI, DP etc.
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - clocks
+ - interrupts
+ - power-domains
+ - operating-points-v2
+ - ports
+
+additionalProperties: true
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
index 253665c693e6..0d6743eabd27 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
@@ -62,7 +62,10 @@ patternProperties:
"^display-controller@[0-9a-f]+$":
type: object
description: Node containing the properties of DPU.
- additionalProperties: false
+ unevaluatedProperties: false
+
+ allOf:
+ - $ref: /schemas/display/msm/dpu-common.yaml#
properties:
compatible:
@@ -99,47 +102,6 @@ patternProperties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- opp-table:
- type: object
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
-
- required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index c5824e1d2382..bec3c131c0dc 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -74,7 +74,10 @@ patternProperties:
"^display-controller@[0-9a-f]+$":
type: object
description: Node containing the properties of DPU.
- additionalProperties: false
+ unevaluatedProperties: false
+
+ allOf:
+ - $ref: /schemas/display/msm/dpu-common.yaml#
properties:
compatible:
@@ -107,42 +110,6 @@ patternProperties:
- const: lut
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- opp-table:
- type: object
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- required:
- - port@0
-
- required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
index 4890bc25f3fd..732b9d8f968a 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
@@ -73,7 +73,10 @@ patternProperties:
"^display-controller@[0-9a-f]+$":
type: object
description: Node containing the properties of DPU.
- additionalProperties: false
+ unevaluatedProperties: false
+
+ allOf:
+ - $ref: /schemas/display/msm/dpu-common.yaml#
properties:
compatible:
@@ -108,46 +111,6 @@ patternProperties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- opp-table:
- type: object
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@2:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF0 (DP)
-
- required:
- - port@0
-
- required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
index 584d646021d5..4889129660c6 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml
@@ -72,7 +72,10 @@ patternProperties:
"^display-controller@[0-9a-f]+$":
type: object
description: Node containing the properties of DPU.
- additionalProperties: false
+ unevaluatedProperties: false
+
+ allOf:
+ - $ref: /schemas/display/msm/dpu-common.yaml#
properties:
compatible:
@@ -106,46 +109,6 @@ patternProperties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- opp-table:
- type: object
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF5 (EDP)
-
- required:
- - port@0
-
- required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
index ff19555d04e2..b275f928a921 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
@@ -75,7 +75,10 @@ patternProperties:
"^display-controller@[0-9a-f]+$":
type: object
description: Node containing the properties of DPU.
- additionalProperties: false
+ unevaluatedProperties: false
+
+ allOf:
+ - $ref: /schemas/display/msm/dpu-common.yaml#
properties:
compatible:
@@ -108,47 +111,6 @@ patternProperties:
- const: core
- const: vsync
- interrupts:
- maxItems: 1
-
- power-domains:
- maxItems: 1
-
- operating-points-v2: true
- opp-table:
- type: object
-
- ports:
- $ref: /schemas/graph.yaml#/properties/ports
- description: |
- Contains the list of output ports from DPU device. These ports
- connect to interfaces that are external to the DPU hardware,
- such as DSI, DP etc. Each output port contains an endpoint that
- describes how it is connected to an external interface.
-
- properties:
- port@0:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF1 (DSI1)
-
- port@1:
- $ref: /schemas/graph.yaml#/properties/port
- description: DPU_INTF2 (DSI2)
-
- required:
- - port@0
- - port@1
-
- required:
- - compatible
- - reg
- - reg-names
- - clocks
- - interrupts
- - power-domains
- - operating-points-v2
- - ports
-
required:
- compatible
- reg
--
2.35.1
next prev parent reply other threads:[~2022-09-01 10:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 10:23 [PATCH v6 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Dmitry Baryshkov
2022-09-07 19:49 ` Rob Herring
2022-09-08 13:37 ` Krzysztof Kozlowski
2022-09-08 19:37 ` Rob Herring
2022-09-08 20:20 ` Dmitry Baryshkov
2022-09-09 22:23 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings Rob Herring
2022-09-10 8:45 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Krzysztof Kozlowski
2022-09-10 12:54 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings Dmitry Baryshkov
2022-09-11 11:27 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Krzysztof Kozlowski
2022-09-11 13:45 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings Dmitry Baryshkov
2022-09-11 13:57 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Krzysztof Kozlowski
2022-09-11 17:45 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings Dmitry Baryshkov
2022-09-11 18:32 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Krzysztof Kozlowski
2022-09-11 18:36 ` Krzysztof Kozlowski
2022-09-11 18:55 ` Krzysztof Kozlowski
2022-09-11 19:19 ` Krzysztof Kozlowski
2022-09-15 11:50 ` Dmitry Baryshkov
2022-09-15 14:33 ` Krzysztof Kozlowski
2022-09-01 10:23 ` [PATCH v6 02/12] dt-bindings: display/msm: add gcc-bus clock to dpu-smd845 Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845 Dmitry Baryshkov
2022-09-07 19:51 ` [PATCH v6 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845 Rob Herring
2022-09-01 10:23 ` Dmitry Baryshkov [this message]
2022-09-07 19:59 ` [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml Rob Herring
2022-09-07 21:13 ` Dmitry Baryshkov
2022-09-15 12:44 ` Dmitry Baryshkov
2022-09-07 20:00 ` Rob Herring
2022-09-01 10:23 ` [PATCH v6 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Dmitry Baryshkov
2022-09-07 20:03 ` Rob Herring
2022-09-01 10:23 ` [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts Dmitry Baryshkov
2022-09-07 20:16 ` Rob Herring
2022-09-08 13:44 ` Krzysztof Kozlowski
2022-09-08 13:45 ` Krzysztof Kozlowski
2022-09-01 10:23 ` [PATCH v6 07/12] dt-bindings: display/msm: split dpu-sc7280 " Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 08/12] dt-bindings: display/msm: split dpu-sdm845 " Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 09/12] dt-bindings: display/msm: split dpu-msm8998 " Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 10/12] dt-bindings: display/msm: split dpu-qcm2290 " Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas Dmitry Baryshkov
2022-09-07 20:19 ` Rob Herring
2022-09-01 10:23 ` [PATCH v6 12/12] dt-bindings: display/msm: add support for the display on SM8250 Dmitry Baryshkov
2022-09-07 20:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901102312.2005553-5-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).