From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Loic Poulain <loic.poulain@linaro.org>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Stephen Boyd <swboyd@chromium.org>,
Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
freedreno <freedreno@lists.freedesktop.org>,
Sean Paul <sean@poorly.run>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings
Date: Sun, 11 Sep 2022 15:57:26 +0200 [thread overview]
Message-ID: <f013accb-96f7-a025-1d41-e2e97f8b2aa8@linaro.org> (raw)
In-Reply-To: <CAA8EJpoPPRAQPfVQmSfrrDrroMp0bzvJ=-vHMRx72aKTBgPOTA@mail.gmail.com>
On 11/09/2022 15:45, Dmitry Baryshkov wrote:
> On Sun, 11 Sept 2022 at 14:27, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 10/09/2022 14:54, Dmitry Baryshkov wrote:
>>>>
>>>> However I think there is no such problem, as Dmitry said, that ref
>>>> changes anything. There will be always failure - either from parent
>>>> schema (using $ref) or from device child schema (the one which actually
>>>> misses the property).
>>>
>>> Initially I stumbled upon this issue with the dsi and dsi_phy nodes
>>> for msm8996 devices. If I have $ref here, dsi1/dsi1_phy nodes will
>>> emit warnings regarding the missing -supply properties despite nodes
>>> being disabled. If I use `compatible' here, the schema checks pass.
>>> Thus I'd prefer to leave `compatible' here. Not to mention that it
>>> also allows specifying a tighter binding than just using the $ref.
>>
>> I don't think we understood each other. I claim that error will be there
>> anyway, just from different schema. So your change fixes nothing in
>> total schema check...
>
> If the node is disabled, there will be no different schema check.
As I wrote before, there was.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-11 13:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 10:23 [PATCH v6 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Dmitry Baryshkov
2022-09-07 19:49 ` Rob Herring
2022-09-08 13:37 ` Krzysztof Kozlowski
2022-09-08 19:37 ` Rob Herring
2022-09-08 20:20 ` Dmitry Baryshkov
2022-09-09 22:23 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings Rob Herring
2022-09-10 8:45 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Krzysztof Kozlowski
2022-09-10 12:54 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings Dmitry Baryshkov
2022-09-11 11:27 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Krzysztof Kozlowski
2022-09-11 13:45 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings Dmitry Baryshkov
2022-09-11 13:57 ` Krzysztof Kozlowski [this message]
2022-09-11 17:45 ` Dmitry Baryshkov
2022-09-11 18:32 ` [PATCH v6 01/12] dt-bindings: display/msm: split qcom,mdss bindings Krzysztof Kozlowski
2022-09-11 18:36 ` Krzysztof Kozlowski
2022-09-11 18:55 ` Krzysztof Kozlowski
2022-09-11 19:19 ` Krzysztof Kozlowski
2022-09-15 11:50 ` Dmitry Baryshkov
2022-09-15 14:33 ` Krzysztof Kozlowski
2022-09-01 10:23 ` [PATCH v6 02/12] dt-bindings: display/msm: add gcc-bus clock to dpu-smd845 Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845 Dmitry Baryshkov
2022-09-07 19:51 ` [PATCH v6 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845 Rob Herring
2022-09-01 10:23 ` [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml Dmitry Baryshkov
2022-09-07 19:59 ` Rob Herring
2022-09-07 21:13 ` Dmitry Baryshkov
2022-09-15 12:44 ` Dmitry Baryshkov
2022-09-07 20:00 ` Rob Herring
2022-09-01 10:23 ` [PATCH v6 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Dmitry Baryshkov
2022-09-07 20:03 ` Rob Herring
2022-09-01 10:23 ` [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts Dmitry Baryshkov
2022-09-07 20:16 ` Rob Herring
2022-09-08 13:44 ` Krzysztof Kozlowski
2022-09-08 13:45 ` Krzysztof Kozlowski
2022-09-01 10:23 ` [PATCH v6 07/12] dt-bindings: display/msm: split dpu-sc7280 " Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 08/12] dt-bindings: display/msm: split dpu-sdm845 " Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 09/12] dt-bindings: display/msm: split dpu-msm8998 " Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 10/12] dt-bindings: display/msm: split dpu-qcm2290 " Dmitry Baryshkov
2022-09-01 10:23 ` [PATCH v6 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas Dmitry Baryshkov
2022-09-07 20:19 ` Rob Herring
2022-09-01 10:23 ` [PATCH v6 12/12] dt-bindings: display/msm: add support for the display on SM8250 Dmitry Baryshkov
2022-09-07 20:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f013accb-96f7-a025-1d41-e2e97f8b2aa8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).