* [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c @ 2022-09-05 8:38 Jingyu Wang 2022-09-06 13:46 ` Felix Kuehling 0 siblings, 1 reply; 4+ messages in thread From: Jingyu Wang @ 2022-09-05 8:38 UTC (permalink / raw) To: Felix.Kuehling, alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel Cc: Jingyu Wang, dri-devel, amd-gfx, linux-kernel Fix everything checkpatch.pl complained about in amdgpu_amdkfd_gpuvm.c Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c index cbd593f7d553..eff596c60c89 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: MIT /* * Copyright 2014-2018 Advanced Micro Devices, Inc. * @@ -1612,6 +1613,7 @@ size_t amdgpu_amdkfd_get_available_memory(struct amdgpu_device *adev) uint64_t reserved_for_pt = ESTIMATE_PT_SIZE(amdgpu_amdkfd_total_mem_size); size_t available; + spin_lock(&kfd_mem_limit.mem_limit_lock); available = adev->gmc.real_vram_size - adev->kfd.vram_used_aligned @@ -2216,7 +2218,7 @@ int amdgpu_amdkfd_gpuvm_get_vm_fault_info(struct amdgpu_device *adev, { if (atomic_read(&adev->gmc.vm_fault_info_updated) == 1) { *mem = *adev->gmc.vm_fault_info; - mb(); + mb(); /* make sure read happened */ atomic_set(&adev->gmc.vm_fault_info_updated, 0); } return 0; base-commit: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c 2022-09-05 8:38 [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c Jingyu Wang @ 2022-09-06 13:46 ` Felix Kuehling 2022-09-06 18:48 ` Deucher, Alexander 0 siblings, 1 reply; 4+ messages in thread From: Felix Kuehling @ 2022-09-06 13:46 UTC (permalink / raw) To: Jingyu Wang, alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel Cc: dri-devel, amd-gfx, linux-kernel Am 2022-09-05 um 04:38 schrieb Jingyu Wang: > Fix everything checkpatch.pl complained about in amdgpu_amdkfd_gpuvm.c > > Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > index cbd593f7d553..eff596c60c89 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: MIT I'm not sure if this is correct. We've used "GPL-2.0 OR MIT" in KFD. In amdgpu there is currently a mix of licenses. Alex, do you want to make a call on a consistent one to use in amdgpu? Other than that, this patch is Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> > /* > * Copyright 2014-2018 Advanced Micro Devices, Inc. > * > @@ -1612,6 +1613,7 @@ size_t amdgpu_amdkfd_get_available_memory(struct amdgpu_device *adev) > uint64_t reserved_for_pt = > ESTIMATE_PT_SIZE(amdgpu_amdkfd_total_mem_size); > size_t available; > + > spin_lock(&kfd_mem_limit.mem_limit_lock); > available = adev->gmc.real_vram_size > - adev->kfd.vram_used_aligned > @@ -2216,7 +2218,7 @@ int amdgpu_amdkfd_gpuvm_get_vm_fault_info(struct amdgpu_device *adev, > { > if (atomic_read(&adev->gmc.vm_fault_info_updated) == 1) { > *mem = *adev->gmc.vm_fault_info; > - mb(); > + mb(); /* make sure read happened */ > atomic_set(&adev->gmc.vm_fault_info_updated, 0); > } > return 0; > > base-commit: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c 2022-09-06 13:46 ` Felix Kuehling @ 2022-09-06 18:48 ` Deucher, Alexander 2022-09-09 20:58 ` Alex Deucher 0 siblings, 1 reply; 4+ messages in thread From: Deucher, Alexander @ 2022-09-06 18:48 UTC (permalink / raw) To: Kuehling, Felix, Jingyu Wang, Koenig, Christian, Pan, Xinhui, airlied, daniel Cc: dri-devel, amd-gfx, linux-kernel [-- Attachment #1: Type: text/plain, Size: 2573 bytes --] [Public] Yeah, seems to be a mix. I don't have a strong opinion as long as it has MIT. Alex ________________________________ From: Kuehling, Felix <Felix.Kuehling@amd.com> Sent: Tuesday, September 6, 2022 9:46 AM To: Jingyu Wang <jingyuwang_vip@163.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; airlied@linux.ie <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch> Cc: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c Am 2022-09-05 um 04:38 schrieb Jingyu Wang: > Fix everything checkpatch.pl complained about in amdgpu_amdkfd_gpuvm.c > > Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > index cbd593f7d553..eff596c60c89 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: MIT I'm not sure if this is correct. We've used "GPL-2.0 OR MIT" in KFD. In amdgpu there is currently a mix of licenses. Alex, do you want to make a call on a consistent one to use in amdgpu? Other than that, this patch is Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> > /* > * Copyright 2014-2018 Advanced Micro Devices, Inc. > * > @@ -1612,6 +1613,7 @@ size_t amdgpu_amdkfd_get_available_memory(struct amdgpu_device *adev) > uint64_t reserved_for_pt = > ESTIMATE_PT_SIZE(amdgpu_amdkfd_total_mem_size); > size_t available; > + > spin_lock(&kfd_mem_limit.mem_limit_lock); > available = adev->gmc.real_vram_size > - adev->kfd.vram_used_aligned > @@ -2216,7 +2218,7 @@ int amdgpu_amdkfd_gpuvm_get_vm_fault_info(struct amdgpu_device *adev, > { > if (atomic_read(&adev->gmc.vm_fault_info_updated) == 1) { > *mem = *adev->gmc.vm_fault_info; > - mb(); > + mb(); /* make sure read happened */ > atomic_set(&adev->gmc.vm_fault_info_updated, 0); > } > return 0; > > base-commit: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 [-- Attachment #2: Type: text/html, Size: 4974 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c 2022-09-06 18:48 ` Deucher, Alexander @ 2022-09-09 20:58 ` Alex Deucher 0 siblings, 0 replies; 4+ messages in thread From: Alex Deucher @ 2022-09-09 20:58 UTC (permalink / raw) To: Deucher, Alexander Cc: Jingyu Wang, airlied, Kuehling, Felix, Pan, Xinhui, linux-kernel, dri-devel, amd-gfx, Koenig, Christian Applied. Thanks! Alex On Tue, Sep 6, 2022 at 2:48 PM Deucher, Alexander <Alexander.Deucher@amd.com> wrote: > > [Public] > > > Yeah, seems to be a mix. I don't have a strong opinion as long as it has MIT. > > Alex > > ________________________________ > From: Kuehling, Felix <Felix.Kuehling@amd.com> > Sent: Tuesday, September 6, 2022 9:46 AM > To: Jingyu Wang <jingyuwang_vip@163.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; airlied@linux.ie <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch> > Cc: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c > > > Am 2022-09-05 um 04:38 schrieb Jingyu Wang: > > Fix everything checkpatch.pl complained about in amdgpu_amdkfd_gpuvm.c > > > > Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > index cbd593f7d553..eff596c60c89 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > > @@ -1,3 +1,4 @@ > > +// SPDX-License-Identifier: MIT > > I'm not sure if this is correct. We've used "GPL-2.0 OR MIT" in KFD. In > amdgpu there is currently a mix of licenses. Alex, do you want to make a > call on a consistent one to use in amdgpu? > > Other than that, this patch is > > Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> > > > > /* > > * Copyright 2014-2018 Advanced Micro Devices, Inc. > > * > > @@ -1612,6 +1613,7 @@ size_t amdgpu_amdkfd_get_available_memory(struct amdgpu_device *adev) > > uint64_t reserved_for_pt = > > ESTIMATE_PT_SIZE(amdgpu_amdkfd_total_mem_size); > > size_t available; > > + > > spin_lock(&kfd_mem_limit.mem_limit_lock); > > available = adev->gmc.real_vram_size > > - adev->kfd.vram_used_aligned > > @@ -2216,7 +2218,7 @@ int amdgpu_amdkfd_gpuvm_get_vm_fault_info(struct amdgpu_device *adev, > > { > > if (atomic_read(&adev->gmc.vm_fault_info_updated) == 1) { > > *mem = *adev->gmc.vm_fault_info; > > - mb(); > > + mb(); /* make sure read happened */ > > atomic_set(&adev->gmc.vm_fault_info_updated, 0); > > } > > return 0; > > > > base-commit: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-09 20:59 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-05 8:38 [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c Jingyu Wang 2022-09-06 13:46 ` Felix Kuehling 2022-09-06 18:48 ` Deucher, Alexander 2022-09-09 20:58 ` Alex Deucher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).