dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type()
@ 2022-09-26  6:40 Jiapeng Chong
  2022-09-26  6:40 ` [PATCH 1/2] drm/i915/gvt: Fix kernel-doc Jiapeng Chong
  2022-11-08  7:23 ` [PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type() Zhenyu Wang
  0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2022-09-26  6:40 UTC (permalink / raw)
  To: zhenyuw
  Cc: tvrtko.ursulin, Jiapeng Chong, airlied, intel-gfx, Abaci Robot,
	linux-kernel, dri-devel, rodrigo.vivi, intel-gvt-dev, zhi.a.wang

The function get_pt_type is defined in the gtt.c file, but not
called elsewhere, so delete this unused function.

drivers/gpu/drm/i915/gvt/gtt.c:285:19: warning: unused function 'get_pt_type'.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2277
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpu/drm/i915/gvt/gtt.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index ce0eb03709c3..6cd4c1d386a5 100644
--- a/drivers/gpu/drm/i915/gvt/gtt.c
+++ b/drivers/gpu/drm/i915/gvt/gtt.c
@@ -282,11 +282,6 @@ static inline int get_next_pt_type(int type)
 	return gtt_type_table[type].next_pt_type;
 }
 
-static inline int get_pt_type(int type)
-{
-	return gtt_type_table[type].pt_type;
-}
-
 static inline int get_entry_type(int type)
 {
 	return gtt_type_table[type].entry_type;
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 1/2] drm/i915/gvt: Fix kernel-doc
  2022-09-26  6:40 [PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type() Jiapeng Chong
@ 2022-09-26  6:40 ` Jiapeng Chong
  2022-11-08  7:23 ` [PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type() Zhenyu Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Jiapeng Chong @ 2022-09-26  6:40 UTC (permalink / raw)
  To: zhenyuw
  Cc: tvrtko.ursulin, Jiapeng Chong, airlied, intel-gfx, Abaci Robot,
	linux-kernel, dri-devel, rodrigo.vivi, intel-gvt-dev, zhi.a.wang

drivers/gpu/drm/i915/gvt/vgpu.c:356: warning: expecting prototype for intel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2276
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpu/drm/i915/gvt/vgpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
index 5c533fbc2c8d..e081027761d5 100644
--- a/drivers/gpu/drm/i915/gvt/vgpu.c
+++ b/drivers/gpu/drm/i915/gvt/vgpu.c
@@ -346,7 +346,7 @@ struct intel_vgpu *intel_gvt_create_idle_vgpu(struct intel_gvt *gvt)
 }
 
 /**
- * intel_gvt_destroy_vgpu - destroy an idle virtual GPU
+ * intel_gvt_destroy_idle_vgpu() - destroy an idle virtual GPU
  * @vgpu: virtual GPU
  *
  * This function is called when user wants to destroy an idle virtual GPU.
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type()
  2022-09-26  6:40 [PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type() Jiapeng Chong
  2022-09-26  6:40 ` [PATCH 1/2] drm/i915/gvt: Fix kernel-doc Jiapeng Chong
@ 2022-11-08  7:23 ` Zhenyu Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Zhenyu Wang @ 2022-11-08  7:23 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: tvrtko.ursulin, airlied, intel-gfx, Abaci Robot, linux-kernel,
	dri-devel, rodrigo.vivi, intel-gvt-dev, zhi.a.wang

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On 2022.09.26 14:40:43 +0800, Jiapeng Chong wrote:
> The function get_pt_type is defined in the gtt.c file, but not
> called elsewhere, so delete this unused function.
> 
> drivers/gpu/drm/i915/gvt/gtt.c:285:19: warning: unused function 'get_pt_type'.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2277
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/gpu/drm/i915/gvt/gtt.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> index ce0eb03709c3..6cd4c1d386a5 100644
> --- a/drivers/gpu/drm/i915/gvt/gtt.c
> +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> @@ -282,11 +282,6 @@ static inline int get_next_pt_type(int type)
>  	return gtt_type_table[type].next_pt_type;
>  }
>  
> -static inline int get_pt_type(int type)
> -{
> -	return gtt_type_table[type].pt_type;
> -}
> -
>  static inline int get_entry_type(int type)
>  {
>  	return gtt_type_table[type].entry_type;
> -- 
> 2.20.1.7.g153144c
> 

Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>

thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-08  7:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26  6:40 [PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type() Jiapeng Chong
2022-09-26  6:40 ` [PATCH 1/2] drm/i915/gvt: Fix kernel-doc Jiapeng Chong
2022-11-08  7:23 ` [PATCH 2/2] drm/i915/gvt: Remove the unused function get_pt_type() Zhenyu Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).