* [PATCH] drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR
@ 2022-10-19 22:24 Matt Roper
2022-10-20 9:34 ` [Intel-gfx] " Murthy, Arun R
0 siblings, 1 reply; 2+ messages in thread
From: Matt Roper @ 2022-10-19 22:24 UTC (permalink / raw)
To: intel-gfx; +Cc: kernel test robot, dri-devel
A misplaced closing parenthesis caused the groupid/instanceid values to
be considered part of the ternary operator's condition instead of being
OR'd into the resulting value.
Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
index 0d2811724b00..46cf2f3d1e8e 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
@@ -249,7 +249,7 @@ static u32 rw_with_mcr_steering_fw(struct intel_uncore *uncore,
intel_uncore_write_fw(uncore, MTL_MCR_SELECTOR,
REG_FIELD_PREP(MTL_MCR_GROUPID, group) |
REG_FIELD_PREP(MTL_MCR_INSTANCEID, instance) |
- (rw_flag == FW_REG_READ) ? GEN11_MCR_MULTICAST : 0);
+ (rw_flag == FW_REG_READ ? GEN11_MCR_MULTICAST : 0));
} else if (GRAPHICS_VER(uncore->i915) >= 11) {
mcr_mask = GEN11_MCR_SLICE_MASK | GEN11_MCR_SUBSLICE_MASK;
mcr_ss = GEN11_MCR_SLICE(group) | GEN11_MCR_SUBSLICE(instance);
--
2.37.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [Intel-gfx] [PATCH] drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR
2022-10-19 22:24 [PATCH] drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR Matt Roper
@ 2022-10-20 9:34 ` Murthy, Arun R
0 siblings, 0 replies; 2+ messages in thread
From: Murthy, Arun R @ 2022-10-20 9:34 UTC (permalink / raw)
To: Roper, Matthew D, intel-gfx; +Cc: dri-devel
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Matt
> Roper
> Sent: Thursday, October 20, 2022 3:55 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH] drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR
>
> A misplaced closing parenthesis caused the groupid/instanceid values to be
> considered part of the ternary operator's condition instead of being OR'd
> into the resulting value.
>
> Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Thanks and Regards,
Arun R Murthy
--------------------
> drivers/gpu/drm/i915/gt/intel_gt_mcr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> index 0d2811724b00..46cf2f3d1e8e 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_mcr.c
> @@ -249,7 +249,7 @@ static u32 rw_with_mcr_steering_fw(struct
> intel_uncore *uncore,
> intel_uncore_write_fw(uncore, MTL_MCR_SELECTOR,
> REG_FIELD_PREP(MTL_MCR_GROUPID,
> group) |
> REG_FIELD_PREP(MTL_MCR_INSTANCEID,
> instance) |
> - (rw_flag == FW_REG_READ) ?
> GEN11_MCR_MULTICAST : 0);
> + (rw_flag == FW_REG_READ ?
> GEN11_MCR_MULTICAST : 0));
> } else if (GRAPHICS_VER(uncore->i915) >= 11) {
> mcr_mask = GEN11_MCR_SLICE_MASK |
> GEN11_MCR_SUBSLICE_MASK;
> mcr_ss = GEN11_MCR_SLICE(group) |
> GEN11_MCR_SUBSLICE(instance);
> --
> 2.37.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-20 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 22:24 [PATCH] drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR Matt Roper
2022-10-20 9:34 ` [Intel-gfx] " Murthy, Arun R
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).