* [PATCH] drm/bridge: sii9234: Remove the unused function sii9234_mode_valid()
@ 2022-11-04 6:36 Jiapeng Chong
2022-11-07 15:48 ` Robert Foss
2022-11-08 12:40 ` Dave Stevenson
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2022-11-04 6:36 UTC (permalink / raw)
To: andrzej.hajda
Cc: neil.armstrong, jonas, robert.foss, dri-devel, Abaci Robot,
linux-kernel, jernej.skrabec, Jiapeng Chong, Laurent.pinchart
The function sii9234_mode_valid() is defined in the sii9234.c file, but
not called elsewhere, so remove this unused function.
drivers/gpu/drm/bridge/sii9234.c:870:31: warning: unused function 'bridge_to_sii9234'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2735
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/bridge/sii9234.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
index 5b3061d4b5c3..62b6bc8ca7af 100644
--- a/drivers/gpu/drm/bridge/sii9234.c
+++ b/drivers/gpu/drm/bridge/sii9234.c
@@ -867,11 +867,6 @@ static int sii9234_init_resources(struct sii9234 *ctx,
return 0;
}
-static inline struct sii9234 *bridge_to_sii9234(struct drm_bridge *bridge)
-{
- return container_of(bridge, struct sii9234, bridge);
-}
-
static enum drm_mode_status sii9234_mode_valid(struct drm_bridge *bridge,
const struct drm_display_info *info,
const struct drm_display_mode *mode)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: sii9234: Remove the unused function sii9234_mode_valid()
2022-11-04 6:36 [PATCH] drm/bridge: sii9234: Remove the unused function sii9234_mode_valid() Jiapeng Chong
@ 2022-11-07 15:48 ` Robert Foss
2022-11-08 12:40 ` Dave Stevenson
1 sibling, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-11-07 15:48 UTC (permalink / raw)
To: Jiapeng Chong
Cc: neil.armstrong, jonas, dri-devel, Abaci Robot, linux-kernel,
jernej.skrabec, Laurent.pinchart, andrzej.hajda
On Fri, 4 Nov 2022 at 07:37, Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> The function sii9234_mode_valid() is defined in the sii9234.c file, but
> not called elsewhere, so remove this unused function.
>
> drivers/gpu/drm/bridge/sii9234.c:870:31: warning: unused function 'bridge_to_sii9234'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2735
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/bridge/sii9234.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
> index 5b3061d4b5c3..62b6bc8ca7af 100644
> --- a/drivers/gpu/drm/bridge/sii9234.c
> +++ b/drivers/gpu/drm/bridge/sii9234.c
> @@ -867,11 +867,6 @@ static int sii9234_init_resources(struct sii9234 *ctx,
> return 0;
> }
>
> -static inline struct sii9234 *bridge_to_sii9234(struct drm_bridge *bridge)
> -{
> - return container_of(bridge, struct sii9234, bridge);
> -}
> -
> static enum drm_mode_status sii9234_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_info *info,
> const struct drm_display_mode *mode)
> --
> 2.20.1.7.g153144c
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: sii9234: Remove the unused function sii9234_mode_valid()
2022-11-04 6:36 [PATCH] drm/bridge: sii9234: Remove the unused function sii9234_mode_valid() Jiapeng Chong
2022-11-07 15:48 ` Robert Foss
@ 2022-11-08 12:40 ` Dave Stevenson
1 sibling, 0 replies; 3+ messages in thread
From: Dave Stevenson @ 2022-11-08 12:40 UTC (permalink / raw)
To: Jiapeng Chong
Cc: neil.armstrong, jernej.skrabec, jonas, Abaci Robot, linux-kernel,
dri-devel, robert.foss, andrzej.hajda, Laurent.pinchart
On Fri, 4 Nov 2022 at 06:37, Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> The function sii9234_mode_valid() is defined in the sii9234.c file, but
> not called elsewhere, so remove this unused function.
Did you mean bridge_to_sii9234() rather than sii9234_mode_valid() here?
sii9234_mode_valid() is referenced in sii9234_bridge_funcs, and it's
bridge_to_sii9234 that you've actually removed.
Dave
> drivers/gpu/drm/bridge/sii9234.c:870:31: warning: unused function 'bridge_to_sii9234'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2735
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/bridge/sii9234.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c
> index 5b3061d4b5c3..62b6bc8ca7af 100644
> --- a/drivers/gpu/drm/bridge/sii9234.c
> +++ b/drivers/gpu/drm/bridge/sii9234.c
> @@ -867,11 +867,6 @@ static int sii9234_init_resources(struct sii9234 *ctx,
> return 0;
> }
>
> -static inline struct sii9234 *bridge_to_sii9234(struct drm_bridge *bridge)
> -{
> - return container_of(bridge, struct sii9234, bridge);
> -}
> -
> static enum drm_mode_status sii9234_mode_valid(struct drm_bridge *bridge,
> const struct drm_display_info *info,
> const struct drm_display_mode *mode)
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-08 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-04 6:36 [PATCH] drm/bridge: sii9234: Remove the unused function sii9234_mode_valid() Jiapeng Chong
2022-11-07 15:48 ` Robert Foss
2022-11-08 12:40 ` Dave Stevenson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).