* [PATCH -next] drm/amd/display: Remove unneeded semicolon
@ 2023-01-06 0:24 Yang Li
2023-01-06 15:29 ` Alex Deucher
0 siblings, 1 reply; 9+ messages in thread
From: Yang Li @ 2023-01-06 0:24 UTC (permalink / raw)
To: alexander.deucher
Cc: , ,
sunpeng.li, Xinhui.Pan, Rodrigo.Siqueira, linux-kernel, amd-gfx,
Abaci Robot, Yang Li, dri-devel
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:7431:3-4: Unneeded semicolon
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:7485:4-5: Unneeded semicolon
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:7489:3-4: Unneeded semicolon
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3635
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index cabe02cb307c..90dc72e98eb2 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7428,7 +7428,7 @@ static bool is_content_protection_different(struct drm_crtc_state *new_crtc_stat
new_conn_state->content_protection = DRM_MODE_CONTENT_PROTECTION_DESIRED;
pr_debug("[HDCP_DM] ENABLED->DESIRED & mode_changed %s :true\n", __func__);
return true;
- };
+ }
new_conn_state->content_protection = DRM_MODE_CONTENT_PROTECTION_ENABLED;
pr_debug("[HDCP_DM] ENABLED -> DESIRED %s :false\n", __func__);
return false;
@@ -7482,11 +7482,11 @@ static bool is_content_protection_different(struct drm_crtc_state *new_crtc_stat
pr_debug("[HDCP_DM] DESIRED->DESIRED or ENABLE->ENABLE mode_change %s :true\n",
__func__);
return true;
- };
+ }
pr_debug("[HDCP_DM] DESIRED->DESIRED & ENABLE->ENABLE %s :false\n",
__func__);
return false;
- };
+ }
pr_debug("[HDCP_DM] UNDESIRED->UNDESIRED %s :false\n", __func__);
return false;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH -next] drm/amd/display: Remove unneeded semicolon
2023-01-06 0:24 [PATCH -next] drm/amd/display: Remove unneeded semicolon Yang Li
@ 2023-01-06 15:29 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2023-01-06 15:29 UTC (permalink / raw)
To: Yang Li
Cc: sunpeng.li, Abaci Robot, Xinhui.Pan, Rodrigo.Siqueira,
linux-kernel, amd-gfx, dri-devel, alexander.deucher
Applied. Thanks!
Alex
On Thu, Jan 5, 2023 at 7:30 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:7431:3-4: Unneeded semicolon
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:7485:4-5: Unneeded semicolon
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:7489:3-4: Unneeded semicolon
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3635
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index cabe02cb307c..90dc72e98eb2 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -7428,7 +7428,7 @@ static bool is_content_protection_different(struct drm_crtc_state *new_crtc_stat
> new_conn_state->content_protection = DRM_MODE_CONTENT_PROTECTION_DESIRED;
> pr_debug("[HDCP_DM] ENABLED->DESIRED & mode_changed %s :true\n", __func__);
> return true;
> - };
> + }
> new_conn_state->content_protection = DRM_MODE_CONTENT_PROTECTION_ENABLED;
> pr_debug("[HDCP_DM] ENABLED -> DESIRED %s :false\n", __func__);
> return false;
> @@ -7482,11 +7482,11 @@ static bool is_content_protection_different(struct drm_crtc_state *new_crtc_stat
> pr_debug("[HDCP_DM] DESIRED->DESIRED or ENABLE->ENABLE mode_change %s :true\n",
> __func__);
> return true;
> - };
> + }
> pr_debug("[HDCP_DM] DESIRED->DESIRED & ENABLE->ENABLE %s :false\n",
> __func__);
> return false;
> - };
> + }
>
> pr_debug("[HDCP_DM] UNDESIRED->UNDESIRED %s :false\n", __func__);
> return false;
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH -next] drm/amd/display: Remove unneeded semicolon
@ 2023-10-18 1:16 Yang Li
2023-10-18 13:59 ` Alex Deucher
0 siblings, 1 reply; 9+ messages in thread
From: Yang Li @ 2023-10-18 1:16 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, airlied, daniel
Cc: Abaci Robot, Yang Li, dri-devel, amd-gfx, linux-kernel
./drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c:464:3-4: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6900
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
index 36baf35bb170..f45fbe820445 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
@@ -461,7 +461,7 @@ static void sort_pipes_for_splitting(struct dc_plane_pipe_pool *pipes)
swapped = false;
}
- };
+ }
}
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amd/display: Remove unneeded semicolon
2023-10-18 1:16 Yang Li
@ 2023-10-18 13:59 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2023-10-18 13:59 UTC (permalink / raw)
To: Yang Li; +Cc: Abaci Robot, linux-kernel, dri-devel, amd-gfx, alexander.deucher
Applied. Thanks!
On Tue, Oct 17, 2023 at 9:16 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> ./drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c:464:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6900
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
> index 36baf35bb170..f45fbe820445 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_dc_resource_mgmt.c
> @@ -461,7 +461,7 @@ static void sort_pipes_for_splitting(struct dc_plane_pipe_pool *pipes)
> swapped = false;
> }
>
> - };
> + }
> }
> }
>
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH -next] drm/amd/display: remove unneeded semicolon
@ 2022-08-18 2:59 Yang Li
2022-08-19 15:51 ` Alex Deucher
0 siblings, 1 reply; 9+ messages in thread
From: Yang Li @ 2022-08-18 2:59 UTC (permalink / raw)
To: airlied
Cc: sunpeng.li, Abaci Robot, Xinhui.Pan, Rodrigo.Siqueira,
linux-kernel, amd-gfx, Yang Li, dri-devel, alexander.deucher,
christian.koenig
Semicolon is not required after curly braces.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1918
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c
index beb025cd3dc2..1995e1d708d9 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c
@@ -614,7 +614,7 @@ static void dcn314_clk_mgr_helper_populate_bw_params(struct clk_mgr_internal *cl
bw_params->clk_table.entries[i].dppclk_mhz = max_dppclk;
bw_params->clk_table.entries[i].wck_ratio = convert_wck_ratio(
clock_table->DfPstateTable[min_pstate].WckRatio);
- };
+ }
/* Make sure to include at least one entry at highest pstate */
if (max_pstate != min_pstate || i == 0) {
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH -next] drm/amd/display: remove unneeded semicolon
2022-08-18 2:59 [PATCH -next] drm/amd/display: remove " Yang Li
@ 2022-08-19 15:51 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2022-08-19 15:51 UTC (permalink / raw)
To: Yang Li
Cc: airlied, Abaci Robot, Xinhui.Pan, Rodrigo.Siqueira, linux-kernel,
amd-gfx, sunpeng.li, dri-devel, alexander.deucher,
christian.koenig
Applied. Thanks!
On Wed, Aug 17, 2022 at 10:59 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Semicolon is not required after curly braces.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1918
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c
> index beb025cd3dc2..1995e1d708d9 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c
> @@ -614,7 +614,7 @@ static void dcn314_clk_mgr_helper_populate_bw_params(struct clk_mgr_internal *cl
> bw_params->clk_table.entries[i].dppclk_mhz = max_dppclk;
> bw_params->clk_table.entries[i].wck_ratio = convert_wck_ratio(
> clock_table->DfPstateTable[min_pstate].WckRatio);
> - };
> + }
>
> /* Make sure to include at least one entry at highest pstate */
> if (max_pstate != min_pstate || i == 0) {
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH -next] drm/amd/display: remove unneeded semicolon
@ 2022-07-26 22:28 Yang Li
2022-07-27 15:54 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 9+ messages in thread
From: Yang Li @ 2022-07-26 22:28 UTC (permalink / raw)
To: airlied
Cc: sunpeng.li, Abaci Robot, Xinhui.Pan, Rodrigo.Siqueira,
linux-kernel, amd-gfx, Yang Li, dri-devel, alexander.deucher,
christian.koenig
Eliminate the following coccicheck warning:
./drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c:2344:67-68: Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
index 39428488a052..ca44df4fca74 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
@@ -2341,7 +2341,7 @@ void dcn201_populate_dml_writeback_from_context_fpu(struct dc *dc,
dout_wb.wb_dst_width = wb_info->dwb_params.dest_width;
dout_wb.wb_dst_height = wb_info->dwb_params.dest_height;
dout_wb.wb_htaps_luma = wb_info->dwb_params.scaler_taps.h_taps;
- dout_wb.wb_vtaps_luma = wb_info->dwb_params.scaler_taps.v_taps;;
+ dout_wb.wb_vtaps_luma = wb_info->dwb_params.scaler_taps.v_taps;
dout_wb.wb_htaps_chroma = wb_info->dwb_params.scaler_taps.h_taps_c;
dout_wb.wb_vtaps_chroma = wb_info->dwb_params.scaler_taps.v_taps_c;
dout_wb.wb_hratio = wb_info->dwb_params.cnv_params.crop_en ?
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove unneeded semicolon
2022-07-26 22:28 Yang Li
@ 2022-07-27 15:54 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 9+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-07-27 15:54 UTC (permalink / raw)
To: Yang Li, airlied
Cc: sunpeng.li, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, alexander.deucher, christian.koenig
On 2022-07-26 18:28, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c:2344:67-68: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
> index 39428488a052..ca44df4fca74 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
> @@ -2341,7 +2341,7 @@ void dcn201_populate_dml_writeback_from_context_fpu(struct dc *dc,
> dout_wb.wb_dst_width = wb_info->dwb_params.dest_width;
> dout_wb.wb_dst_height = wb_info->dwb_params.dest_height;
> dout_wb.wb_htaps_luma = wb_info->dwb_params.scaler_taps.h_taps;
> - dout_wb.wb_vtaps_luma = wb_info->dwb_params.scaler_taps.v_taps;;
> + dout_wb.wb_vtaps_luma = wb_info->dwb_params.scaler_taps.v_taps;
> dout_wb.wb_htaps_chroma = wb_info->dwb_params.scaler_taps.h_taps_c;
> dout_wb.wb_vtaps_chroma = wb_info->dwb_params.scaler_taps.v_taps_c;
> dout_wb.wb_hratio = wb_info->dwb_params.cnv_params.crop_en ?
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
And applied to amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH -next] drm/amd/display: remove unneeded semicolon
@ 2022-04-07 23:27 Yang Li
0 siblings, 0 replies; 9+ messages in thread
From: Yang Li @ 2022-04-07 23:27 UTC (permalink / raw)
To: airlied
Cc: sunpeng.li, Abaci Robot, Xinhui.Pan, Rodrigo.Siqueira,
linux-kernel, amd-gfx, Yang Li, dri-devel, alexander.deucher,
christian.koenig
Eliminate the following coccicheck warning:
./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:477:2-3:
Unneeded semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c
index 8be4c1970628..707dce6486b9 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c
@@ -474,7 +474,7 @@ static void dcn315_clk_mgr_helper_populate_bw_params(
bw_params->clk_table.entries[i].dispclk_mhz = max_dispclk;
bw_params->clk_table.entries[i].dppclk_mhz = max_dppclk;
bw_params->clk_table.entries[i].wck_ratio = 1;
- };
+ }
/* Make sure to include at least one entry and highest pstate */
if (max_pstate != min_pstate) {
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-10-18 13:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 0:24 [PATCH -next] drm/amd/display: Remove unneeded semicolon Yang Li
2023-01-06 15:29 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2023-10-18 1:16 Yang Li
2023-10-18 13:59 ` Alex Deucher
2022-08-18 2:59 [PATCH -next] drm/amd/display: remove " Yang Li
2022-08-19 15:51 ` Alex Deucher
2022-07-26 22:28 Yang Li
2022-07-27 15:54 ` Rodrigo Siqueira Jordao
2022-04-07 23:27 Yang Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).