From: Gerd Hoffmann <kraxel@redhat.com>
To: Rob Clark <robdclark@gmail.com>
Cc: Rob Clark <robdclark@chromium.org>,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Gurchetan Singh <gurchetansingh@chromium.org>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Ryan Neph <ryanneph@chromium.org>,
David Airlie <airlied@redhat.com>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3] drm/virtio: Add option to disable KMS support
Date: Tue, 28 Feb 2023 13:46:20 +0100 [thread overview]
Message-ID: <20230228124620.pfjvj372rifiljew@sirius.home.kraxel.org> (raw)
In-Reply-To: <20230227173800.2809727-1-robdclark@gmail.com>
Hi,
> + if (!vgdev->num_scanouts) {
> + /*
> + * Having an EDID but no scanouts is non-sensical,
> + * but it is permitted to have no scanouts and no
> + * EDID (in which case DRIVER_MODESET and
> + * DRIVER_ATOMIC are not advertised)
> + */
> + if (vgdev->has_edid) {
> + DRM_ERROR("num_scanouts is zero\n");
That error message isn't very clear.
Also I'd suggest to just drop the edid check. It's about commands
being supported by the device, not about the actual presence of an EDID
blob, so the check doesn't look very useful to me.
take care,
Gerd
prev parent reply other threads:[~2023-02-28 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 17:38 [PATCH v3] drm/virtio: Add option to disable KMS support Rob Clark
2023-02-27 17:57 ` Dmitry Osipenko
2023-02-27 18:15 ` Rob Clark
2023-02-28 12:34 ` Thomas Zimmermann
2023-02-28 12:47 ` Thomas Zimmermann
2023-02-28 15:43 ` Rob Clark
2023-02-27 18:44 ` Dmitry Osipenko
2023-02-28 12:46 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228124620.pfjvj372rifiljew@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=ryanneph@chromium.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).