From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>,
Ryan Neph <ryanneph@chromium.org>,
open list <linux-kernel@vger.kernel.org>,
Gurchetan Singh <gurchetansingh@chromium.org>,
Gerd Hoffmann <kraxel@redhat.com>,
David Airlie <airlied@redhat.com>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3] drm/virtio: Add option to disable KMS support
Date: Mon, 27 Feb 2023 21:44:30 +0300 [thread overview]
Message-ID: <8499dacf-bd0d-7cee-aa98-a88fdf84de9e@collabora.com> (raw)
In-Reply-To: <20230227173800.2809727-1-robdclark@gmail.com>
On 2/27/23 20:38, Rob Clark wrote:
> static const struct drm_driver driver = {
> - .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_RENDER | DRIVER_ATOMIC,
> + .driver_features =
> +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS)
I'd also replace the `#if defined()` with `#if IS_ENABLED()`, for
consistency.
Maybe won't hurt to expand the commit message a tad, emphasizing the
security aspect and telling about the new num_scanouts=0 behaviour.
I can change it all while applying, if Gerd is okay with this patch.
Othwerise, good to me:
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
--
Best regards,
Dmitry
next prev parent reply other threads:[~2023-02-27 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 17:38 [PATCH v3] drm/virtio: Add option to disable KMS support Rob Clark
2023-02-27 17:57 ` Dmitry Osipenko
2023-02-27 18:15 ` Rob Clark
2023-02-28 12:34 ` Thomas Zimmermann
2023-02-28 12:47 ` Thomas Zimmermann
2023-02-28 15:43 ` Rob Clark
2023-02-27 18:44 ` Dmitry Osipenko [this message]
2023-02-28 12:46 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8499dacf-bd0d-7cee-aa98-a88fdf84de9e@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=ryanneph@chromium.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).