* [PATCH v3 0/2] arm64: dts: qcom: add DP Controller to SM8550 DTS
@ 2023-06-12 15:26 Neil Armstrong
2023-06-12 15:26 ` [PATCH v3 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels Neil Armstrong
2023-06-12 15:26 ` [PATCH v3 2/2] arm64: dts: qcom: sm8550: add display port nodes Neil Armstrong
0 siblings, 2 replies; 5+ messages in thread
From: Neil Armstrong @ 2023-06-12 15:26 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Kuogee Hsieh, Andy Gross,
Bjorn Andersson, Konrad Dybcio
Cc: Neil Armstrong, devicetree, linux-arm-msm, linux-kernel,
dri-devel, freedreno
The DP output is shared with the USB3 SuperSpeed lanes and is
usually connected to an USB-C port which Altmode is controlled
by the PMIC Glink infrastructure.
DT changes tying the DP controller to the USB-C port on the QRD
board will be sent later.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v3:
- Rebased on next-20230609
- Dropped applied bindings
- Link to v2: https://lore.kernel.org/r/20230601-topic-sm8550-upstream-dp-v2-0-e8778109c757@linaro.org
Changes in v2:
- Added review tags
- s/lov_svs/low_svs/
- Applied fixes suggested from Konrad
- Link to v1: https://lore.kernel.org/r/20230601-topic-sm8550-upstream-dp-v1-0-29efe2689553@linaro.org
---
Neil Armstrong (2):
arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels
arm64: dts: qcom: sm8550: add display port nodes
arch/arm64/boot/dts/qcom/sm8550.dtsi | 95 ++++++++++++++++++++++++++++++++++--
1 file changed, 90 insertions(+), 5 deletions(-)
---
base-commit: 53ab6975c12d1ad86c599a8927e8c698b144d669
change-id: 20230601-topic-sm8550-upstream-dp-b713ba275d7c
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels
2023-06-12 15:26 [PATCH v3 0/2] arm64: dts: qcom: add DP Controller to SM8550 DTS Neil Armstrong
@ 2023-06-12 15:26 ` Neil Armstrong
2023-06-12 16:50 ` Konrad Dybcio
2023-06-12 15:26 ` [PATCH v3 2/2] arm64: dts: qcom: sm8550: add display port nodes Neil Armstrong
1 sibling, 1 reply; 5+ messages in thread
From: Neil Armstrong @ 2023-06-12 15:26 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Kuogee Hsieh, Andy Gross,
Bjorn Andersson, Konrad Dybcio
Cc: Neil Armstrong, devicetree, linux-arm-msm, linux-kernel,
dri-devel, freedreno
"low" was written "lov", fix this.
Fixes: 99d33ee61cb0 ("arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 75cd374943eb..972df1ef86ee 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -3649,15 +3649,15 @@ rpmhpd_opp_min_svs: opp-48 {
opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
};
- rpmhpd_opp_lov_svs_d2: opp-52 {
+ rpmhpd_opp_low_svs_d2: opp-52 {
opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D2>;
};
- rpmhpd_opp_lov_svs_d1: opp-56 {
+ rpmhpd_opp_low_svs_d1: opp-56 {
opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>;
};
- rpmhpd_opp_lov_svs_d0: opp-60 {
+ rpmhpd_opp_low_svs_d0: opp-60 {
opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D0>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] arm64: dts: qcom: sm8550: add display port nodes
2023-06-12 15:26 [PATCH v3 0/2] arm64: dts: qcom: add DP Controller to SM8550 DTS Neil Armstrong
2023-06-12 15:26 ` [PATCH v3 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels Neil Armstrong
@ 2023-06-12 15:26 ` Neil Armstrong
1 sibling, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2023-06-12 15:26 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Kuogee Hsieh, Andy Gross,
Bjorn Andersson, Konrad Dybcio
Cc: Neil Armstrong, devicetree, linux-arm-msm, linux-kernel,
dri-devel, freedreno
Add the Display Port controller subnode to the MDSS node.
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 89 +++++++++++++++++++++++++++++++++++-
1 file changed, 87 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 972df1ef86ee..b41b3981b3ce 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -2495,6 +2495,13 @@ dpu_intf2_out: endpoint {
remote-endpoint = <&mdss_dsi1_in>;
};
};
+
+ port@2 {
+ reg = <2>;
+ dpu_intf0_out: endpoint {
+ remote-endpoint = <&mdss_dp0_in>;
+ };
+ };
};
mdp_opp_table: opp-table {
@@ -2522,6 +2529,84 @@ opp-514000000 {
};
};
+ mdss_dp0: displayport-controller@ae90000 {
+ compatible = "qcom,sm8550-dp", "qcom,sm8350-dp";
+ reg = <0 0xae90000 0 0x200>,
+ <0 0xae90200 0 0x200>,
+ <0 0xae90400 0 0xc00>,
+ <0 0xae91000 0 0x400>,
+ <0 0xae91400 0 0x400>;
+ interrupt-parent = <&mdss>;
+ interrupts = <12>;
+ clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc DISP_CC_MDSS_DPTX0_LINK_CLK>,
+ <&dispcc DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
+ <&dispcc DISP_CC_MDSS_DPTX0_PIXEL0_CLK>;
+ clock-names = "core_iface",
+ "core_aux",
+ "ctrl_link",
+ "ctrl_link_iface",
+ "stream_pixel";
+
+ assigned-clocks = <&dispcc DISP_CC_MDSS_DPTX0_LINK_CLK_SRC>,
+ <&dispcc DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>;
+ assigned-clock-parents = <&usb_dp_qmpphy QMP_USB43DP_DP_LINK_CLK>,
+ <&usb_dp_qmpphy QMP_USB43DP_DP_VCO_DIV_CLK>;
+
+ phys = <&usb_dp_qmpphy QMP_USB43DP_DP_PHY>;
+ phy-names = "dp";
+
+ #sound-dai-cells = <0>;
+
+ operating-points-v2 = <&dp_opp_table>;
+ power-domains = <&rpmhpd SM8550_MMCX>;
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ mdss_dp0_in: endpoint {
+ remote-endpoint = <&dpu_intf0_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ mdss_dp0_out: endpoint {
+ };
+ };
+ };
+
+ dp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-162000000 {
+ opp-hz = /bits/ 64 <162000000>;
+ required-opps = <&rpmhpd_opp_low_svs_d1>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+
mdss_dsi0: dsi@ae94000 {
compatible = "qcom,sm8550-dsi-ctrl", "qcom,mdss-dsi-ctrl";
reg = <0 0x0ae94000 0 0x400>;
@@ -2705,8 +2790,8 @@ dispcc: clock-controller@af00000 {
<&mdss_dsi0_phy 1>,
<&mdss_dsi1_phy 0>,
<&mdss_dsi1_phy 1>,
- <0>, /* dp0 */
- <0>,
+ <&usb_dp_qmpphy QMP_USB43DP_DP_LINK_CLK>,
+ <&usb_dp_qmpphy QMP_USB43DP_DP_VCO_DIV_CLK>,
<0>, /* dp1 */
<0>,
<0>, /* dp2 */
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels
2023-06-12 15:26 ` [PATCH v3 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels Neil Armstrong
@ 2023-06-12 16:50 ` Konrad Dybcio
2023-06-13 7:29 ` Neil Armstrong
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2023-06-12 16:50 UTC (permalink / raw)
To: Neil Armstrong, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, Marijn Suijten, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kuogee Hsieh,
Andy Gross, Bjorn Andersson
Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel, devicetree
On 12.06.2023 17:26, Neil Armstrong wrote:
> "low" was written "lov", fix this.
>
> Fixes: 99d33ee61cb0 ("arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
https://lore.kernel.org/linux-arm-msm/1d3c05f5-c1bd-6844-1788-8df0b863a02e@linaro.org/
somebody forgot to run `b4 trailers -u` :P
Konrad
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 75cd374943eb..972df1ef86ee 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -3649,15 +3649,15 @@ rpmhpd_opp_min_svs: opp-48 {
> opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
> };
>
> - rpmhpd_opp_lov_svs_d2: opp-52 {
> + rpmhpd_opp_low_svs_d2: opp-52 {
> opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D2>;
> };
>
> - rpmhpd_opp_lov_svs_d1: opp-56 {
> + rpmhpd_opp_low_svs_d1: opp-56 {
> opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>;
> };
>
> - rpmhpd_opp_lov_svs_d0: opp-60 {
> + rpmhpd_opp_low_svs_d0: opp-60 {
> opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D0>;
> };
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels
2023-06-12 16:50 ` Konrad Dybcio
@ 2023-06-13 7:29 ` Neil Armstrong
0 siblings, 0 replies; 5+ messages in thread
From: Neil Armstrong @ 2023-06-13 7:29 UTC (permalink / raw)
To: Konrad Dybcio, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, Marijn Suijten, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Kuogee Hsieh,
Andy Gross, Bjorn Andersson
Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel, devicetree
On 12/06/2023 18:50, Konrad Dybcio wrote:
>
>
> On 12.06.2023 17:26, Neil Armstrong wrote:
>> "low" was written "lov", fix this.
>>
>> Fixes: 99d33ee61cb0 ("arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels")
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
> https://lore.kernel.org/linux-arm-msm/1d3c05f5-c1bd-6844-1788-8df0b863a02e@linaro.org/
>
> somebody forgot to run `b4 trailers -u` :P
Damn, resending a v4 now :-)
Thanks,
Neil
>
> Konrad
>> arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> index 75cd374943eb..972df1ef86ee 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> @@ -3649,15 +3649,15 @@ rpmhpd_opp_min_svs: opp-48 {
>> opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
>> };
>>
>> - rpmhpd_opp_lov_svs_d2: opp-52 {
>> + rpmhpd_opp_low_svs_d2: opp-52 {
>> opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D2>;
>> };
>>
>> - rpmhpd_opp_lov_svs_d1: opp-56 {
>> + rpmhpd_opp_low_svs_d1: opp-56 {
>> opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>;
>> };
>>
>> - rpmhpd_opp_lov_svs_d0: opp-60 {
>> + rpmhpd_opp_low_svs_d0: opp-60 {
>> opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D0>;
>> };
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-13 7:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 15:26 [PATCH v3 0/2] arm64: dts: qcom: add DP Controller to SM8550 DTS Neil Armstrong
2023-06-12 15:26 ` [PATCH v3 1/2] arm64: dts: qcom: sm8550: fix low_svs RPMhPD labels Neil Armstrong
2023-06-12 16:50 ` Konrad Dybcio
2023-06-13 7:29 ` Neil Armstrong
2023-06-12 15:26 ` [PATCH v3 2/2] arm64: dts: qcom: sm8550: add display port nodes Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).