dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: tc358764: Fix debug print parameter order
@ 2023-06-15 15:28 Marek Vasut
  2023-06-16 12:04 ` rfoss
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2023-06-15 15:28 UTC (permalink / raw)
  To: dri-devel
  Cc: Marek Vasut, Neil Armstrong, Robert Foss, Andrzej Hajda,
	Jonas Karlman, Jernej Skrabec, Laurent Pinchart

The debug print parameters were swapped in the output and they were
printed as decimal values, both the hardware address and the value.
Update the debug print to print the parameters in correct order, and
use hexadecimal print for both address and value.

Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: David Airlie <airlied@gmail.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/bridge/tc358764.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c
index f85654f1b1045..8e938a7480f37 100644
--- a/drivers/gpu/drm/bridge/tc358764.c
+++ b/drivers/gpu/drm/bridge/tc358764.c
@@ -176,7 +176,7 @@ static void tc358764_read(struct tc358764 *ctx, u16 addr, u32 *val)
 	if (ret >= 0)
 		le32_to_cpus(val);
 
-	dev_dbg(ctx->dev, "read: %d, addr: %d\n", addr, *val);
+	dev_dbg(ctx->dev, "read: addr=0x%04x data=0x%08x\n", addr, *val);
 }
 
 static void tc358764_write(struct tc358764 *ctx, u16 addr, u32 val)
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/bridge: tc358764: Fix debug print parameter order
  2023-06-15 15:28 [PATCH] drm/bridge: tc358764: Fix debug print parameter order Marek Vasut
@ 2023-06-16 12:04 ` rfoss
  0 siblings, 0 replies; 2+ messages in thread
From: rfoss @ 2023-06-16 12:04 UTC (permalink / raw)
  To: Marek Vasut, dri-devel
  Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
	Laurent Pinchart, Andrzej Hajda

From: Robert Foss <rfoss@kernel.org>

On Thu, 15 Jun 2023 17:28:17 +0200, Marek Vasut wrote:
> The debug print parameters were swapped in the output and they were
> printed as decimal values, both the hardware address and the value.
> Update the debug print to print the parameters in correct order, and
> use hexadecimal print for both address and value.
> 
> 

Reviewed-by: Robert Foss <rfoss@kernel.org>

Applied, thanks!

[1/1] drm/bridge: tc358764: Fix debug print parameter order
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=7f947be02aab



Rob


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-16 12:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-15 15:28 [PATCH] drm/bridge: tc358764: Fix debug print parameter order Marek Vasut
2023-06-16 12:04 ` rfoss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).