dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i2c: Switch i2c drivers back to use .probe()
@ 2023-06-11 20:27 Uwe Kleine-König
  2023-06-11 21:17 ` Javier Martinez Canillas
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2023-06-11 20:27 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter; +Cc: kernel, Javier Martinez Canillas, dri-devel

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/gpu/drm/i2c/ch7006_drv.c | 2 +-
 drivers/gpu/drm/i2c/sil164_drv.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
index 521bdf656cca..131512a5f3bd 100644
--- a/drivers/gpu/drm/i2c/ch7006_drv.c
+++ b/drivers/gpu/drm/i2c/ch7006_drv.c
@@ -497,7 +497,7 @@ static const struct dev_pm_ops ch7006_pm_ops = {
 
 static struct drm_i2c_encoder_driver ch7006_driver = {
 	.i2c_driver = {
-		.probe_new = ch7006_probe,
+		.probe = ch7006_probe,
 		.remove = ch7006_remove,
 
 		.driver = {
diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c
index f57f9a807542..ff23422727fc 100644
--- a/drivers/gpu/drm/i2c/sil164_drv.c
+++ b/drivers/gpu/drm/i2c/sil164_drv.c
@@ -420,7 +420,7 @@ MODULE_DEVICE_TABLE(i2c, sil164_ids);
 
 static struct drm_i2c_encoder_driver sil164_driver = {
 	.i2c_driver = {
-		.probe_new = sil164_probe,
+		.probe = sil164_probe,
 		.driver = {
 			.name = "sil164",
 		},

base-commit: 53ab6975c12d1ad86c599a8927e8c698b144d669
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i2c: Switch i2c drivers back to use .probe()
  2023-06-11 20:27 [PATCH] drm/i2c: Switch i2c drivers back to use .probe() Uwe Kleine-König
@ 2023-06-11 21:17 ` Javier Martinez Canillas
  2023-06-11 23:37 ` Andi Shyti
  2023-06-16  5:58 ` Uwe Kleine-König
  2 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2023-06-11 21:17 UTC (permalink / raw)
  To: Uwe Kleine-König, David Airlie, Daniel Vetter; +Cc: kernel, dri-devel

Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:

Hello Uwe,

> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i2c: Switch i2c drivers back to use .probe()
  2023-06-11 20:27 [PATCH] drm/i2c: Switch i2c drivers back to use .probe() Uwe Kleine-König
  2023-06-11 21:17 ` Javier Martinez Canillas
@ 2023-06-11 23:37 ` Andi Shyti
  2023-06-16  5:58 ` Uwe Kleine-König
  2 siblings, 0 replies; 5+ messages in thread
From: Andi Shyti @ 2023-06-11 23:37 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: dri-devel, kernel, Javier Martinez Canillas

Hi Uwe,

On Sun, Jun 11, 2023 at 10:27:40PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Andi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i2c: Switch i2c drivers back to use .probe()
  2023-06-11 20:27 [PATCH] drm/i2c: Switch i2c drivers back to use .probe() Uwe Kleine-König
  2023-06-11 21:17 ` Javier Martinez Canillas
  2023-06-11 23:37 ` Andi Shyti
@ 2023-06-16  5:58 ` Uwe Kleine-König
  2023-06-22 10:09   ` Javier Martinez Canillas
  2 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2023-06-16  5:58 UTC (permalink / raw)
  To: David Airlie, Daniel Vetter
  Cc: Wolfram Sang, dri-devel, Javier Martinez Canillas, kernel

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Hello,

On Sun, Jun 11, 2023 at 10:27:40PM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.

It would be great if this patch made it into 6.5-rc1, as I intend to
send a patch series to Wolfram after the upcoming merge window to drop
.probe_new to go in via the i2c tree. There are a few remaining
driver instances that I will have to fix in this series, but I'm happy
about every patch that goes in via its designated tree beforehand.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i2c: Switch i2c drivers back to use .probe()
  2023-06-16  5:58 ` Uwe Kleine-König
@ 2023-06-22 10:09   ` Javier Martinez Canillas
  0 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2023-06-22 10:09 UTC (permalink / raw)
  To: Uwe Kleine-König, David Airlie, Daniel Vetter
  Cc: Wolfram Sang, dri-devel, kernel

Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:

Hello Uwe,

> Hello,
>
> On Sun, Jun 11, 2023 at 10:27:40PM +0200, Uwe Kleine-König wrote:
>> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
>> call-back type"), all drivers being converted to .probe_new() and then
>> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
>> convert back to (the new) .probe() to be able to eventually drop
>> .probe_new() from struct i2c_driver.
>
> It would be great if this patch made it into 6.5-rc1, as I intend to
> send a patch series to Wolfram after the upcoming merge window to drop
> .probe_new to go in via the i2c tree. There are a few remaining
> driver instances that I will have to fix in this series, but I'm happy
> about every patch that goes in via its designated tree beforehand.
>

Pushed to drm-misc (drm-misc-next). Thanks!

> Best regards
> Uwe
>
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-06-22 10:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-11 20:27 [PATCH] drm/i2c: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-06-11 21:17 ` Javier Martinez Canillas
2023-06-11 23:37 ` Andi Shyti
2023-06-16  5:58 ` Uwe Kleine-König
2023-06-22 10:09   ` Javier Martinez Canillas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).