* [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER
@ 2023-07-18 8:17 Raphael Gallais-Pou
2023-07-18 13:33 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Raphael Gallais-Pou @ 2023-07-18 8:17 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-fbdev, linux-staging, linux-kernel, dri-devel
Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
ultimately causes a warning when the module probes. Fixes it.
Changes in v2:
- dropped MODULE_ALIAS changes
- changed commit log for more accurate description
Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
---
drivers/staging/fbtft/fb_ili9341.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_ili9341.c b/drivers/staging/fbtft/fb_ili9341.c
index 9ccd0823c3ab..47e72b87d76d 100644
--- a/drivers/staging/fbtft/fb_ili9341.c
+++ b/drivers/staging/fbtft/fb_ili9341.c
@@ -145,7 +145,7 @@ static struct fbtft_display display = {
},
};
-FBTFT_REGISTER_DRIVER(DRVNAME, "ilitek,ili9341", &display);
+FBTFT_REGISTER_SPI_DRIVER(DRVNAME, "ilitek", "ili9341", &display);
MODULE_ALIAS("spi:" DRVNAME);
MODULE_ALIAS("platform:" DRVNAME);
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER
2023-07-18 8:17 [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER Raphael Gallais-Pou
@ 2023-07-18 13:33 ` Greg Kroah-Hartman
2023-07-18 16:55 ` Raphaël Gallais-Pou
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2023-07-18 13:33 UTC (permalink / raw)
To: Raphael Gallais-Pou; +Cc: linux-fbdev, linux-staging, linux-kernel, dri-devel
On Tue, Jul 18, 2023 at 10:17:59AM +0200, Raphael Gallais-Pou wrote:
> Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
> ultimately causes a warning when the module probes. Fixes it.
>
> Changes in v2:
> - dropped MODULE_ALIAS changes
> - changed commit log for more accurate description
>
> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
> ---
> drivers/staging/fbtft/fb_ili9341.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why is this a resend?
And the changes need to go below the --- line as per the documentation.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER
2023-07-18 13:33 ` Greg Kroah-Hartman
@ 2023-07-18 16:55 ` Raphaël Gallais-Pou
0 siblings, 0 replies; 3+ messages in thread
From: Raphaël Gallais-Pou @ 2023-07-18 16:55 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-fbdev, linux-staging, linux-kernel, dri-devel
Hi,
Le 18/07/2023 à 15:33, Greg Kroah-Hartman a écrit :
> On Tue, Jul 18, 2023 at 10:17:59AM +0200, Raphael Gallais-Pou wrote:
>> Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
>> ultimately causes a warning when the module probes. Fixes it.
>>
>> Changes in v2:
>> - dropped MODULE_ALIAS changes
>> - changed commit log for more accurate description
>>
>> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
>> ---
>> drivers/staging/fbtft/fb_ili9341.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Why is this a resend? >
> And the changes need to go below the --- line as per the documentation.
I messed up the first send and forgot the changelog.
Thanks for your insights, I understand now that I shouldn't have sent a
'RESEND', but rather a v3 with a third entry in the changelog.
Regards,
Raphaël
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-18 16:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 8:17 [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER Raphael Gallais-Pou
2023-07-18 13:33 ` Greg Kroah-Hartman
2023-07-18 16:55 ` Raphaël Gallais-Pou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).