* [PATCH] drm/amd/display: Clean up errors in ddc_regs.h
@ 2023-08-02 2:43 Ran Sun
2023-08-07 17:07 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Ran Sun @ 2023-08-02 2:43 UTC (permalink / raw)
To: alexander.deucher; +Cc: Ran Sun, dri-devel, amd-gfx, linux-kernel
Fix the following errors reported by checkpatch:
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
.../gpu/drm/amd/display/dc/gpio/ddc_regs.h | 40 +++++++++----------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/gpio/ddc_regs.h b/drivers/gpu/drm/amd/display/dc/gpio/ddc_regs.h
index 59884ef651b3..4a2bf81286d8 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/ddc_regs.h
+++ b/drivers/gpu/drm/amd/display/dc/gpio/ddc_regs.h
@@ -31,21 +31,21 @@
/****************************** new register headers */
/*** following in header */
-#define DDC_GPIO_REG_LIST_ENTRY(type,cd,id) \
+#define DDC_GPIO_REG_LIST_ENTRY(type, cd, id) \
.type ## _reg = REG(DC_GPIO_DDC ## id ## _ ## type),\
.type ## _mask = DC_GPIO_DDC ## id ## _ ## type ## __DC_GPIO_DDC ## id ## cd ## _ ## type ## _MASK,\
.type ## _shift = DC_GPIO_DDC ## id ## _ ## type ## __DC_GPIO_DDC ## id ## cd ## _ ## type ## __SHIFT
-#define DDC_GPIO_REG_LIST(cd,id) \
+#define DDC_GPIO_REG_LIST(cd, id) \
{\
- DDC_GPIO_REG_LIST_ENTRY(MASK,cd,id),\
- DDC_GPIO_REG_LIST_ENTRY(A,cd,id),\
- DDC_GPIO_REG_LIST_ENTRY(EN,cd,id),\
- DDC_GPIO_REG_LIST_ENTRY(Y,cd,id)\
+ DDC_GPIO_REG_LIST_ENTRY(MASK, cd, id),\
+ DDC_GPIO_REG_LIST_ENTRY(A, cd, id),\
+ DDC_GPIO_REG_LIST_ENTRY(EN, cd, id),\
+ DDC_GPIO_REG_LIST_ENTRY(Y, cd, id)\
}
-#define DDC_REG_LIST(cd,id) \
- DDC_GPIO_REG_LIST(cd,id),\
+#define DDC_REG_LIST(cd, id) \
+ DDC_GPIO_REG_LIST(cd, id),\
.ddc_setup = REG(DC_I2C_DDC ## id ## _SETUP)
#define DDC_REG_LIST_DCN2(cd, id) \
@@ -54,34 +54,34 @@
.phy_aux_cntl = REG(PHY_AUX_CNTL), \
.dc_gpio_aux_ctrl_5 = REG(DC_GPIO_AUX_CTRL_5)
-#define DDC_GPIO_VGA_REG_LIST_ENTRY(type,cd)\
+#define DDC_GPIO_VGA_REG_LIST_ENTRY(type, cd)\
.type ## _reg = REG(DC_GPIO_DDCVGA_ ## type),\
.type ## _mask = DC_GPIO_DDCVGA_ ## type ## __DC_GPIO_DDCVGA ## cd ## _ ## type ## _MASK,\
.type ## _shift = DC_GPIO_DDCVGA_ ## type ## __DC_GPIO_DDCVGA ## cd ## _ ## type ## __SHIFT
#define DDC_GPIO_VGA_REG_LIST(cd) \
{\
- DDC_GPIO_VGA_REG_LIST_ENTRY(MASK,cd),\
- DDC_GPIO_VGA_REG_LIST_ENTRY(A,cd),\
- DDC_GPIO_VGA_REG_LIST_ENTRY(EN,cd),\
- DDC_GPIO_VGA_REG_LIST_ENTRY(Y,cd)\
+ DDC_GPIO_VGA_REG_LIST_ENTRY(MASK, cd),\
+ DDC_GPIO_VGA_REG_LIST_ENTRY(A, cd),\
+ DDC_GPIO_VGA_REG_LIST_ENTRY(EN, cd),\
+ DDC_GPIO_VGA_REG_LIST_ENTRY(Y, cd)\
}
#define DDC_VGA_REG_LIST(cd) \
DDC_GPIO_VGA_REG_LIST(cd),\
.ddc_setup = mmDC_I2C_DDCVGA_SETUP
-#define DDC_GPIO_I2C_REG_LIST_ENTRY(type,cd) \
+#define DDC_GPIO_I2C_REG_LIST_ENTRY(type, cd) \
.type ## _reg = REG(DC_GPIO_I2CPAD_ ## type),\
.type ## _mask = DC_GPIO_I2CPAD_ ## type ## __DC_GPIO_ ## cd ## _ ## type ## _MASK,\
.type ## _shift = DC_GPIO_I2CPAD_ ## type ## __DC_GPIO_ ## cd ## _ ## type ## __SHIFT
#define DDC_GPIO_I2C_REG_LIST(cd) \
{\
- DDC_GPIO_I2C_REG_LIST_ENTRY(MASK,cd),\
- DDC_GPIO_I2C_REG_LIST_ENTRY(A,cd),\
- DDC_GPIO_I2C_REG_LIST_ENTRY(EN,cd),\
- DDC_GPIO_I2C_REG_LIST_ENTRY(Y,cd)\
+ DDC_GPIO_I2C_REG_LIST_ENTRY(MASK, cd),\
+ DDC_GPIO_I2C_REG_LIST_ENTRY(A, cd),\
+ DDC_GPIO_I2C_REG_LIST_ENTRY(EN, cd),\
+ DDC_GPIO_I2C_REG_LIST_ENTRY(Y, cd)\
}
#define DDC_I2C_REG_LIST(cd) \
@@ -150,12 +150,12 @@ struct ddc_sh_mask {
#define ddc_data_regs(id) \
{\
- DDC_REG_LIST(DATA,id)\
+ DDC_REG_LIST(DATA, id)\
}
#define ddc_clk_regs(id) \
{\
- DDC_REG_LIST(CLK,id)\
+ DDC_REG_LIST(CLK, id)\
}
#define ddc_vga_data_regs \
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Clean up errors in ddc_regs.h
2023-08-02 2:43 [PATCH] drm/amd/display: Clean up errors in ddc_regs.h Ran Sun
@ 2023-08-07 17:07 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2023-08-07 17:07 UTC (permalink / raw)
To: Ran Sun; +Cc: alexander.deucher, amd-gfx, dri-devel, linux-kernel
Applied. Thanks!
On Tue, Aug 1, 2023 at 10:44 PM Ran Sun <sunran001@208suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> .../gpu/drm/amd/display/dc/gpio/ddc_regs.h | 40 +++++++++----------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/gpio/ddc_regs.h b/drivers/gpu/drm/amd/display/dc/gpio/ddc_regs.h
> index 59884ef651b3..4a2bf81286d8 100644
> --- a/drivers/gpu/drm/amd/display/dc/gpio/ddc_regs.h
> +++ b/drivers/gpu/drm/amd/display/dc/gpio/ddc_regs.h
> @@ -31,21 +31,21 @@
> /****************************** new register headers */
> /*** following in header */
>
> -#define DDC_GPIO_REG_LIST_ENTRY(type,cd,id) \
> +#define DDC_GPIO_REG_LIST_ENTRY(type, cd, id) \
> .type ## _reg = REG(DC_GPIO_DDC ## id ## _ ## type),\
> .type ## _mask = DC_GPIO_DDC ## id ## _ ## type ## __DC_GPIO_DDC ## id ## cd ## _ ## type ## _MASK,\
> .type ## _shift = DC_GPIO_DDC ## id ## _ ## type ## __DC_GPIO_DDC ## id ## cd ## _ ## type ## __SHIFT
>
> -#define DDC_GPIO_REG_LIST(cd,id) \
> +#define DDC_GPIO_REG_LIST(cd, id) \
> {\
> - DDC_GPIO_REG_LIST_ENTRY(MASK,cd,id),\
> - DDC_GPIO_REG_LIST_ENTRY(A,cd,id),\
> - DDC_GPIO_REG_LIST_ENTRY(EN,cd,id),\
> - DDC_GPIO_REG_LIST_ENTRY(Y,cd,id)\
> + DDC_GPIO_REG_LIST_ENTRY(MASK, cd, id),\
> + DDC_GPIO_REG_LIST_ENTRY(A, cd, id),\
> + DDC_GPIO_REG_LIST_ENTRY(EN, cd, id),\
> + DDC_GPIO_REG_LIST_ENTRY(Y, cd, id)\
> }
>
> -#define DDC_REG_LIST(cd,id) \
> - DDC_GPIO_REG_LIST(cd,id),\
> +#define DDC_REG_LIST(cd, id) \
> + DDC_GPIO_REG_LIST(cd, id),\
> .ddc_setup = REG(DC_I2C_DDC ## id ## _SETUP)
>
> #define DDC_REG_LIST_DCN2(cd, id) \
> @@ -54,34 +54,34 @@
> .phy_aux_cntl = REG(PHY_AUX_CNTL), \
> .dc_gpio_aux_ctrl_5 = REG(DC_GPIO_AUX_CTRL_5)
>
> -#define DDC_GPIO_VGA_REG_LIST_ENTRY(type,cd)\
> +#define DDC_GPIO_VGA_REG_LIST_ENTRY(type, cd)\
> .type ## _reg = REG(DC_GPIO_DDCVGA_ ## type),\
> .type ## _mask = DC_GPIO_DDCVGA_ ## type ## __DC_GPIO_DDCVGA ## cd ## _ ## type ## _MASK,\
> .type ## _shift = DC_GPIO_DDCVGA_ ## type ## __DC_GPIO_DDCVGA ## cd ## _ ## type ## __SHIFT
>
> #define DDC_GPIO_VGA_REG_LIST(cd) \
> {\
> - DDC_GPIO_VGA_REG_LIST_ENTRY(MASK,cd),\
> - DDC_GPIO_VGA_REG_LIST_ENTRY(A,cd),\
> - DDC_GPIO_VGA_REG_LIST_ENTRY(EN,cd),\
> - DDC_GPIO_VGA_REG_LIST_ENTRY(Y,cd)\
> + DDC_GPIO_VGA_REG_LIST_ENTRY(MASK, cd),\
> + DDC_GPIO_VGA_REG_LIST_ENTRY(A, cd),\
> + DDC_GPIO_VGA_REG_LIST_ENTRY(EN, cd),\
> + DDC_GPIO_VGA_REG_LIST_ENTRY(Y, cd)\
> }
>
> #define DDC_VGA_REG_LIST(cd) \
> DDC_GPIO_VGA_REG_LIST(cd),\
> .ddc_setup = mmDC_I2C_DDCVGA_SETUP
>
> -#define DDC_GPIO_I2C_REG_LIST_ENTRY(type,cd) \
> +#define DDC_GPIO_I2C_REG_LIST_ENTRY(type, cd) \
> .type ## _reg = REG(DC_GPIO_I2CPAD_ ## type),\
> .type ## _mask = DC_GPIO_I2CPAD_ ## type ## __DC_GPIO_ ## cd ## _ ## type ## _MASK,\
> .type ## _shift = DC_GPIO_I2CPAD_ ## type ## __DC_GPIO_ ## cd ## _ ## type ## __SHIFT
>
> #define DDC_GPIO_I2C_REG_LIST(cd) \
> {\
> - DDC_GPIO_I2C_REG_LIST_ENTRY(MASK,cd),\
> - DDC_GPIO_I2C_REG_LIST_ENTRY(A,cd),\
> - DDC_GPIO_I2C_REG_LIST_ENTRY(EN,cd),\
> - DDC_GPIO_I2C_REG_LIST_ENTRY(Y,cd)\
> + DDC_GPIO_I2C_REG_LIST_ENTRY(MASK, cd),\
> + DDC_GPIO_I2C_REG_LIST_ENTRY(A, cd),\
> + DDC_GPIO_I2C_REG_LIST_ENTRY(EN, cd),\
> + DDC_GPIO_I2C_REG_LIST_ENTRY(Y, cd)\
> }
>
> #define DDC_I2C_REG_LIST(cd) \
> @@ -150,12 +150,12 @@ struct ddc_sh_mask {
>
> #define ddc_data_regs(id) \
> {\
> - DDC_REG_LIST(DATA,id)\
> + DDC_REG_LIST(DATA, id)\
> }
>
> #define ddc_clk_regs(id) \
> {\
> - DDC_REG_LIST(CLK,id)\
> + DDC_REG_LIST(CLK, id)\
> }
>
> #define ddc_vga_data_regs \
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-07 17:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-02 2:43 [PATCH] drm/amd/display: Clean up errors in ddc_regs.h Ran Sun
2023-08-07 17:07 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).