dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c
@ 2023-08-02  7:06 Ran Sun
  2023-08-07 17:24 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Ran Sun @ 2023-08-02  7:06 UTC (permalink / raw)
  To: alexander.deucher; +Cc: Ran Sun, dri-devel, amd-gfx, linux-kernel

Fix the following errors reported by checkpatch:

ERROR: else should follow close brace '}'
ERROR: that open brace { should be on the previous line

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
 drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
index cae1aaa4ddb6..6a68ee946f1c 100644
--- a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
+++ b/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
@@ -183,12 +183,10 @@ static int xgpu_nv_send_access_requests(struct amdgpu_device *adev,
 			if (req != IDH_REQ_GPU_INIT_DATA) {
 				pr_err("Doesn't get msg:%d from pf, error=%d\n", event, r);
 				return r;
-			}
-			else /* host doesn't support REQ_GPU_INIT_DATA handshake */
+			} else /* host doesn't support REQ_GPU_INIT_DATA handshake */
 				adev->virt.req_init_data_ver = 0;
 		} else {
-			if (req == IDH_REQ_GPU_INIT_DATA)
-			{
+			if (req == IDH_REQ_GPU_INIT_DATA) {
 				adev->virt.req_init_data_ver =
 					RREG32_NO_KIQ(mmMAILBOX_MSGBUF_RCV_DW1);
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c
  2023-08-02  7:06 [PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c Ran Sun
@ 2023-08-07 17:24 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2023-08-07 17:24 UTC (permalink / raw)
  To: Ran Sun; +Cc: alexander.deucher, amd-gfx, dri-devel, linux-kernel

Applied.  Thanks!

On Wed, Aug 2, 2023 at 3:06 AM Ran Sun <sunran001@208suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
> index cae1aaa4ddb6..6a68ee946f1c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mxgpu_nv.c
> @@ -183,12 +183,10 @@ static int xgpu_nv_send_access_requests(struct amdgpu_device *adev,
>                         if (req != IDH_REQ_GPU_INIT_DATA) {
>                                 pr_err("Doesn't get msg:%d from pf, error=%d\n", event, r);
>                                 return r;
> -                       }
> -                       else /* host doesn't support REQ_GPU_INIT_DATA handshake */
> +                       } else /* host doesn't support REQ_GPU_INIT_DATA handshake */
>                                 adev->virt.req_init_data_ver = 0;
>                 } else {
> -                       if (req == IDH_REQ_GPU_INIT_DATA)
> -                       {
> +                       if (req == IDH_REQ_GPU_INIT_DATA) {
>                                 adev->virt.req_init_data_ver =
>                                         RREG32_NO_KIQ(mmMAILBOX_MSGBUF_RCV_DW1);
>
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-07 17:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-02  7:06 [PATCH] drm/amdgpu: Clean up errors in mxgpu_nv.c Ran Sun
2023-08-07 17:24 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).