* [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs
@ 2023-10-23 14:29 Konrad Dybcio
2023-10-23 19:42 ` Rob Clark
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-10-23 14:29 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter
Cc: Rob Clark, linux-arm-msm, linux-kernel, dri-devel, Konrad Dybcio,
Marijn Suijten, Abel Vesa, freedreno
New GPUs still use the lower 2 bytes of the chip id (in whatever form
it comes) to signify silicon revision. Drop the warning that makes it
sound as if that was unintended.
Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
index 80b3f6312116..9a1ec42155fd 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
@@ -203,11 +203,6 @@ struct adreno_platform_config {
static inline uint8_t adreno_patchid(const struct adreno_gpu *gpu)
{
- /* It is probably ok to assume legacy "adreno_rev" format
- * for all a6xx devices, but probably best to limit this
- * to older things.
- */
- WARN_ON_ONCE(gpu->info->family >= ADRENO_6XX_GEN1);
return gpu->chip_id & 0xff;
}
---
base-commit: e8361b005d7c92997d12f2b85a9e4a525738bd9d
change-id: 20231023-topic-adreno_warn-42a09bb4bf64
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs
2023-10-23 14:29 [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs Konrad Dybcio
@ 2023-10-23 19:42 ` Rob Clark
2023-10-23 19:56 ` Konrad Dybcio
0 siblings, 1 reply; 6+ messages in thread
From: Rob Clark @ 2023-10-23 19:42 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Rob Clark, freedreno, Sean Paul, Abhinav Kumar, dri-devel,
linux-kernel, linux-arm-msm, Dmitry Baryshkov, Marijn Suijten,
Abel Vesa
On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> New GPUs still use the lower 2 bytes of the chip id (in whatever form
> it comes) to signify silicon revision. Drop the warning that makes it
> sound as if that was unintended.
>
> Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> index 80b3f6312116..9a1ec42155fd 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> @@ -203,11 +203,6 @@ struct adreno_platform_config {
>
> static inline uint8_t adreno_patchid(const struct adreno_gpu *gpu)
> {
> - /* It is probably ok to assume legacy "adreno_rev" format
> - * for all a6xx devices, but probably best to limit this
> - * to older things.
> - */
> - WARN_ON_ONCE(gpu->info->family >= ADRENO_6XX_GEN1);
Maybe just change it to ADRENO_6XX_GEN4?
BR,
-R
> return gpu->chip_id & 0xff;
> }
>
>
> ---
> base-commit: e8361b005d7c92997d12f2b85a9e4a525738bd9d
> change-id: 20231023-topic-adreno_warn-42a09bb4bf64
>
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@linaro.org>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs
2023-10-23 19:42 ` Rob Clark
@ 2023-10-23 19:56 ` Konrad Dybcio
2023-10-23 20:20 ` Rob Clark
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-10-23 19:56 UTC (permalink / raw)
To: Rob Clark
Cc: Rob Clark, freedreno, Sean Paul, Abhinav Kumar, dri-devel,
linux-kernel, linux-arm-msm, Dmitry Baryshkov, Marijn Suijten,
Abel Vesa
On 10/23/23 21:42, Rob Clark wrote:
> On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> New GPUs still use the lower 2 bytes of the chip id (in whatever form
>> it comes) to signify silicon revision. Drop the warning that makes it
>> sound as if that was unintended.
>>
>> Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> index 80b3f6312116..9a1ec42155fd 100644
>> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>> @@ -203,11 +203,6 @@ struct adreno_platform_config {
>>
>> static inline uint8_t adreno_patchid(const struct adreno_gpu *gpu)
>> {
>> - /* It is probably ok to assume legacy "adreno_rev" format
>> - * for all a6xx devices, but probably best to limit this
>> - * to older things.
>> - */
>> - WARN_ON_ONCE(gpu->info->family >= ADRENO_6XX_GEN1);
>
> Maybe just change it to ADRENO_6XX_GEN4?
That also applies to 700
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs
2023-10-23 19:56 ` Konrad Dybcio
@ 2023-10-23 20:20 ` Rob Clark
2023-10-26 19:16 ` Konrad Dybcio
0 siblings, 1 reply; 6+ messages in thread
From: Rob Clark @ 2023-10-23 20:20 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Rob Clark, freedreno, Sean Paul, Abhinav Kumar, dri-devel,
linux-kernel, linux-arm-msm, Dmitry Baryshkov, Marijn Suijten,
Abel Vesa
On Mon, Oct 23, 2023 at 12:56 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 10/23/23 21:42, Rob Clark wrote:
> > On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> >>
> >> New GPUs still use the lower 2 bytes of the chip id (in whatever form
> >> it comes) to signify silicon revision. Drop the warning that makes it
> >> sound as if that was unintended.
> >>
> >> Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU")
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >> ---
> >> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -----
> >> 1 file changed, 5 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> >> index 80b3f6312116..9a1ec42155fd 100644
> >> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> >> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> >> @@ -203,11 +203,6 @@ struct adreno_platform_config {
> >>
> >> static inline uint8_t adreno_patchid(const struct adreno_gpu *gpu)
> >> {
> >> - /* It is probably ok to assume legacy "adreno_rev" format
> >> - * for all a6xx devices, but probably best to limit this
> >> - * to older things.
> >> - */
> >> - WARN_ON_ONCE(gpu->info->family >= ADRENO_6XX_GEN1);
> >
> > Maybe just change it to ADRENO_6XX_GEN4?
> That also applies to 700
Then the warn is warning about what it is supposed to ;-)
I guess this is coming from a6xx_gmu_fw_start()? I think we need a
different way to construct the gmu chipid, since the point of this was
to not depend on the low 8b having any particular meaning. Perhaps we
should just get the gmu chipid from the device table.
BR,
-R
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs
2023-10-23 20:20 ` Rob Clark
@ 2023-10-26 19:16 ` Konrad Dybcio
2023-12-04 11:28 ` Konrad Dybcio
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-10-26 19:16 UTC (permalink / raw)
To: Rob Clark
Cc: Rob Clark, freedreno, Sean Paul, Abhinav Kumar, dri-devel,
linux-kernel, linux-arm-msm, Dmitry Baryshkov, Marijn Suijten,
Abel Vesa
On 10/23/23 22:20, Rob Clark wrote:
> On Mon, Oct 23, 2023 at 12:56 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>>
>> On 10/23/23 21:42, Rob Clark wrote:
>>> On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>>
>>>> New GPUs still use the lower 2 bytes of the chip id (in whatever form
>>>> it comes) to signify silicon revision. Drop the warning that makes it
>>>> sound as if that was unintended.
>>>>
>>>> Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU")
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>> ---
>>>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -----
>>>> 1 file changed, 5 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>>>> index 80b3f6312116..9a1ec42155fd 100644
>>>> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>>>> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>>>> @@ -203,11 +203,6 @@ struct adreno_platform_config {
>>>>
>>>> static inline uint8_t adreno_patchid(const struct adreno_gpu *gpu)
>>>> {
>>>> - /* It is probably ok to assume legacy "adreno_rev" format
>>>> - * for all a6xx devices, but probably best to limit this
>>>> - * to older things.
>>>> - */
>>>> - WARN_ON_ONCE(gpu->info->family >= ADRENO_6XX_GEN1);
>>>
>>> Maybe just change it to ADRENO_6XX_GEN4?
>> That also applies to 700
>
> Then the warn is warning about what it is supposed to ;-)
>
> I guess this is coming from a6xx_gmu_fw_start()? I think we need a
> different way to construct the gmu chipid, since the point of this was
> to not depend on the low 8b having any particular meaning. Perhaps we
> should just get the gmu chipid from the device table.
Guess that could work as well..
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs
2023-10-26 19:16 ` Konrad Dybcio
@ 2023-12-04 11:28 ` Konrad Dybcio
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-12-04 11:28 UTC (permalink / raw)
To: Rob Clark
Cc: Rob Clark, freedreno, Sean Paul, Abhinav Kumar, dri-devel,
linux-kernel, linux-arm-msm, Dmitry Baryshkov, Marijn Suijten,
Abel Vesa
On 26.10.2023 21:16, Konrad Dybcio wrote:
>
>
> On 10/23/23 22:20, Rob Clark wrote:
>> On Mon, Oct 23, 2023 at 12:56 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>
>>>
>>>
>>> On 10/23/23 21:42, Rob Clark wrote:
>>>> On Mon, Oct 23, 2023 at 7:29 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>>>
>>>>> New GPUs still use the lower 2 bytes of the chip id (in whatever form
>>>>> it comes) to signify silicon revision. Drop the warning that makes it
>>>>> sound as if that was unintended.
>>>>>
>>>>> Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying GPU")
>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>> ---
>>>>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 -----
>>>>> 1 file changed, 5 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>>>>> index 80b3f6312116..9a1ec42155fd 100644
>>>>> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>>>>> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
>>>>> @@ -203,11 +203,6 @@ struct adreno_platform_config {
>>>>>
>>>>> static inline uint8_t adreno_patchid(const struct adreno_gpu *gpu)
>>>>> {
>>>>> - /* It is probably ok to assume legacy "adreno_rev" format
>>>>> - * for all a6xx devices, but probably best to limit this
>>>>> - * to older things.
>>>>> - */
>>>>> - WARN_ON_ONCE(gpu->info->family >= ADRENO_6XX_GEN1);
>>>>
>>>> Maybe just change it to ADRENO_6XX_GEN4?
>>> That also applies to 700
>>
>> Then the warn is warning about what it is supposed to ;-)
>>
>> I guess this is coming from a6xx_gmu_fw_start()? I think we need a
>> different way to construct the gmu chipid, since the point of this was
>> to not depend on the low 8b having any particular meaning. Perhaps we
>> should just get the gmu chipid from the device table.
> Guess that could work as well..
Well, I realized that we already sorta do this..
MAJ is always set to 7 (duh)
MIN has a lookup table that will expand with future additions
PATCHID needs to vary, and that should be CHIPID & 0xff
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-04 11:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-23 14:29 [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs Konrad Dybcio
2023-10-23 19:42 ` Rob Clark
2023-10-23 19:56 ` Konrad Dybcio
2023-10-23 20:20 ` Rob Clark
2023-10-26 19:16 ` Konrad Dybcio
2023-12-04 11:28 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).