[PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited()

[PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited()

[Andi Shyti]

Hi,

This is the second time I am resending this series in its v2. It
has been reviewd, acked, blessed, discussed, rectified, assessed,
authorized, validated, glorified, praised, demanded, approved,
and yet, I don't understand why no one is merging it.

Thanks,
Andi

v2:
pick the right patch with the following changes:
 - add more r-b's
 - add a patch 2 where the drm_dbg_ratelimited is actually used.

Nirmoy Das (2):
  drm/print: Add drm_dbg_ratelimited
  drm/i915: Ratelimit debug log in vm_fault_ttm

 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
 include/drm/drm_print.h                 | 3 +++
 2 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.43.0

[PATCH RESEND AGAIN v2 1/2] drm/print: Add drm_dbg_ratelimited

[Andi Shyti]

From: Nirmoy Das <nirmoy.das@intel.com>

Add a function for ratelimitted debug print.

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
---
 include/drm/drm_print.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index dd4883df876a..5ed26a702e3e 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -602,6 +602,9 @@ void __drm_err(const char *format, ...);
 		drm_dev_printk(drm_ ? drm_->dev : NULL, KERN_DEBUG, fmt, ## __VA_ARGS__);	\
 })
 
+#define drm_dbg_ratelimited(drm, fmt, ...) \
+	__DRM_DEFINE_DBG_RATELIMITED(DRIVER, drm, fmt, ## __VA_ARGS__)
+
 #define drm_dbg_kms_ratelimited(drm, fmt, ...) \
 	__DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__)
 
-- 
2.43.0

[PATCH RESEND AGAIN v2 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm

[Andi Shyti]

From: Nirmoy Das <nirmoy.das@intel.com>

Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause
dmesg spamming. Use ratelimit api to reduce log rate.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index 9227f8146a58..6b69ef0cdbb4 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -1101,8 +1101,9 @@ static vm_fault_t vm_fault_ttm(struct vm_fault *vmf)
 		}
 
 		if (err) {
-			drm_dbg(dev, "Unable to make resource CPU accessible(err = %pe)\n",
-				ERR_PTR(err));
+			drm_dbg_ratelimited(dev,
+					    "Unable to make resource CPU accessible(err = %pe)\n",
+					    ERR_PTR(err));
 			dma_resv_unlock(bo->base.resv);
 			ret = VM_FAULT_SIGBUS;
 			goto out_rpm;
-- 
2.43.0

Re: [PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited()

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]

Hi

Am 06.12.23 um 22:09 schrieb Andi Shyti:
> Hi,
> 
> This is the second time I am resending this series in its v2. It
> has been reviewd, acked, blessed, discussed, rectified, assessed,
> authorized, validated, glorified, praised, demanded, approved,
> and yet, I don't understand why no one is merging it.

I think it should go through the Intel tree.

Best regards
Thomas

> 
> Thanks,
> Andi
> 
> v2:
> pick the right patch with the following changes:
>   - add more r-b's
>   - add a patch 2 where the drm_dbg_ratelimited is actually used.
> 
> Nirmoy Das (2):
>    drm/print: Add drm_dbg_ratelimited
>    drm/i915: Ratelimit debug log in vm_fault_ttm
> 
>   drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 5 +++--
>   include/drm/drm_print.h                 | 3 +++
>   2 files changed, 6 insertions(+), 2 deletions(-)
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited()

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

On Wed, Dec 06, 2023 at 10:09:46PM +0100, Andi Shyti wrote:
> This is the second time I am resending this series in its v2. It
> has been reviewd, acked, blessed, discussed, rectified, assessed,
> authorized, validated, glorified, praised, demanded, approved,
> and yet, I don't understand why no one is merging it.

$ ./scripts/get_maintainer.pl -f drivers/gpu/drm/i915/
Jani Nikula <jani.nikula@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
Joonas Lahtinen <joonas.lahtinen@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
Rodrigo Vivi <rodrigo.vivi@intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
Daniel Vetter <daniel@ffwll.ch> (maintainer:DRM DRIVERS)
intel-gfx@lists.freedesktop.org (open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS)
linux-kernel@vger.kernel.org (open list)

You've Cc'd none of the i915 maintainers, that's why it's been stuck.

Jani, Joonas, Rodrigo, Tvrtko, could you have a look at this?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited()

[Andi Shyti]

Hi Thomas and Maxime,

thanks for the answer,

On Thu, Dec 07, 2023 at 10:10:55AM +0100, Maxime Ripard wrote:
> On Wed, Dec 06, 2023 at 10:09:46PM +0100, Andi Shyti wrote:
> > This is the second time I am resending this series in its v2. It
> > has been reviewd, acked, blessed, discussed, rectified, assessed,
> > authorized, validated, glorified, praised, demanded, approved,
> > and yet, I don't understand why no one is merging it.
> 
> $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/i915/
> Jani Nikula <jani.nikula@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> Joonas Lahtinen <joonas.lahtinen@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> Rodrigo Vivi <rodrigo.vivi@intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
> Daniel Vetter <daniel@ffwll.ch> (maintainer:DRM DRIVERS)
> intel-gfx@lists.freedesktop.org (open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS)
> linux-kernel@vger.kernel.org (open list)
> 
> You've Cc'd none of the i915 maintainers, that's why it's been stuck.
> 
> Jani, Joonas, Rodrigo, Tvrtko, could you have a look at this?

The main change here is in drm_print.h, though and there is just
an example of usage in i915. I though this should go through the
drm branch.

Is it OK if I push it in drm-intel-next?

Thanks,
Andi

Re: [PATCH RESEND AGAIN v2 0/2] Add drm_dbg_ratelimited()

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1792 bytes --]

On Thu, Dec 07, 2023 at 10:23:08AM +0100, Andi Shyti wrote:
> Hi Thomas and Maxime,
> 
> thanks for the answer,
> 
> On Thu, Dec 07, 2023 at 10:10:55AM +0100, Maxime Ripard wrote:
> > On Wed, Dec 06, 2023 at 10:09:46PM +0100, Andi Shyti wrote:
> > > This is the second time I am resending this series in its v2. It
> > > has been reviewd, acked, blessed, discussed, rectified, assessed,
> > > authorized, validated, glorified, praised, demanded, approved,
> > > and yet, I don't understand why no one is merging it.
> > 
> > $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/i915/
> > Jani Nikula <jani.nikula@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > Joonas Lahtinen <joonas.lahtinen@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > Rodrigo Vivi <rodrigo.vivi@intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> (supporter:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
> > Daniel Vetter <daniel@ffwll.ch> (maintainer:DRM DRIVERS)
> > intel-gfx@lists.freedesktop.org (open list:INTEL DRM DRIVERS (excluding Poulsbo, Moorestow...)
> > dri-devel@lists.freedesktop.org (open list:DRM DRIVERS)
> > linux-kernel@vger.kernel.org (open list)
> > 
> > You've Cc'd none of the i915 maintainers, that's why it's been stuck.
> > 
> > Jani, Joonas, Rodrigo, Tvrtko, could you have a look at this?
> 
> The main change here is in drm_print.h, though and there is just
> an example of usage in i915. I though this should go through the
> drm branch.
> 
> Is it OK if I push it in drm-intel-next?

Sure, and you can add my acked-by on the first

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]