dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/panel: re-alphabetize the menu list
@ 2023-12-07  6:22 Randy Dunlap
  2023-12-07  9:52 ` Aradhya Bhatia
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-12-07  6:22 UTC (permalink / raw)
  To: linux-kernel
  Cc: Neil Armstrong, Randy Dunlap, Maxime Ripard, dri-devel,
	Thomas Zimmermann, Jessica Zhang, Sam Ravnborg

A few of the DRM_PANEL entries have become out of alphabetical order,
so move them around a bit to restore alpha order.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Jessica Zhang <quic_jesszhan@quicinc.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/panel/Kconfig |   90 ++++++++++++++++----------------
 1 file changed, 45 insertions(+), 45 deletions(-)

diff -- a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -95,34 +95,6 @@ config DRM_PANEL_LVDS
 	  handling of power supplies or control signals. It implements automatic
 	  backlight handling if the panel is attached to a backlight controller.
 
-config DRM_PANEL_SIMPLE
-	tristate "support for simple panels (other than eDP ones)"
-	depends on OF
-	depends on BACKLIGHT_CLASS_DEVICE
-	depends on PM
-	select VIDEOMODE_HELPERS
-	help
-	  DRM panel driver for dumb non-eDP panels that need at most a regulator
-	  and a GPIO to be powered up. Optionally a backlight can be attached so
-	  that it can be automatically turned off when the panel goes into a
-	  low power state.
-
-config DRM_PANEL_EDP
-	tristate "support for simple Embedded DisplayPort panels"
-	depends on OF
-	depends on BACKLIGHT_CLASS_DEVICE
-	depends on PM
-	select VIDEOMODE_HELPERS
-	select DRM_DISPLAY_DP_HELPER
-	select DRM_DISPLAY_HELPER
-	select DRM_DP_AUX_BUS
-	select DRM_KMS_HELPER
-	help
-	  DRM panel driver for dumb eDP panels that need at most a regulator and
-	  a GPIO to be powered up. Optionally a backlight can be attached so
-	  that it can be automatically turned off when the panel goes into a
-	  low power state.
-
 config DRM_PANEL_EBBG_FT8719
 	tristate "EBBG FT8719 panel driver"
 	depends on OF
@@ -317,12 +289,6 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
 	  24 bit RGB per pixel. It provides a MIPI DSI interface to
 	  the host and has a built-in LED backlight.
 
-config DRM_PANEL_SAMSUNG_LD9040
-	tristate "Samsung LD9040 RGB/SPI panel"
-	depends on OF && SPI
-	depends on BACKLIGHT_CLASS_DEVICE
-	select VIDEOMODE_HELPERS
-
 config DRM_PANEL_LG_LB035Q02
 	tristate "LG LB035Q024573 RGB panel"
 	depends on GPIOLIB && OF && SPI
@@ -350,6 +316,17 @@ config DRM_PANEL_MAGNACHIP_D53E6EA8966
 	  with the Magnachip D53E6EA8966 panel IC. This panel receives
 	  video data via DSI but commands via 9-bit SPI using DBI.
 
+config DRM_PANEL_MANTIX_MLAF057WE51
+	tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  Say Y here if you want to enable support for the Mantix
+	  MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It
+	  has a resolution of 720x1440 pixels, a built in backlight and touch
+	  controller.
+
 config DRM_PANEL_NEC_NL8048HL11
 	tristate "NEC NL8048HL11 RGB panel"
 	depends on GPIOLIB && OF && SPI
@@ -438,17 +415,6 @@ config DRM_PANEL_NOVATEK_NT39016
 	  Say Y here if you want to enable support for the panels built
 	  around the Novatek NT39016 display controller.
 
-config DRM_PANEL_MANTIX_MLAF057WE51
-	tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel"
-	depends on OF
-	depends on DRM_MIPI_DSI
-	depends on BACKLIGHT_CLASS_DEVICE
-	help
-	  Say Y here if you want to enable support for the Mantix
-	  MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It
-	  has a resolution of 720x1440 pixels, a built in backlight and touch
-	  controller.
-
 config DRM_PANEL_OLIMEX_LCD_OLINUXINO
 	tristate "Olimex LCD-OLinuXino panel"
 	depends on OF
@@ -566,6 +532,12 @@ config DRM_PANEL_SAMSUNG_DB7430
 	  DB7430 DPI display controller used in such devices as the
 	  LMS397KF04 480x800 DPI panel.
 
+config DRM_PANEL_SAMSUNG_LD9040
+	tristate "Samsung LD9040 RGB/SPI panel"
+	depends on OF && SPI
+	depends on BACKLIGHT_CLASS_DEVICE
+	select VIDEOMODE_HELPERS
+
 config DRM_PANEL_SAMSUNG_S6D16D0
 	tristate "Samsung S6D16D0 DSI video mode panel"
 	depends on OF
@@ -774,6 +746,34 @@ config DRM_PANEL_STARTEK_KD070FHFID015
 	  with a resolution of 1024 x 600 pixels. It provides a MIPI DSI interface to
 	  the host, a built-in LED backlight and touch controller.
 
+config DRM_PANEL_EDP
+	tristate "support for simple Embedded DisplayPort panels"
+	depends on OF
+	depends on BACKLIGHT_CLASS_DEVICE
+	depends on PM
+	select VIDEOMODE_HELPERS
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
+	select DRM_DP_AUX_BUS
+	select DRM_KMS_HELPER
+	help
+	  DRM panel driver for dumb eDP panels that need at most a regulator and
+	  a GPIO to be powered up. Optionally a backlight can be attached so
+	  that it can be automatically turned off when the panel goes into a
+	  low power state.
+
+config DRM_PANEL_SIMPLE
+	tristate "support for simple panels (other than eDP ones)"
+	depends on OF
+	depends on BACKLIGHT_CLASS_DEVICE
+	depends on PM
+	select VIDEOMODE_HELPERS
+	help
+	  DRM panel driver for dumb non-eDP panels that need at most a regulator
+	  and a GPIO to be powered up. Optionally a backlight can be attached so
+	  that it can be automatically turned off when the panel goes into a
+	  low power state.
+
 config DRM_PANEL_TDO_TL070WSH30
 	tristate "TDO TL070WSH30 DSI panel"
 	depends on OF

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: re-alphabetize the menu list
  2023-12-07  6:22 [PATCH] drm/panel: re-alphabetize the menu list Randy Dunlap
@ 2023-12-07  9:52 ` Aradhya Bhatia
  2023-12-07 16:58   ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Aradhya Bhatia @ 2023-12-07  9:52 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel
  Cc: Neil Armstrong, Maxime Ripard, dri-devel, Thomas Zimmermann,
	Jessica Zhang, Sam Ravnborg

Hi Randy,

Thanks for the patch!

On 07/12/23 11:52, Randy Dunlap wrote:
> A few of the DRM_PANEL entries have become out of alphabetical order,
> so move them around a bit to restore alpha order.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Jessica Zhang <quic_jesszhan@quicinc.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
>  drivers/gpu/drm/panel/Kconfig |   90 ++++++++++++++++----------------
>  1 file changed, 45 insertions(+), 45 deletions(-)
> 
> diff -- a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -95,34 +95,6 @@ config DRM_PANEL_LVDS
>  	  handling of power supplies or control signals. It implements automatic
>  	  backlight handling if the panel is attached to a backlight controller.
>  
> -config DRM_PANEL_SIMPLE
> -	tristate "support for simple panels (other than eDP ones)"
> -	depends on OF
> -	depends on BACKLIGHT_CLASS_DEVICE
> -	depends on PM
> -	select VIDEOMODE_HELPERS
> -	help
> -	  DRM panel driver for dumb non-eDP panels that need at most a regulator
> -	  and a GPIO to be powered up. Optionally a backlight can be attached so
> -	  that it can be automatically turned off when the panel goes into a
> -	  low power state.
> -
> -config DRM_PANEL_EDP
> -	tristate "support for simple Embedded DisplayPort panels"
> -	depends on OF
> -	depends on BACKLIGHT_CLASS_DEVICE
> -	depends on PM
> -	select VIDEOMODE_HELPERS
> -	select DRM_DISPLAY_DP_HELPER
> -	select DRM_DISPLAY_HELPER
> -	select DRM_DP_AUX_BUS
> -	select DRM_KMS_HELPER
> -	help
> -	  DRM panel driver for dumb eDP panels that need at most a regulator and
> -	  a GPIO to be powered up. Optionally a backlight can be attached so
> -	  that it can be automatically turned off when the panel goes into a
> -	  low power state.
> -
>  config DRM_PANEL_EBBG_FT8719
>  	tristate "EBBG FT8719 panel driver"
>  	depends on OF
> @@ -317,12 +289,6 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
>  	  24 bit RGB per pixel. It provides a MIPI DSI interface to
>  	  the host and has a built-in LED backlight.
>  
> -config DRM_PANEL_SAMSUNG_LD9040
> -	tristate "Samsung LD9040 RGB/SPI panel"
> -	depends on OF && SPI
> -	depends on BACKLIGHT_CLASS_DEVICE
> -	select VIDEOMODE_HELPERS
> -
>  config DRM_PANEL_LG_LB035Q02
>  	tristate "LG LB035Q024573 RGB panel"
>  	depends on GPIOLIB && OF && SPI
> @@ -350,6 +316,17 @@ config DRM_PANEL_MAGNACHIP_D53E6EA8966
>  	  with the Magnachip D53E6EA8966 panel IC. This panel receives
>  	  video data via DSI but commands via 9-bit SPI using DBI.
>  
> +config DRM_PANEL_MANTIX_MLAF057WE51
> +	tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel"
> +	depends on OF
> +	depends on DRM_MIPI_DSI
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	help
> +	  Say Y here if you want to enable support for the Mantix
> +	  MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It
> +	  has a resolution of 720x1440 pixels, a built in backlight and touch
> +	  controller.
> +
>  config DRM_PANEL_NEC_NL8048HL11
>  	tristate "NEC NL8048HL11 RGB panel"
>  	depends on GPIOLIB && OF && SPI
> @@ -438,17 +415,6 @@ config DRM_PANEL_NOVATEK_NT39016
>  	  Say Y here if you want to enable support for the panels built
>  	  around the Novatek NT39016 display controller.
>  
> -config DRM_PANEL_MANTIX_MLAF057WE51
> -	tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel"
> -	depends on OF
> -	depends on DRM_MIPI_DSI
> -	depends on BACKLIGHT_CLASS_DEVICE
> -	help
> -	  Say Y here if you want to enable support for the Mantix
> -	  MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It
> -	  has a resolution of 720x1440 pixels, a built in backlight and touch
> -	  controller.
> -
>  config DRM_PANEL_OLIMEX_LCD_OLINUXINO
>  	tristate "Olimex LCD-OLinuXino panel"
>  	depends on OF
> @@ -566,6 +532,12 @@ config DRM_PANEL_SAMSUNG_DB7430
>  	  DB7430 DPI display controller used in such devices as the
>  	  LMS397KF04 480x800 DPI panel.
>  
> +config DRM_PANEL_SAMSUNG_LD9040
> +	tristate "Samsung LD9040 RGB/SPI panel"
> +	depends on OF && SPI
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	select VIDEOMODE_HELPERS
> +
>  config DRM_PANEL_SAMSUNG_S6D16D0
>  	tristate "Samsung S6D16D0 DSI video mode panel"
>  	depends on OF
> @@ -774,6 +746,34 @@ config DRM_PANEL_STARTEK_KD070FHFID015
>  	  with a resolution of 1024 x 600 pixels. It provides a MIPI DSI interface to
>  	  the host, a built-in LED backlight and touch controller.
>  
> +config DRM_PANEL_EDP
> +	tristate "support for simple Embedded DisplayPort panels"
> +	depends on OF
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	depends on PM
> +	select VIDEOMODE_HELPERS
> +	select DRM_DISPLAY_DP_HELPER
> +	select DRM_DISPLAY_HELPER
> +	select DRM_DP_AUX_BUS
> +	select DRM_KMS_HELPER
> +	help
> +	  DRM panel driver for dumb eDP panels that need at most a regulator and
> +	  a GPIO to be powered up. Optionally a backlight can be attached so
> +	  that it can be automatically turned off when the panel goes into a
> +	  low power state.
> +

I don't think you intended to put PANEL_EDP this down the file! But just
in case if you did, why?

Regards
Aradhya

> +config DRM_PANEL_SIMPLE
> +	tristate "support for simple panels (other than eDP ones)"
> +	depends on OF
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	depends on PM
> +	select VIDEOMODE_HELPERS
> +	help
> +	  DRM panel driver for dumb non-eDP panels that need at most a regulator
> +	  and a GPIO to be powered up. Optionally a backlight can be attached so
> +	  that it can be automatically turned off when the panel goes into a
> +	  low power state.
> +
>  config DRM_PANEL_TDO_TL070WSH30
>  	tristate "TDO TL070WSH30 DSI panel"
>  	depends on OF

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: re-alphabetize the menu list
  2023-12-07  9:52 ` Aradhya Bhatia
@ 2023-12-07 16:58   ` Randy Dunlap
  2023-12-08  9:03     ` Aradhya Bhatia
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-12-07 16:58 UTC (permalink / raw)
  To: Aradhya Bhatia, linux-kernel
  Cc: Neil Armstrong, Maxime Ripard, dri-devel, Thomas Zimmermann,
	Jessica Zhang, Sam Ravnborg



On 12/7/23 01:52, Aradhya Bhatia wrote:
> Hi Randy,
> 
> Thanks for the patch!
> 
> On 07/12/23 11:52, Randy Dunlap wrote:
>> A few of the DRM_PANEL entries have become out of alphabetical order,
>> so move them around a bit to restore alpha order.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Jessica Zhang <quic_jesszhan@quicinc.com>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: dri-devel@lists.freedesktop.org
>> ---
>>  drivers/gpu/drm/panel/Kconfig |   90 ++++++++++++++++----------------
>>  1 file changed, 45 insertions(+), 45 deletions(-)
>>
>> diff -- a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
>> --- a/drivers/gpu/drm/panel/Kconfig
>> +++ b/drivers/gpu/drm/panel/Kconfig
>> @@ -95,34 +95,6 @@ config DRM_PANEL_LVDS
>>  	  handling of power supplies or control signals. It implements automatic
>>  	  backlight handling if the panel is attached to a backlight controller.
>>  
>> -config DRM_PANEL_SIMPLE
>> -	tristate "support for simple panels (other than eDP ones)"
>> -	depends on OF
>> -	depends on BACKLIGHT_CLASS_DEVICE
>> -	depends on PM
>> -	select VIDEOMODE_HELPERS
>> -	help
>> -	  DRM panel driver for dumb non-eDP panels that need at most a regulator
>> -	  and a GPIO to be powered up. Optionally a backlight can be attached so
>> -	  that it can be automatically turned off when the panel goes into a
>> -	  low power state.
>> -
>> -config DRM_PANEL_EDP
>> -	tristate "support for simple Embedded DisplayPort panels"
>> -	depends on OF
>> -	depends on BACKLIGHT_CLASS_DEVICE
>> -	depends on PM
>> -	select VIDEOMODE_HELPERS
>> -	select DRM_DISPLAY_DP_HELPER
>> -	select DRM_DISPLAY_HELPER
>> -	select DRM_DP_AUX_BUS
>> -	select DRM_KMS_HELPER
>> -	help
>> -	  DRM panel driver for dumb eDP panels that need at most a regulator and
>> -	  a GPIO to be powered up. Optionally a backlight can be attached so
>> -	  that it can be automatically turned off when the panel goes into a
>> -	  low power state.
>> -
>>  config DRM_PANEL_EBBG_FT8719
>>  	tristate "EBBG FT8719 panel driver"
>>  	depends on OF
>> @@ -317,12 +289,6 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
>>  	  24 bit RGB per pixel. It provides a MIPI DSI interface to
>>  	  the host and has a built-in LED backlight.
>>  
>> -config DRM_PANEL_SAMSUNG_LD9040
>> -	tristate "Samsung LD9040 RGB/SPI panel"
>> -	depends on OF && SPI
>> -	depends on BACKLIGHT_CLASS_DEVICE
>> -	select VIDEOMODE_HELPERS
>> -
>>  config DRM_PANEL_LG_LB035Q02
>>  	tristate "LG LB035Q024573 RGB panel"
>>  	depends on GPIOLIB && OF && SPI
>> @@ -350,6 +316,17 @@ config DRM_PANEL_MAGNACHIP_D53E6EA8966
>>  	  with the Magnachip D53E6EA8966 panel IC. This panel receives
>>  	  video data via DSI but commands via 9-bit SPI using DBI.
>>  
>> +config DRM_PANEL_MANTIX_MLAF057WE51
>> +	tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel"
>> +	depends on OF
>> +	depends on DRM_MIPI_DSI
>> +	depends on BACKLIGHT_CLASS_DEVICE
>> +	help
>> +	  Say Y here if you want to enable support for the Mantix
>> +	  MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It
>> +	  has a resolution of 720x1440 pixels, a built in backlight and touch
>> +	  controller.
>> +
>>  config DRM_PANEL_NEC_NL8048HL11
>>  	tristate "NEC NL8048HL11 RGB panel"
>>  	depends on GPIOLIB && OF && SPI
>> @@ -438,17 +415,6 @@ config DRM_PANEL_NOVATEK_NT39016
>>  	  Say Y here if you want to enable support for the panels built
>>  	  around the Novatek NT39016 display controller.
>>  
>> -config DRM_PANEL_MANTIX_MLAF057WE51
>> -	tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel"
>> -	depends on OF
>> -	depends on DRM_MIPI_DSI
>> -	depends on BACKLIGHT_CLASS_DEVICE
>> -	help
>> -	  Say Y here if you want to enable support for the Mantix
>> -	  MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It
>> -	  has a resolution of 720x1440 pixels, a built in backlight and touch
>> -	  controller.
>> -
>>  config DRM_PANEL_OLIMEX_LCD_OLINUXINO
>>  	tristate "Olimex LCD-OLinuXino panel"
>>  	depends on OF
>> @@ -566,6 +532,12 @@ config DRM_PANEL_SAMSUNG_DB7430
>>  	  DB7430 DPI display controller used in such devices as the
>>  	  LMS397KF04 480x800 DPI panel.
>>  
>> +config DRM_PANEL_SAMSUNG_LD9040
>> +	tristate "Samsung LD9040 RGB/SPI panel"
>> +	depends on OF && SPI
>> +	depends on BACKLIGHT_CLASS_DEVICE
>> +	select VIDEOMODE_HELPERS
>> +
>>  config DRM_PANEL_SAMSUNG_S6D16D0
>>  	tristate "Samsung S6D16D0 DSI video mode panel"
>>  	depends on OF
>> @@ -774,6 +746,34 @@ config DRM_PANEL_STARTEK_KD070FHFID015
>>  	  with a resolution of 1024 x 600 pixels. It provides a MIPI DSI interface to
>>  	  the host, a built-in LED backlight and touch controller.
>>  
>> +config DRM_PANEL_EDP
>> +	tristate "support for simple Embedded DisplayPort panels"
>> +	depends on OF
>> +	depends on BACKLIGHT_CLASS_DEVICE
>> +	depends on PM
>> +	select VIDEOMODE_HELPERS
>> +	select DRM_DISPLAY_DP_HELPER
>> +	select DRM_DISPLAY_HELPER
>> +	select DRM_DP_AUX_BUS
>> +	select DRM_KMS_HELPER
>> +	help
>> +	  DRM panel driver for dumb eDP panels that need at most a regulator and
>> +	  a GPIO to be powered up. Optionally a backlight can be attached so
>> +	  that it can be automatically turned off when the panel goes into a
>> +	  low power state.
>> +
> 
> I don't think you intended to put PANEL_EDP this down the file! But just
> in case if you did, why?

I was alphabetizing on "support for simple" on the entry above and the
one below.  Even without "support for", they would read as
"Simple ... panels".

> Regards
> Aradhya
> 
>> +config DRM_PANEL_SIMPLE
>> +	tristate "support for simple panels (other than eDP ones)"
>> +	depends on OF
>> +	depends on BACKLIGHT_CLASS_DEVICE
>> +	depends on PM
>> +	select VIDEOMODE_HELPERS
>> +	help
>> +	  DRM panel driver for dumb non-eDP panels that need at most a regulator
>> +	  and a GPIO to be powered up. Optionally a backlight can be attached so
>> +	  that it can be automatically turned off when the panel goes into a
>> +	  low power state.
>> +
>>  config DRM_PANEL_TDO_TL070WSH30
>>  	tristate "TDO TL070WSH30 DSI panel"
>>  	depends on OF

-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/panel: re-alphabetize the menu list
  2023-12-07 16:58   ` Randy Dunlap
@ 2023-12-08  9:03     ` Aradhya Bhatia
  0 siblings, 0 replies; 4+ messages in thread
From: Aradhya Bhatia @ 2023-12-08  9:03 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel
  Cc: Neil Armstrong, Maxime Ripard, dri-devel, Thomas Zimmermann,
	Jessica Zhang, Sam Ravnborg



On 07/12/23 22:28, Randy Dunlap wrote:
> 
> 
> On 12/7/23 01:52, Aradhya Bhatia wrote:
>> Hi Randy,
>>
>> Thanks for the patch!
>>
>> On 07/12/23 11:52, Randy Dunlap wrote:
>>> A few of the DRM_PANEL entries have become out of alphabetical order,
>>> so move them around a bit to restore alpha order.
>>>
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>>> Cc: Jessica Zhang <quic_jesszhan@quicinc.com>
>>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> Cc: Maxime Ripard <mripard@kernel.org>
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: David Airlie <airlied@gmail.com>
>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>> Cc: dri-devel@lists.freedesktop.org
>>> ---
>>>  drivers/gpu/drm/panel/Kconfig |   90 ++++++++++++++++----------------
>>>  1 file changed, 45 insertions(+), 45 deletions(-)
>>>
>>> diff -- a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
>>> --- a/drivers/gpu/drm/panel/Kconfig
>>> +++ b/drivers/gpu/drm/panel/Kconfig
>>> @@ -95,34 +95,6 @@ config DRM_PANEL_LVDS
>>>  	  handling of power supplies or control signals. It implements automatic
>>>  	  backlight handling if the panel is attached to a backlight controller.
>>>  
>>> -config DRM_PANEL_SIMPLE
>>> -	tristate "support for simple panels (other than eDP ones)"
>>> -	depends on OF
>>> -	depends on BACKLIGHT_CLASS_DEVICE
>>> -	depends on PM
>>> -	select VIDEOMODE_HELPERS
>>> -	help
>>> -	  DRM panel driver for dumb non-eDP panels that need at most a regulator
>>> -	  and a GPIO to be powered up. Optionally a backlight can be attached so
>>> -	  that it can be automatically turned off when the panel goes into a
>>> -	  low power state.
>>> -
>>> -config DRM_PANEL_EDP
>>> -	tristate "support for simple Embedded DisplayPort panels"
>>> -	depends on OF
>>> -	depends on BACKLIGHT_CLASS_DEVICE
>>> -	depends on PM
>>> -	select VIDEOMODE_HELPERS
>>> -	select DRM_DISPLAY_DP_HELPER
>>> -	select DRM_DISPLAY_HELPER
>>> -	select DRM_DP_AUX_BUS
>>> -	select DRM_KMS_HELPER
>>> -	help
>>> -	  DRM panel driver for dumb eDP panels that need at most a regulator and
>>> -	  a GPIO to be powered up. Optionally a backlight can be attached so
>>> -	  that it can be automatically turned off when the panel goes into a
>>> -	  low power state.
>>> -
>>>  config DRM_PANEL_EBBG_FT8719
>>>  	tristate "EBBG FT8719 panel driver"
>>>  	depends on OF
>>> @@ -317,12 +289,6 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
>>>  	  24 bit RGB per pixel. It provides a MIPI DSI interface to
>>>  	  the host and has a built-in LED backlight.
>>>  
>>> -config DRM_PANEL_SAMSUNG_LD9040
>>> -	tristate "Samsung LD9040 RGB/SPI panel"
>>> -	depends on OF && SPI
>>> -	depends on BACKLIGHT_CLASS_DEVICE
>>> -	select VIDEOMODE_HELPERS
>>> -
>>>  config DRM_PANEL_LG_LB035Q02
>>>  	tristate "LG LB035Q024573 RGB panel"
>>>  	depends on GPIOLIB && OF && SPI
>>> @@ -350,6 +316,17 @@ config DRM_PANEL_MAGNACHIP_D53E6EA8966
>>>  	  with the Magnachip D53E6EA8966 panel IC. This panel receives
>>>  	  video data via DSI but commands via 9-bit SPI using DBI.
>>>  
>>> +config DRM_PANEL_MANTIX_MLAF057WE51
>>> +	tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel"
>>> +	depends on OF
>>> +	depends on DRM_MIPI_DSI
>>> +	depends on BACKLIGHT_CLASS_DEVICE
>>> +	help
>>> +	  Say Y here if you want to enable support for the Mantix
>>> +	  MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It
>>> +	  has a resolution of 720x1440 pixels, a built in backlight and touch
>>> +	  controller.
>>> +
>>>  config DRM_PANEL_NEC_NL8048HL11
>>>  	tristate "NEC NL8048HL11 RGB panel"
>>>  	depends on GPIOLIB && OF && SPI
>>> @@ -438,17 +415,6 @@ config DRM_PANEL_NOVATEK_NT39016
>>>  	  Say Y here if you want to enable support for the panels built
>>>  	  around the Novatek NT39016 display controller.
>>>  
>>> -config DRM_PANEL_MANTIX_MLAF057WE51
>>> -	tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel"
>>> -	depends on OF
>>> -	depends on DRM_MIPI_DSI
>>> -	depends on BACKLIGHT_CLASS_DEVICE
>>> -	help
>>> -	  Say Y here if you want to enable support for the Mantix
>>> -	  MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It
>>> -	  has a resolution of 720x1440 pixels, a built in backlight and touch
>>> -	  controller.
>>> -
>>>  config DRM_PANEL_OLIMEX_LCD_OLINUXINO
>>>  	tristate "Olimex LCD-OLinuXino panel"
>>>  	depends on OF
>>> @@ -566,6 +532,12 @@ config DRM_PANEL_SAMSUNG_DB7430
>>>  	  DB7430 DPI display controller used in such devices as the
>>>  	  LMS397KF04 480x800 DPI panel.
>>>  
>>> +config DRM_PANEL_SAMSUNG_LD9040
>>> +	tristate "Samsung LD9040 RGB/SPI panel"
>>> +	depends on OF && SPI
>>> +	depends on BACKLIGHT_CLASS_DEVICE
>>> +	select VIDEOMODE_HELPERS
>>> +
>>>  config DRM_PANEL_SAMSUNG_S6D16D0
>>>  	tristate "Samsung S6D16D0 DSI video mode panel"
>>>  	depends on OF
>>> @@ -774,6 +746,34 @@ config DRM_PANEL_STARTEK_KD070FHFID015
>>>  	  with a resolution of 1024 x 600 pixels. It provides a MIPI DSI interface to
>>>  	  the host, a built-in LED backlight and touch controller.
>>>  
>>> +config DRM_PANEL_EDP
>>> +	tristate "support for simple Embedded DisplayPort panels"
>>> +	depends on OF
>>> +	depends on BACKLIGHT_CLASS_DEVICE
>>> +	depends on PM
>>> +	select VIDEOMODE_HELPERS
>>> +	select DRM_DISPLAY_DP_HELPER
>>> +	select DRM_DISPLAY_HELPER
>>> +	select DRM_DP_AUX_BUS
>>> +	select DRM_KMS_HELPER
>>> +	help
>>> +	  DRM panel driver for dumb eDP panels that need at most a regulator and
>>> +	  a GPIO to be powered up. Optionally a backlight can be attached so
>>> +	  that it can be automatically turned off when the panel goes into a
>>> +	  low power state.
>>> +
>>
>> I don't think you intended to put PANEL_EDP this down the file! But just
>> in case if you did, why?
> 
> I was alphabetizing on "support for simple" on the entry above and the
> one below.  Even without "support for", they would read as
> "Simple ... panels".

That's fair. I suppose anybody seeing the menuconfig would see the mini
description.

Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>

> 
>> Regards
>> Aradhya
>>
>>> +config DRM_PANEL_SIMPLE
>>> +	tristate "support for simple panels (other than eDP ones)"
>>> +	depends on OF
>>> +	depends on BACKLIGHT_CLASS_DEVICE
>>> +	depends on PM
>>> +	select VIDEOMODE_HELPERS
>>> +	help
>>> +	  DRM panel driver for dumb non-eDP panels that need at most a regulator
>>> +	  and a GPIO to be powered up. Optionally a backlight can be attached so
>>> +	  that it can be automatically turned off when the panel goes into a
>>> +	  low power state.
>>> +
>>>  config DRM_PANEL_TDO_TL070WSH30
>>>  	tristate "TDO TL070WSH30 DSI panel"
>>>  	depends on OF
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-12-08  9:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-07  6:22 [PATCH] drm/panel: re-alphabetize the menu list Randy Dunlap
2023-12-07  9:52 ` Aradhya Bhatia
2023-12-07 16:58   ` Randy Dunlap
2023-12-08  9:03     ` Aradhya Bhatia

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).