* Re: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings
[not found] <20240409082641.359627-1-jacobe.zang@wesion.com>
@ 2024-04-09 20:11 ` Krzysztof Kozlowski
2024-04-10 4:22 ` Christian Hewitt
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-09 20:11 UTC (permalink / raw)
To: Jacobe Zang, neil.armstrong, narmstrong, airlied, daniel,
maarten.lankhorst, mripard, tzimmermann, robh,
krzysztof.kozlowski+dt, conor+dt
Cc: quic_jesszhan, sam, nick, thierry.reding, dri-devel, devicetree,
linux-kernel, linux-amlogic
On 09/04/2024 10:26, Jacobe Zang wrote:
> This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel
> designed to work with the Khadas VIM3 and VIM3L Single Board Computers.
>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
> .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index f9160d7bac3ca..e194309f31b72 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -36,6 +36,8 @@ properties:
> - jdi,fhd-r63452
> # Khadas TS050 5" 1080x1920 LCD panel
> - khadas,ts050
> + # Khadas NEW TS050 5" 1080x1920 LCD panel
> + - khadas,newts050
Keep things ordered.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings
[not found] <20240409082641.359627-1-jacobe.zang@wesion.com>
2024-04-09 20:11 ` [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings Krzysztof Kozlowski
@ 2024-04-10 4:22 ` Christian Hewitt
2024-04-10 18:57 ` Rob Herring
1 sibling, 1 reply; 3+ messages in thread
From: Christian Hewitt @ 2024-04-10 4:22 UTC (permalink / raw)
To: Jacobe Zang
Cc: Neil Armstrong, Neil Armstrong, David Airlie, Daniel Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, quic_jesszhan, sam, nick,
thierry.reding, dri-devel, devicetree, LKML, AML
> On 9 Apr 2024, at 12:26 PM, Jacobe Zang <jacobe.zang@wesion.com> wrote:
>
> This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel
> designed to work with the Khadas VIM3 and VIM3L Single Board Computers.
>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
> .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index f9160d7bac3ca..e194309f31b72 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -36,6 +36,8 @@ properties:
> - jdi,fhd-r63452
> # Khadas TS050 5" 1080x1920 LCD panel
> - khadas,ts050
> + # Khadas NEW TS050 5" 1080x1920 LCD panel
> + - khadas,newts050
Products are only new until they are old. At some future point there will
inevitably be a third iteration requiring a ‘new new’ name. IMHO it would
be better to use something like khadas,ts050v2.
CH.
> # Kingdisplay KD097D04 9.7" 1536x2048 TFT LCD panel
> - kingdisplay,kd097d04
> # LG ACX467AKM-7 4.95" 1080×1920 LCD Panel
> --
> 2.34.1
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings
2024-04-10 4:22 ` Christian Hewitt
@ 2024-04-10 18:57 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-04-10 18:57 UTC (permalink / raw)
To: Christian Hewitt
Cc: Jacobe Zang, Neil Armstrong, Neil Armstrong, David Airlie,
Daniel Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Krzysztof Kozlowski, Conor Dooley,
quic_jesszhan, sam, nick, thierry.reding, dri-devel, devicetree,
LKML, AML
On Wed, Apr 10, 2024 at 08:22:25AM +0400, Christian Hewitt wrote:
> > On 9 Apr 2024, at 12:26 PM, Jacobe Zang <jacobe.zang@wesion.com> wrote:
> >
> > This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel
> > designed to work with the Khadas VIM3 and VIM3L Single Board Computers.
> >
> > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> > ---
> > .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > index f9160d7bac3ca..e194309f31b72 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > @@ -36,6 +36,8 @@ properties:
> > - jdi,fhd-r63452
> > # Khadas TS050 5" 1080x1920 LCD panel
> > - khadas,ts050
> > + # Khadas NEW TS050 5" 1080x1920 LCD panel
> > + - khadas,newts050
>
> Products are only new until they are old. At some future point there will
> inevitably be a third iteration requiring a ‘new new’ name. IMHO it would
> be better to use something like khadas,ts050v2.
I only see patch 1, so the threading is messed up...
In any case, The commit message should say something about how they are
different? Is the new one not compatible with the old? That's what this
change tells me. Otherwise, it should have a fallback.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-10 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240409082641.359627-1-jacobe.zang@wesion.com>
2024-04-09 20:11 ` [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings Krzysztof Kozlowski
2024-04-10 4:22 ` Christian Hewitt
2024-04-10 18:57 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).