* [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage
@ 2024-04-08 17:04 Ville Syrjala
2024-04-08 17:04 ` [PATCH 01/21] drm/armada: Fix printk arguments Ville Syrjala
` (23 more replies)
0 siblings, 24 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
I got fed up having to build multiple architectures when
doing subsystem wide refactoring. So I decided to attack
the low hanging COMPILE_TEST=y fruit. Here are the
results. All of these drivers now build with COMPILE_TEST=y
on x86/x86_64
Ville Syrjälä (21):
drm/armada: Fix printk arguments
drm/armada: Fix armada_debugfs_crtc_reg_write() return type
drm/armada: Allow build with COMPILE_TEST=y
drm/imx/dcss: Fix 64bit divisions
drm/imx/dcss: Allow build with COMPILE_TEST=y
drm/sti: Include linux/io.h for devm_ioremap()
drm/sti: Allow build with COMPILE_TEST=y
drm/hisilicon/kirin: Include linux/io.h for readl()/writel()
drm/hisilicon/kirin: Fix 64bit divisions
drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures
drm/hisilicon/kirin: Allow build with COMPILE_TEST=y
drm/tilcdc: Allow build without __iowmb()
drm/tilcdc: Allow build with COMPILE_TEST=y
drm/omap: Open code phys_to_page()
drm/omap: Allow build with COMPILE_TEST=y
drm/atmel-hlcdc: Allow build with COMPILE_TEST=y
drm/fsl-dcu: Allow build with COMPILE_TEST=y
drm/mediatek: Allow build with COMPILE_TEST=y
drm/meson: Allow build with COMPILE_TEST=y
drm/rcar-du: Allow build with COMPILE_TEST=y
drm/stm: Allow build with COMPILE_TEST=y
drivers/gpu/drm/armada/Kconfig | 2 +-
drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
drivers/gpu/drm/armada/armada_gem.c | 2 +-
drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +-
drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
drivers/gpu/drm/hisilicon/kirin/Kconfig | 2 +-
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 11 +++++------
drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h | 2 ++
drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h | 2 +-
drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++--
drivers/gpu/drm/mediatek/Kconfig | 4 ++--
drivers/gpu/drm/meson/Kconfig | 2 +-
drivers/gpu/drm/omapdrm/Kconfig | 2 +-
drivers/gpu/drm/omapdrm/omap_gem.c | 4 ++--
drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +-
drivers/gpu/drm/sti/Kconfig | 2 +-
drivers/gpu/drm/sti/sti_dvo.c | 1 +
drivers/gpu/drm/stm/Kconfig | 2 +-
drivers/gpu/drm/tilcdc/Kconfig | 2 +-
drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
21 files changed, 30 insertions(+), 26 deletions(-)
--
2.43.2
^ permalink raw reply [flat|nested] 44+ messages in thread
* [PATCH 01/21] drm/armada: Fix printk arguments
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 02/21] drm/armada: Fix armada_debugfs_crtc_reg_write() return type Ville Syrjala
` (22 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Russell King
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
../drivers/gpu/drm/armada/armada_gem.c: In function ‘armada_gem_pwrite_ioctl’:
../drivers/gpu/drm/armada/armada_gem.c:367:27: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
367 | DRM_ERROR("invalid size: object size %u\n", dobj->obj.size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~
| |
| size_t {aka long unsigned int}
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/armada/armada_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
index 26d10065d534..e9575ef5aaef 100644
--- a/drivers/gpu/drm/armada/armada_gem.c
+++ b/drivers/gpu/drm/armada/armada_gem.c
@@ -364,7 +364,7 @@ int armada_gem_pwrite_ioctl(struct drm_device *dev, void *data,
if (args->offset > dobj->obj.size ||
args->size > dobj->obj.size - args->offset) {
- DRM_ERROR("invalid size: object size %u\n", dobj->obj.size);
+ DRM_ERROR("invalid size: object size %zu\n", dobj->obj.size);
ret = -EINVAL;
goto unref;
}
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 02/21] drm/armada: Fix armada_debugfs_crtc_reg_write() return type
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
2024-04-08 17:04 ` [PATCH 01/21] drm/armada: Fix printk arguments Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 03/21] drm/armada: Allow build with COMPILE_TEST=y Ville Syrjala
` (21 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Russell King
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Change the armada_debugfs_crtc_reg_write() return type to
the correct ssize_t. This makes the code actually build on
certain architectures.
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/armada/armada_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_debugfs.c b/drivers/gpu/drm/armada/armada_debugfs.c
index 29f4b52e3c8d..338f0f6ca441 100644
--- a/drivers/gpu/drm/armada/armada_debugfs.c
+++ b/drivers/gpu/drm/armada/armada_debugfs.c
@@ -48,7 +48,7 @@ static int armada_debugfs_crtc_reg_open(struct inode *inode, struct file *file)
inode->i_private);
}
-static int armada_debugfs_crtc_reg_write(struct file *file,
+static ssize_t armada_debugfs_crtc_reg_write(struct file *file,
const char __user *ptr, size_t len, loff_t *off)
{
struct armada_crtc *dcrtc;
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 03/21] drm/armada: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
2024-04-08 17:04 ` [PATCH 01/21] drm/armada: Fix printk arguments Ville Syrjala
2024-04-08 17:04 ` [PATCH 02/21] drm/armada: Fix armada_debugfs_crtc_reg_write() return type Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 04/21] drm/imx/dcss: Fix 64bit divisions Ville Syrjala
` (20 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Russell King
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow armada to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/armada/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/Kconfig b/drivers/gpu/drm/armada/Kconfig
index e5597d7c9ae1..043ca103ab3f 100644
--- a/drivers/gpu/drm/armada/Kconfig
+++ b/drivers/gpu/drm/armada/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_ARMADA
tristate "DRM support for Marvell Armada SoCs"
- depends on DRM && HAVE_CLK && ARM && MMU
+ depends on DRM && HAVE_CLK && MMU && (ARM || COMPILE_TEST)
select DRM_KMS_HELPER
select FB_IOMEM_HELPERS if DRM_FBDEV_EMULATION
help
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 04/21] drm/imx/dcss: Fix 64bit divisions
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (2 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 03/21] drm/armada: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 05/21] drm/imx/dcss: Allow build with COMPILE_TEST=y Ville Syrjala
` (19 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Laurentiu Palcu, Lucas Stach
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Use the appropriate 64bit division helpers to make the code
build on 32bit architectures.
Cc: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
index 825728c356ff..32c3f46b21da 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
@@ -136,7 +136,7 @@ static int div_q(int A, int B)
else
temp -= B / 2;
- result = (int)(temp / B);
+ result = div_s64(temp, B);
return result;
}
@@ -239,7 +239,7 @@ static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
ll_temp = coef[phase][i];
ll_temp <<= PSC_COEFF_PRECISION;
ll_temp += sum >> 1;
- ll_temp /= sum;
+ ll_temp = div_s64(ll_temp, sum);
coef[phase][i] = (int)ll_temp;
}
}
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 05/21] drm/imx/dcss: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (3 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 04/21] drm/imx/dcss: Fix 64bit divisions Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 06/21] drm/sti: Include linux/io.h for devm_ioremap() Ville Syrjala
` (18 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Laurentiu Palcu, Lucas Stach
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow imx/dcss to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
dpiormw.cocci
---
drivers/gpu/drm/imx/dcss/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
index 3ffc061d392b..502612747007 100644
--- a/drivers/gpu/drm/imx/dcss/Kconfig
+++ b/drivers/gpu/drm/imx/dcss/Kconfig
@@ -4,7 +4,7 @@ config DRM_IMX_DCSS
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
select VIDEOMODE_HELPERS
- depends on DRM && ARCH_MXC && ARM64
+ depends on DRM && ((ARCH_MXC && ARM64) || COMPILE_TEST)
help
Choose this if you have a NXP i.MX8MQ based system and want to use the
Display Controller Subsystem. This option enables DCSS support.
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 06/21] drm/sti: Include linux/io.h for devm_ioremap()
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (4 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 05/21] drm/imx/dcss: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 07/21] drm/sti: Allow build with COMPILE_TEST=y Ville Syrjala
` (17 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Alain Volmat
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Include linux/io.h for devm_ioremap().
When built on x86_64 w/ COMPILE_TEST=y:
../drivers/gpu/drm/sti/sti_dvo.c:531:21: error: implicit declaration of function ‘devm_ioremap’ [-Werror=implicit-function-declaration]
531 | dvo->regs = devm_ioremap(dev, res->start,
| ^~~~~~~~~~~~
../drivers/gpu/drm/sti/sti_dvo.c:531:19: error: assignment to ‘void *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
531 | dvo->regs = devm_ioremap(dev, res->start,
| ^
Cc: Alain Volmat <alain.volmat@foss.st.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/sti/sti_dvo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index fd1df4ce3852..48a5d49fc131 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -7,6 +7,7 @@
#include <linux/clk.h>
#include <linux/component.h>
#include <linux/debugfs.h>
+#include <linux/io.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 07/21] drm/sti: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (5 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 06/21] drm/sti: Include linux/io.h for devm_ioremap() Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 08/21] drm/hisilicon/kirin: Include linux/io.h for readl()/writel() Ville Syrjala
` (16 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Alain Volmat
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow sti to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Alain Volmat <alain.volmat@foss.st.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/sti/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig
index 3c7a5feff8de..75c301aadcbc 100644
--- a/drivers/gpu/drm/sti/Kconfig
+++ b/drivers/gpu/drm/sti/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_STI
tristate "DRM Support for STMicroelectronics SoC stiH4xx Series"
- depends on OF && DRM && ARCH_STI
+ depends on OF && DRM && (ARCH_STI || COMPILE_TEST)
select RESET_CONTROLLER
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 08/21] drm/hisilicon/kirin: Include linux/io.h for readl()/writel()
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (6 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 07/21] drm/sti: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:08 ` John Stultz
2024-04-08 17:04 ` [PATCH 09/21] drm/hisilicon/kirin: Fix 64bit divisions Ville Syrjala
` (15 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel
Cc: Xinliang Liu, Tian Tao, Xinwei Kong, Sumit Semwal, Yongqin Liu,
John Stultz
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Include linux/io.h for readl()/writel().
When built on x86_64 w/ COMPILE_TEST=y:
../drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h:93:16: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
93 | orig = readl(addr);
| ^~~~~
../drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h:96:9: error: implicit declaration of function ‘writel’ [-Werror=implicit-function-declaration]
96 | writel(tmp, addr);
| ^~~~~~
Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Yongqin Liu <yongqin.liu@linaro.org>
Cc: John Stultz <jstultz@google.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h b/drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h
index d79fc031e53d..a87d1135856f 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h
@@ -7,6 +7,8 @@
#ifndef __DW_DSI_REG_H__
#define __DW_DSI_REG_H__
+#include <linux/io.h>
+
#define MASK(x) (BIT(x) - 1)
/*
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 09/21] drm/hisilicon/kirin: Fix 64bit divisions
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (7 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 08/21] drm/hisilicon/kirin: Include linux/io.h for readl()/writel() Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:09 ` John Stultz
2024-04-08 17:04 ` [PATCH 10/21] drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures Ville Syrjala
` (14 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel
Cc: Xinliang Liu, Tian Tao, Xinwei Kong, Sumit Semwal, Yongqin Liu,
John Stultz
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Use the appropriate 64bit division helpers to make the code
build on 32bit architectures.
Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Yongqin Liu <yongqin.liu@linaro.org>
Cc: John Stultz <jstultz@google.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
index 566de4658719..a39cc549c20b 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -157,8 +157,8 @@ static u32 dsi_calc_phy_rate(u32 req_kHz, struct mipi_phy_params *phy)
q_pll = 0x10 >> (7 - phy->hstx_ckg_sel);
temp = f_kHz * (u64)q_pll * (u64)ref_clk_ps;
- m_n_int = temp / (u64)1000000000;
- m_n = (temp % (u64)1000000000) / (u64)100000000;
+ m_n_int = div64_u64_rem(temp, 1000000000, &temp);
+ m_n = div_u64(temp, 100000000);
if (m_n_int % 2 == 0) {
if (m_n * 6 >= 50) {
@@ -229,9 +229,8 @@ static u32 dsi_calc_phy_rate(u32 req_kHz, struct mipi_phy_params *phy)
phy->pll_fbd_div5f = 1;
}
- f_kHz = (u64)1000000000 * (u64)m_pll /
- ((u64)ref_clk_ps * (u64)n_pll * (u64)q_pll);
-
+ f_kHz = div64_u64((u64)1000000000 * (u64)m_pll,
+ (u64)ref_clk_ps * (u64)n_pll * (u64)q_pll);
if (f_kHz >= req_kHz)
break;
@@ -490,7 +489,7 @@ static void dsi_set_mode_timing(void __iomem *base,
hsa_time = (hsw * lane_byte_clk_kHz) / pixel_clk_kHz;
hbp_time = (hbp * lane_byte_clk_kHz) / pixel_clk_kHz;
tmp = (u64)htot * (u64)lane_byte_clk_kHz;
- hline_time = DIV_ROUND_UP(tmp, pixel_clk_kHz);
+ hline_time = DIV_ROUND_UP_ULL(tmp, pixel_clk_kHz);
/* all specified in byte-lane clocks */
writel(hsa_time, base + VID_HSA_TIME);
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 10/21] drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (8 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 09/21] drm/hisilicon/kirin: Fix 64bit divisions Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:09 ` John Stultz
2024-04-08 17:04 ` [PATCH 11/21] drm/hisilicon/kirin: Allow build with COMPILE_TEST=y Ville Syrjala
` (13 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel
Cc: Xinliang Liu, Tian Tao, Xinwei Kong, Sumit Semwal, Yongqin Liu,
John Stultz
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
BIT(32) is illegal when sizeof(long)==4. Use BIT_ULL(32)
instead.
Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Yongqin Liu <yongqin.liu@linaro.org>
Cc: John Stultz <jstultz@google.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h b/drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h
index be9e789c2d04..36f923cc7594 100644
--- a/drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h
+++ b/drivers/gpu/drm/hisilicon/kirin/kirin_ade_reg.h
@@ -10,7 +10,7 @@
/*
* ADE Registers
*/
-#define MASK(x) (BIT(x) - 1)
+#define MASK(x) (BIT_ULL(x) - 1)
#define ADE_CTRL 0x0004
#define FRM_END_START_OFST 0
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 11/21] drm/hisilicon/kirin: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (9 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 10/21] drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:11 ` John Stultz
2024-04-08 17:04 ` [PATCH 12/21] drm/tilcdc: Allow build without __iowmb() Ville Syrjala
` (12 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel
Cc: Xinliang Liu, Tian Tao, Xinwei Kong, Sumit Semwal, Yongqin Liu,
John Stultz
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow kirin to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Yongqin Liu <yongqin.liu@linaro.org>
Cc: John Stultz <jstultz@google.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/hisilicon/kirin/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/Kconfig b/drivers/gpu/drm/hisilicon/kirin/Kconfig
index c5265675bf0c..0772f79567ef 100644
--- a/drivers/gpu/drm/hisilicon/kirin/Kconfig
+++ b/drivers/gpu/drm/hisilicon/kirin/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_HISI_KIRIN
tristate "DRM Support for Hisilicon Kirin series SoCs Platform"
- depends on DRM && OF && ARM64
+ depends on DRM && OF && (ARM64 || COMPILE_TEST)
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
select DRM_MIPI_DSI
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (10 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 11/21] drm/hisilicon/kirin: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-10 9:06 ` Tomi Valkeinen
2024-04-08 17:04 ` [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y Ville Syrjala
` (11 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Jyri Sarha, Tomi Valkeinen
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
__iowmb() isn't available on most architectures. Make
its use optional so that the driver can be built on
other architectures with COMPILE_TEST=y.
Cc: Jyri Sarha <jyri.sarha@iki.fi>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
index f90e2dc3457c..44e4ada30fba 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
+++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
@@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
#if defined(iowrite64) && !defined(iowrite64_is_nonatomic)
iowrite64(data, addr);
#else
+#ifdef __iowmb
__iowmb();
+#endif
/* This compiles to strd (=64-bit write) on ARM7 */
*(volatile u64 __force *)addr = __cpu_to_le64(data);
#endif
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (11 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 12/21] drm/tilcdc: Allow build without __iowmb() Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-10 9:06 ` Tomi Valkeinen
2024-04-08 17:04 ` [PATCH 14/21] drm/omap: Open code phys_to_page() Ville Syrjala
` (10 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Jyri Sarha, Tomi Valkeinen
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow tilcdc to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Jyri Sarha <jyri.sarha@iki.fi>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/tilcdc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
index d3bd2d7a181e..1897ef91c70b 100644
--- a/drivers/gpu/drm/tilcdc/Kconfig
+++ b/drivers/gpu/drm/tilcdc/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_TILCDC
tristate "DRM Support for TI LCDC Display Controller"
- depends on DRM && OF && ARM
+ depends on DRM && OF && (ARM || COMPILE_TEST)
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
select DRM_BRIDGE
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 14/21] drm/omap: Open code phys_to_page()
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (12 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-10 9:14 ` Tomi Valkeinen
2024-04-08 17:04 ` [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y Ville Syrjala
` (9 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Tomi Valkeinen
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
phys_to_page() is not available on most architectures.
Just open code it like msm does. Allows COMPILE_TEST=y
builds of omapdrm on other architectures.
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/omapdrm/omap_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index 3421e8389222..c4454e7f1c94 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -1022,8 +1022,8 @@ struct sg_table *omap_gem_get_sg(struct drm_gem_object *obj,
if (addr) {
for_each_sg(sgt->sgl, sg, count, i) {
- sg_set_page(sg, phys_to_page(addr), len,
- offset_in_page(addr));
+ sg_set_page(sg, pfn_to_page(__phys_to_pfn(addr)),
+ len, offset_in_page(addr));
sg_dma_address(sg) = addr;
sg_dma_len(sg) = len;
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (13 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 14/21] drm/omap: Open code phys_to_page() Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:12 ` Ville Syrjälä
2024-04-10 9:15 ` Tomi Valkeinen
2024-04-08 17:04 ` [PATCH 16/21] drm/atmel-hlcdc: " Ville Syrjala
` (8 subsequent siblings)
23 siblings, 2 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Tomi Valkeinen
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow omapdrm to be built with COMPILE_TEST=y for greater
coverage.
FIXME: Still borked due to ?
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/omapdrm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
index 6c49270cb290..85ed92042b74 100644
--- a/drivers/gpu/drm/omapdrm/Kconfig
+++ b/drivers/gpu/drm/omapdrm/Kconfig
@@ -2,7 +2,7 @@
config DRM_OMAP
tristate "OMAP DRM"
depends on DRM && OF
- depends on ARCH_OMAP2PLUS
+ depends on ARCH_OMAP2PLUS || COMPILE_TEST
select DRM_KMS_HELPER
select FB_DMAMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
select VIDEOMODE_HELPERS
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 16/21] drm/atmel-hlcdc: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (14 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-09 16:55 ` Sam Ravnborg
2024-04-08 17:04 ` [PATCH 17/21] drm/fsl-dcu: " Ville Syrjala
` (7 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Sam Ravnborg, Boris Brezillon
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow atmel-hlcdc to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Boris Brezillon <bbrezillon@kernel.org>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
index 3bdbab3a6333..945f3aa7bb24 100644
--- a/drivers/gpu/drm/atmel-hlcdc/Kconfig
+++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_ATMEL_HLCDC
tristate "DRM Support for ATMEL HLCDC Display Controller"
- depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM
+ depends on DRM && OF && COMMON_CLK && ((MFD_ATMEL_HLCDC && ARM) || COMPILE_TEST)
select DRM_GEM_DMA_HELPER
select DRM_KMS_HELPER
select DRM_PANEL
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 17/21] drm/fsl-dcu: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (15 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 16/21] drm/atmel-hlcdc: " Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 18/21] drm/mediatek: " Ville Syrjala
` (6 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Stefan Agner, Alison Wang
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow fsl-dcu to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Stefan Agner <stefan@agner.ch>
Cc: Alison Wang <alison.wang@nxp.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/fsl-dcu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
index 5ca71ef87325..9c9954a5e9bc 100644
--- a/drivers/gpu/drm/fsl-dcu/Kconfig
+++ b/drivers/gpu/drm/fsl-dcu/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_FSL_DCU
tristate "DRM Support for Freescale DCU"
- depends on DRM && OF && ARM && COMMON_CLK
+ depends on DRM && OF && (ARM || COMPILE_TEST) && COMMON_CLK
select BACKLIGHT_CLASS_DEVICE
select DRM_GEM_DMA_HELPER
select DRM_KMS_HELPER
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 18/21] drm/mediatek: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (16 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 17/21] drm/fsl-dcu: " Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:04 ` [PATCH 19/21] drm/meson: " Ville Syrjala
` (5 subsequent siblings)
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Chun-Kuang Hu, Philipp Zabel, linux-mediatek
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow mediatek to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/mediatek/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index 6caab8d4d4e0..d770936e238b 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -2,9 +2,9 @@
config DRM_MEDIATEK
tristate "DRM Support for Mediatek SoCs"
depends on DRM
- depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST)
+ depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST
depends on COMMON_CLK
- depends on HAVE_ARM_SMCCC
+ depends on HAVE_ARM_SMCCC || COMPILE_TEST
depends on OF
depends on MTK_MMSYS
select DRM_KMS_HELPER
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 19/21] drm/meson: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (17 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 18/21] drm/mediatek: " Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-08 17:23 ` Martin Blumenstingl
2024-04-08 17:04 ` [PATCH 20/21] drm/rcar-du: " Ville Syrjala
` (4 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Neil Armstrong, linux-amlogic
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow meson to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-amlogic@lists.infradead.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/meson/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/meson/Kconfig b/drivers/gpu/drm/meson/Kconfig
index 5520b9e3f010..d8f67bd9c755 100644
--- a/drivers/gpu/drm/meson/Kconfig
+++ b/drivers/gpu/drm/meson/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_MESON
tristate "DRM Support for Amlogic Meson Display Controller"
- depends on DRM && OF && (ARM || ARM64)
+ depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
depends on ARCH_MESON || COMPILE_TEST
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 20/21] drm/rcar-du: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (18 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 19/21] drm/meson: " Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-09 7:26 ` Geert Uytterhoeven
2024-04-10 22:36 ` Laurent Pinchart
2024-04-08 17:04 ` [PATCH 21/21] drm/stm: " Ville Syrjala
` (3 subsequent siblings)
23 siblings, 2 replies; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Laurent Pinchart, Kieran Bingham, linux-renesas-soc
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow rcar-du to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/renesas/rcar-du/Kconfig b/drivers/gpu/drm/renesas/rcar-du/Kconfig
index 2dc739db2ba3..df8b08b1e537 100644
--- a/drivers/gpu/drm/renesas/rcar-du/Kconfig
+++ b/drivers/gpu/drm/renesas/rcar-du/Kconfig
@@ -2,7 +2,7 @@
config DRM_RCAR_DU
tristate "DRM Support for R-Car Display Unit"
depends on DRM && OF
- depends on ARM || ARM64
+ depends on ARM || ARM64 || COMPILE_TEST
depends on ARCH_RENESAS || COMPILE_TEST
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* [PATCH 21/21] drm/stm: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (19 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 20/21] drm/rcar-du: " Ville Syrjala
@ 2024-04-08 17:04 ` Ville Syrjala
2024-04-10 12:15 ` Raphael Gallais-Pou
2024-04-10 6:07 ` [PATCH 12/21] drm/tilcdc: Allow build without __iowmb() sarha
` (2 subsequent siblings)
23 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjala @ 2024-04-08 17:04 UTC (permalink / raw)
To: dri-devel; +Cc: Yannick Fertre, Raphael Gallais-Pou, Philippe Cornu
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Allow stm to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Yannick Fertre <yannick.fertre@foss.st.com>
Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: Philippe Cornu <philippe.cornu@foss.st.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/stm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index fa49cde43bb2..4c906d602825 100644
--- a/drivers/gpu/drm/stm/Kconfig
+++ b/drivers/gpu/drm/stm/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_STM
tristate "DRM Support for STMicroelectronics SoC Series"
- depends on DRM && ARCH_STM32
+ depends on DRM && (ARCH_STM32 || COMPILE_TEST)
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
select DRM_PANEL_BRIDGE
--
2.43.2
^ permalink raw reply related [flat|nested] 44+ messages in thread
* Re: [PATCH 08/21] drm/hisilicon/kirin: Include linux/io.h for readl()/writel()
2024-04-08 17:04 ` [PATCH 08/21] drm/hisilicon/kirin: Include linux/io.h for readl()/writel() Ville Syrjala
@ 2024-04-08 17:08 ` John Stultz
0 siblings, 0 replies; 44+ messages in thread
From: John Stultz @ 2024-04-08 17:08 UTC (permalink / raw)
To: Ville Syrjala
Cc: dri-devel, Xinliang Liu, Tian Tao, Xinwei Kong, Sumit Semwal,
Yongqin Liu
On Mon, Apr 8, 2024 at 10:04 AM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Include linux/io.h for readl()/writel().
>
> When built on x86_64 w/ COMPILE_TEST=y:
> ../drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h:93:16: error: implicit declaration of function ‘readl’ [-Werror=implicit-function-declaration]
> 93 | orig = readl(addr);
> | ^~~~~
> ../drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h:96:9: error: implicit declaration of function ‘writel’ [-Werror=implicit-function-declaration]
> 96 | writel(tmp, addr);
> | ^~~~~~
>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Tian Tao <tiantao6@hisilicon.com>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Yongqin Liu <yongqin.liu@linaro.org>
> Cc: John Stultz <jstultz@google.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: John Stultz <jstultz@google.com>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 09/21] drm/hisilicon/kirin: Fix 64bit divisions
2024-04-08 17:04 ` [PATCH 09/21] drm/hisilicon/kirin: Fix 64bit divisions Ville Syrjala
@ 2024-04-08 17:09 ` John Stultz
0 siblings, 0 replies; 44+ messages in thread
From: John Stultz @ 2024-04-08 17:09 UTC (permalink / raw)
To: Ville Syrjala
Cc: dri-devel, Xinliang Liu, Tian Tao, Xinwei Kong, Sumit Semwal,
Yongqin Liu
On Mon, Apr 8, 2024 at 10:05 AM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Use the appropriate 64bit division helpers to make the code
> build on 32bit architectures.
>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Tian Tao <tiantao6@hisilicon.com>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Yongqin Liu <yongqin.liu@linaro.org>
> Cc: John Stultz <jstultz@google.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: John Stultz <jstultz@google.com>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 10/21] drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures
2024-04-08 17:04 ` [PATCH 10/21] drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures Ville Syrjala
@ 2024-04-08 17:09 ` John Stultz
0 siblings, 0 replies; 44+ messages in thread
From: John Stultz @ 2024-04-08 17:09 UTC (permalink / raw)
To: Ville Syrjala
Cc: dri-devel, Xinliang Liu, Tian Tao, Xinwei Kong, Sumit Semwal,
Yongqin Liu
On Mon, Apr 8, 2024 at 10:05 AM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> BIT(32) is illegal when sizeof(long)==4. Use BIT_ULL(32)
> instead.
>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Tian Tao <tiantao6@hisilicon.com>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Yongqin Liu <yongqin.liu@linaro.org>
> Cc: John Stultz <jstultz@google.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: John Stultz <jstultz@google.com>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 11/21] drm/hisilicon/kirin: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 11/21] drm/hisilicon/kirin: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-08 17:11 ` John Stultz
0 siblings, 0 replies; 44+ messages in thread
From: John Stultz @ 2024-04-08 17:11 UTC (permalink / raw)
To: Ville Syrjala
Cc: dri-devel, Xinliang Liu, Tian Tao, Xinwei Kong, Sumit Semwal,
Yongqin Liu
On Mon, Apr 8, 2024 at 10:05 AM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow kirin to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Xinliang Liu <xinliang.liu@linaro.org>
> Cc: Tian Tao <tiantao6@hisilicon.com>
> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Yongqin Liu <yongqin.liu@linaro.org>
> Cc: John Stultz <jstultz@google.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: John Stultz <jstultz@google.com>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-08 17:12 ` Ville Syrjälä
2024-04-10 9:15 ` Tomi Valkeinen
1 sibling, 0 replies; 44+ messages in thread
From: Ville Syrjälä @ 2024-04-08 17:12 UTC (permalink / raw)
To: dri-devel; +Cc: Tomi Valkeinen
On Mon, Apr 08, 2024 at 08:04:20PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow omapdrm to be built with COMPILE_TEST=y for greater
> coverage.
>
> FIXME: Still borked due to ?
In fact not borked anymore. Just forgot to update
the commit message.
>
> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/omapdrm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index 6c49270cb290..85ed92042b74 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -2,7 +2,7 @@
> config DRM_OMAP
> tristate "OMAP DRM"
> depends on DRM && OF
> - depends on ARCH_OMAP2PLUS
> + depends on ARCH_OMAP2PLUS || COMPILE_TEST
> select DRM_KMS_HELPER
> select FB_DMAMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
> select VIDEOMODE_HELPERS
> --
> 2.43.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 19/21] drm/meson: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 19/21] drm/meson: " Ville Syrjala
@ 2024-04-08 17:23 ` Martin Blumenstingl
0 siblings, 0 replies; 44+ messages in thread
From: Martin Blumenstingl @ 2024-04-08 17:23 UTC (permalink / raw)
To: Ville Syrjala; +Cc: dri-devel, Neil Armstrong, linux-amlogic
On Mon, Apr 8, 2024 at 7:05 PM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow meson to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: linux-amlogic@lists.infradead.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thank you for spotting this Ville!
> ---
> drivers/gpu/drm/meson/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/meson/Kconfig b/drivers/gpu/drm/meson/Kconfig
> index 5520b9e3f010..d8f67bd9c755 100644
> --- a/drivers/gpu/drm/meson/Kconfig
> +++ b/drivers/gpu/drm/meson/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_MESON
> tristate "DRM Support for Amlogic Meson Display Controller"
> - depends on DRM && OF && (ARM || ARM64)
> + depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST)
Neil, I wonder if we should just have "depends on DRM && OF" here as
the next line already has:
> depends on ARCH_MESON || COMPILE_TEST
ARCH_MESON is only defined for ARM and ARM64
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 20/21] drm/rcar-du: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 20/21] drm/rcar-du: " Ville Syrjala
@ 2024-04-09 7:26 ` Geert Uytterhoeven
2024-04-10 22:36 ` Laurent Pinchart
1 sibling, 0 replies; 44+ messages in thread
From: Geert Uytterhoeven @ 2024-04-09 7:26 UTC (permalink / raw)
To: Ville Syrjala
Cc: dri-devel, Laurent Pinchart, Kieran Bingham, linux-renesas-soc
On Mon, Apr 8, 2024 at 7:05 PM Ville Syrjala
<ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow rcar-du to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
Also on rv64 and m68k.
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 16/21] drm/atmel-hlcdc: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 16/21] drm/atmel-hlcdc: " Ville Syrjala
@ 2024-04-09 16:55 ` Sam Ravnborg
0 siblings, 0 replies; 44+ messages in thread
From: Sam Ravnborg @ 2024-04-09 16:55 UTC (permalink / raw)
To: Ville Syrjala; +Cc: dri-devel, Boris Brezillon
On Mon, Apr 08, 2024 at 08:04:21PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow atmel-hlcdc to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Boris Brezillon <bbrezillon@kernel.org>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/atmel-hlcdc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/Kconfig b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> index 3bdbab3a6333..945f3aa7bb24 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/Kconfig
> +++ b/drivers/gpu/drm/atmel-hlcdc/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_ATMEL_HLCDC
> tristate "DRM Support for ATMEL HLCDC Display Controller"
> - depends on DRM && OF && COMMON_CLK && MFD_ATMEL_HLCDC && ARM
> + depends on DRM && OF && COMMON_CLK && ((MFD_ATMEL_HLCDC && ARM) || COMPILE_TEST)
> select DRM_GEM_DMA_HELPER
> select DRM_KMS_HELPER
> select DRM_PANEL
> --
> 2.43.2
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (20 preceding siblings ...)
2024-04-08 17:04 ` [PATCH 21/21] drm/stm: " Ville Syrjala
@ 2024-04-10 6:07 ` sarha
2024-04-10 6:07 ` [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y sarha
2024-05-08 19:40 ` [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjälä
23 siblings, 0 replies; 44+ messages in thread
From: sarha @ 2024-04-10 6:07 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: Jyri Sarha, Tomi Valkeinen
April 8, 2024 at 8:04 PM, "Ville Syrjala" <ville.syrjala@linux.intel.com mailto:ville.syrjala@linux.intel.com?to=%22Ville%20Syrjala%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> __iowmb() isn't available on most architectures. Make
> its use optional so that the driver can be built on
> other architectures with COMPILE_TEST=y.
>
> Cc: Jyri Sarha <jyri.sarha@iki.fi>
> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Jyri Sarha <jyri.sarha@iki.fi>
Thanks,
Jyri
> ---
> drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> index f90e2dc3457c..44e4ada30fba 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> @@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
> #if defined(iowrite64) !defined(iowrite64_is_nonatomic)
> iowrite64(data, addr);
> #else
> +#ifdef __iowmb
> __iowmb();
> +#endif
> /* This compiles to strd (=64-bit write) on ARM7 */
> *(volatile u64 __force *)addr = __cpu_to_le64(data);
> #endif
> --
> 2.43.2
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (21 preceding siblings ...)
2024-04-10 6:07 ` [PATCH 12/21] drm/tilcdc: Allow build without __iowmb() sarha
@ 2024-04-10 6:07 ` sarha
2024-05-08 19:40 ` [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjälä
23 siblings, 0 replies; 44+ messages in thread
From: sarha @ 2024-04-10 6:07 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: Jyri Sarha, Tomi Valkeinen
April 8, 2024 at 8:04 PM, "Ville Syrjala" <ville.syrjala@linux.intel.com mailto:ville.syrjala@linux.intel.com?to=%22Ville%20Syrjala%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote:
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow tilcdc to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Jyri Sarha <jyri.sarha@iki.fi>
> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Jyri Sarha <jyri.sarha@iki.fi>
Thanks,
Jyri
> ---
> drivers/gpu/drm/tilcdc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
> index d3bd2d7a181e..1897ef91c70b 100644
> --- a/drivers/gpu/drm/tilcdc/Kconfig
> +++ b/drivers/gpu/drm/tilcdc/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_TILCDC
> tristate "DRM Support for TI LCDC Display Controller"
> - depends on DRM OF && ARM
> + depends on DRM && OF && (ARM || COMPILE_TEST)
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
> select DRM_BRIDGE
> --
> 2.43.2
>
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()
2024-04-08 17:04 ` [PATCH 12/21] drm/tilcdc: Allow build without __iowmb() Ville Syrjala
@ 2024-04-10 9:06 ` Tomi Valkeinen
2024-04-10 15:25 ` Ville Syrjälä
0 siblings, 1 reply; 44+ messages in thread
From: Tomi Valkeinen @ 2024-04-10 9:06 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: Jyri Sarha
On 08/04/2024 20:04, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> __iowmb() isn't available on most architectures. Make
> its use optional so that the driver can be built on
> other architectures with COMPILE_TEST=y.
>
> Cc: Jyri Sarha <jyri.sarha@iki.fi>
> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> index f90e2dc3457c..44e4ada30fba 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> @@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
> #if defined(iowrite64) && !defined(iowrite64_is_nonatomic)
> iowrite64(data, addr);
> #else
> +#ifdef __iowmb
> __iowmb();
> +#endif
> /* This compiles to strd (=64-bit write) on ARM7 */
> *(volatile u64 __force *)addr = __cpu_to_le64(data);
> #endif
As the memory barrier is an important part there, would it be better to
ifdef based on COMPILE_TEST, to make it clear why it's being done?
Tomi
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y Ville Syrjala
@ 2024-04-10 9:06 ` Tomi Valkeinen
0 siblings, 0 replies; 44+ messages in thread
From: Tomi Valkeinen @ 2024-04-10 9:06 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: Jyri Sarha
On 08/04/2024 20:04, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow tilcdc to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Jyri Sarha <jyri.sarha@iki.fi>
> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/tilcdc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
> index d3bd2d7a181e..1897ef91c70b 100644
> --- a/drivers/gpu/drm/tilcdc/Kconfig
> +++ b/drivers/gpu/drm/tilcdc/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_TILCDC
> tristate "DRM Support for TI LCDC Display Controller"
> - depends on DRM && OF && ARM
> + depends on DRM && OF && (ARM || COMPILE_TEST)
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
> select DRM_BRIDGE
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 14/21] drm/omap: Open code phys_to_page()
2024-04-08 17:04 ` [PATCH 14/21] drm/omap: Open code phys_to_page() Ville Syrjala
@ 2024-04-10 9:14 ` Tomi Valkeinen
0 siblings, 0 replies; 44+ messages in thread
From: Tomi Valkeinen @ 2024-04-10 9:14 UTC (permalink / raw)
To: Ville Syrjala, dri-devel
On 08/04/2024 20:04, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> phys_to_page() is not available on most architectures.
> Just open code it like msm does. Allows COMPILE_TEST=y
> builds of omapdrm on other architectures.
>
> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/omapdrm/omap_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index 3421e8389222..c4454e7f1c94 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -1022,8 +1022,8 @@ struct sg_table *omap_gem_get_sg(struct drm_gem_object *obj,
>
> if (addr) {
> for_each_sg(sgt->sgl, sg, count, i) {
> - sg_set_page(sg, phys_to_page(addr), len,
> - offset_in_page(addr));
> + sg_set_page(sg, pfn_to_page(__phys_to_pfn(addr)),
> + len, offset_in_page(addr));
> sg_dma_address(sg) = addr;
> sg_dma_len(sg) = len;
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-08 17:12 ` Ville Syrjälä
@ 2024-04-10 9:15 ` Tomi Valkeinen
1 sibling, 0 replies; 44+ messages in thread
From: Tomi Valkeinen @ 2024-04-10 9:15 UTC (permalink / raw)
To: Ville Syrjala, dri-devel
On 08/04/2024 20:04, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow omapdrm to be built with COMPILE_TEST=y for greater
> coverage.
>
> FIXME: Still borked due to ?
>
> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/omapdrm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index 6c49270cb290..85ed92042b74 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -2,7 +2,7 @@
> config DRM_OMAP
> tristate "OMAP DRM"
> depends on DRM && OF
> - depends on ARCH_OMAP2PLUS
> + depends on ARCH_OMAP2PLUS || COMPILE_TEST
> select DRM_KMS_HELPER
> select FB_DMAMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
> select VIDEOMODE_HELPERS
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 21/21] drm/stm: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 21/21] drm/stm: " Ville Syrjala
@ 2024-04-10 12:15 ` Raphael Gallais-Pou
0 siblings, 0 replies; 44+ messages in thread
From: Raphael Gallais-Pou @ 2024-04-10 12:15 UTC (permalink / raw)
To: Ville Syrjala, dri-devel; +Cc: Yannick Fertre, Philippe Cornu
Hi Ville
On 4/8/24 19:04, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow stm to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Yannick Fertre <yannick.fertre@foss.st.com>
> Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> Cc: Philippe Cornu <philippe.cornu@foss.st.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thank you for this ! :)
Acked-by: Raphaël Gallais-Pou <raphael.gallais-pou@foss.st.com>
> ---
> drivers/gpu/drm/stm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
> index fa49cde43bb2..4c906d602825 100644
> --- a/drivers/gpu/drm/stm/Kconfig
> +++ b/drivers/gpu/drm/stm/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config DRM_STM
> tristate "DRM Support for STMicroelectronics SoC Series"
> - depends on DRM && ARCH_STM32
> + depends on DRM && (ARCH_STM32 || COMPILE_TEST)
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
> select DRM_PANEL_BRIDGE
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()
2024-04-10 9:06 ` Tomi Valkeinen
@ 2024-04-10 15:25 ` Ville Syrjälä
2024-04-10 15:47 ` Tomi Valkeinen
` (2 more replies)
0 siblings, 3 replies; 44+ messages in thread
From: Ville Syrjälä @ 2024-04-10 15:25 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: dri-devel, Jyri Sarha
On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote:
> On 08/04/2024 20:04, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > __iowmb() isn't available on most architectures. Make
> > its use optional so that the driver can be built on
> > other architectures with COMPILE_TEST=y.
> >
> > Cc: Jyri Sarha <jyri.sarha@iki.fi>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> > index f90e2dc3457c..44e4ada30fba 100644
> > --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> > +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> > @@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
> > #if defined(iowrite64) && !defined(iowrite64_is_nonatomic)
> > iowrite64(data, addr);
> > #else
> > +#ifdef __iowmb
> > __iowmb();
> > +#endif
> > /* This compiles to strd (=64-bit write) on ARM7 */
> > *(volatile u64 __force *)addr = __cpu_to_le64(data);
> > #endif
>
> As the memory barrier is an important part there, would it be better to
> ifdef based on COMPILE_TEST, to make it clear why it's being done?
I can do that if you prefer.
I suppose the real question is why iowrite64() doesn't work
if a hand rolled version does work?
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()
2024-04-10 15:25 ` Ville Syrjälä
@ 2024-04-10 15:47 ` Tomi Valkeinen
2024-04-10 17:04 ` Ville Syrjälä
2024-04-11 13:40 ` jyri.sarha
2 siblings, 0 replies; 44+ messages in thread
From: Tomi Valkeinen @ 2024-04-10 15:47 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: dri-devel, Jyri Sarha
On 10/04/2024 18:25, Ville Syrjälä wrote:
> On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote:
>> On 08/04/2024 20:04, Ville Syrjala wrote:
>>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>
>>> __iowmb() isn't available on most architectures. Make
>>> its use optional so that the driver can be built on
>>> other architectures with COMPILE_TEST=y.
>>>
>>> Cc: Jyri Sarha <jyri.sarha@iki.fi>
>>> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> ---
>>> drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
>>> index f90e2dc3457c..44e4ada30fba 100644
>>> --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
>>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
>>> @@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
>>> #if defined(iowrite64) && !defined(iowrite64_is_nonatomic)
>>> iowrite64(data, addr);
>>> #else
>>> +#ifdef __iowmb
>>> __iowmb();
>>> +#endif
>>> /* This compiles to strd (=64-bit write) on ARM7 */
>>> *(volatile u64 __force *)addr = __cpu_to_le64(data);
>>> #endif
>>
>> As the memory barrier is an important part there, would it be better to
>> ifdef based on COMPILE_TEST, to make it clear why it's being done?
>
> I can do that if you prefer.
>
> I suppose the real question is why iowrite64() doesn't work
> if a hand rolled version does work?
If I recall right, there is (was?) no iowrite64. The bus is 32 bit
anyway. But the two 32 bit registers written with the tilcdc_write64()
have an annoying HW race, so we tried to find a method of writing them
that reduces the chance of race to a minimum.
Tomi
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()
2024-04-10 15:25 ` Ville Syrjälä
2024-04-10 15:47 ` Tomi Valkeinen
@ 2024-04-10 17:04 ` Ville Syrjälä
2024-04-10 17:12 ` Tomi Valkeinen
2024-04-11 13:40 ` jyri.sarha
2 siblings, 1 reply; 44+ messages in thread
From: Ville Syrjälä @ 2024-04-10 17:04 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: dri-devel, Jyri Sarha
On Wed, Apr 10, 2024 at 06:25:17PM +0300, Ville Syrjälä wrote:
> On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote:
> > On 08/04/2024 20:04, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > __iowmb() isn't available on most architectures. Make
> > > its use optional so that the driver can be built on
> > > other architectures with COMPILE_TEST=y.
> > >
> > > Cc: Jyri Sarha <jyri.sarha@iki.fi>
> > > Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> > > index f90e2dc3457c..44e4ada30fba 100644
> > > --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> > > +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
> > > @@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
> > > #if defined(iowrite64) && !defined(iowrite64_is_nonatomic)
> > > iowrite64(data, addr);
> > > #else
> > > +#ifdef __iowmb
> > > __iowmb();
> > > +#endif
> > > /* This compiles to strd (=64-bit write) on ARM7 */
> > > *(volatile u64 __force *)addr = __cpu_to_le64(data);
> > > #endif
> >
> > As the memory barrier is an important part there, would it be better to
> > ifdef based on COMPILE_TEST, to make it clear why it's being done?
>
> I can do that if you prefer.
What if someone tries to actually boot a kernel built
with COMPILE_TEST=y on a machine with this hardware?
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()
2024-04-10 17:04 ` Ville Syrjälä
@ 2024-04-10 17:12 ` Tomi Valkeinen
0 siblings, 0 replies; 44+ messages in thread
From: Tomi Valkeinen @ 2024-04-10 17:12 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: dri-devel, Jyri Sarha
On 10/04/2024 20:04, Ville Syrjälä wrote:
> On Wed, Apr 10, 2024 at 06:25:17PM +0300, Ville Syrjälä wrote:
>> On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote:
>>> On 08/04/2024 20:04, Ville Syrjala wrote:
>>>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>>
>>>> __iowmb() isn't available on most architectures. Make
>>>> its use optional so that the driver can be built on
>>>> other architectures with COMPILE_TEST=y.
>>>>
>>>> Cc: Jyri Sarha <jyri.sarha@iki.fi>
>>>> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>>>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>>> ---
>>>> drivers/gpu/drm/tilcdc/tilcdc_regs.h | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_regs.h b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
>>>> index f90e2dc3457c..44e4ada30fba 100644
>>>> --- a/drivers/gpu/drm/tilcdc/tilcdc_regs.h
>>>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_regs.h
>>>> @@ -125,7 +125,9 @@ static inline void tilcdc_write64(struct drm_device *dev, u32 reg, u64 data)
>>>> #if defined(iowrite64) && !defined(iowrite64_is_nonatomic)
>>>> iowrite64(data, addr);
>>>> #else
>>>> +#ifdef __iowmb
>>>> __iowmb();
>>>> +#endif
>>>> /* This compiles to strd (=64-bit write) on ARM7 */
>>>> *(volatile u64 __force *)addr = __cpu_to_le64(data);
>>>> #endif
>>>
>>> As the memory barrier is an important part there, would it be better to
>>> ifdef based on COMPILE_TEST, to make it clear why it's being done?
>>
>> I can do that if you prefer.
>
> What if someone tries to actually boot a kernel built
> with COMPILE_TEST=y on a machine with this hardware?
Ah, right...
#ifndef __iowmb
#define __iowmb BUG
#endif
? =)
Maybe go with the original one, but with a comment like "allow
compilation without __iowmb() for COMPILE_TEST" or such.
Tomi
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 20/21] drm/rcar-du: Allow build with COMPILE_TEST=y
2024-04-08 17:04 ` [PATCH 20/21] drm/rcar-du: " Ville Syrjala
2024-04-09 7:26 ` Geert Uytterhoeven
@ 2024-04-10 22:36 ` Laurent Pinchart
1 sibling, 0 replies; 44+ messages in thread
From: Laurent Pinchart @ 2024-04-10 22:36 UTC (permalink / raw)
To: Ville Syrjala; +Cc: dri-devel, Kieran Bingham, linux-renesas-soc
Hi Ville,
Thank you for the patch.
On Mon, Apr 08, 2024 at 08:04:25PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow rcar-du to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/Kconfig b/drivers/gpu/drm/renesas/rcar-du/Kconfig
> index 2dc739db2ba3..df8b08b1e537 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/renesas/rcar-du/Kconfig
> @@ -2,7 +2,7 @@
> config DRM_RCAR_DU
> tristate "DRM Support for R-Car Display Unit"
> depends on DRM && OF
> - depends on ARM || ARM64
> + depends on ARM || ARM64 || COMPILE_TEST
I'll trust 0-day to tell us if this causes any issue on exotic (from the
R-Car DU driver's point of view) platforms.
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
I expect you to push this patch, please let me know if you don't intend
to.
> depends on ARCH_RENESAS || COMPILE_TEST
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()
2024-04-10 15:25 ` Ville Syrjälä
2024-04-10 15:47 ` Tomi Valkeinen
2024-04-10 17:04 ` Ville Syrjälä
@ 2024-04-11 13:40 ` jyri.sarha
2 siblings, 0 replies; 44+ messages in thread
From: jyri.sarha @ 2024-04-11 13:40 UTC (permalink / raw)
To: Ville Syrjälä, Tomi Valkeinen; +Cc: dri-devel, Jyri Sarha
April 10, 2024 at 8:04 PM, "Ville Syrjälä" <ville.syrjala@linux.intel.com mailto:ville.syrjala@linux.intel.com?to=%22Ville%20Syrj%C3%A4l%C3%A4%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote:
>
> What if someone tries to actually boot a kernel built
> with COMPILE_TEST=y on a machine with this hardware?
>
I doubt there is am335x HW out there with enough memory to load COMPILE_TEST=y kernel.
BR,
Jyri
^ permalink raw reply [flat|nested] 44+ messages in thread
* Re: [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
` (22 preceding siblings ...)
2024-04-10 6:07 ` [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y sarha
@ 2024-05-08 19:40 ` Ville Syrjälä
23 siblings, 0 replies; 44+ messages in thread
From: Ville Syrjälä @ 2024-05-08 19:40 UTC (permalink / raw)
To: dri-devel
On Mon, Apr 08, 2024 at 08:04:05PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I got fed up having to build multiple architectures when
> doing subsystem wide refactoring. So I decided to attack
> the low hanging COMPILE_TEST=y fruit. Here are the
> results. All of these drivers now build with COMPILE_TEST=y
> on x86/x86_64
>
> Ville Syrjälä (21):
> drm/hisilicon/kirin: Include linux/io.h for readl()/writel()
> drm/hisilicon/kirin: Fix 64bit divisions
> drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures
> drm/hisilicon/kirin: Allow build with COMPILE_TEST=y
> drm/omap: Open code phys_to_page()
> drm/omap: Allow build with COMPILE_TEST=y
> drm/atmel-hlcdc: Allow build with COMPILE_TEST=y
> drm/rcar-du: Allow build with COMPILE_TEST=y
> drm/stm: Allow build with COMPILE_TEST=y
^ pushed to drm-misc-next. Thanks for the reviews.
> drm/armada: Fix printk arguments
> drm/armada: Fix armada_debugfs_crtc_reg_write() return type
> drm/armada: Allow build with COMPILE_TEST=y
> drm/imx/dcss: Fix 64bit divisions
> drm/imx/dcss: Allow build with COMPILE_TEST=y
> drm/sti: Include linux/io.h for devm_ioremap()
> drm/sti: Allow build with COMPILE_TEST=y
> drm/fsl-dcu: Allow build with COMPILE_TEST=y
> drm/mediatek: Allow build with COMPILE_TEST=y
> drm/meson: Allow build with COMPILE_TEST=y
^ are all still without comments.
> drm/tilcdc: Allow build without __iowmb()
> drm/tilcdc: Allow build with COMPILE_TEST=y
^ I need to respin.
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 44+ messages in thread
end of thread, other threads:[~2024-05-08 19:40 UTC | newest]
Thread overview: 44+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-08 17:04 [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
2024-04-08 17:04 ` [PATCH 01/21] drm/armada: Fix printk arguments Ville Syrjala
2024-04-08 17:04 ` [PATCH 02/21] drm/armada: Fix armada_debugfs_crtc_reg_write() return type Ville Syrjala
2024-04-08 17:04 ` [PATCH 03/21] drm/armada: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-08 17:04 ` [PATCH 04/21] drm/imx/dcss: Fix 64bit divisions Ville Syrjala
2024-04-08 17:04 ` [PATCH 05/21] drm/imx/dcss: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-08 17:04 ` [PATCH 06/21] drm/sti: Include linux/io.h for devm_ioremap() Ville Syrjala
2024-04-08 17:04 ` [PATCH 07/21] drm/sti: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-08 17:04 ` [PATCH 08/21] drm/hisilicon/kirin: Include linux/io.h for readl()/writel() Ville Syrjala
2024-04-08 17:08 ` John Stultz
2024-04-08 17:04 ` [PATCH 09/21] drm/hisilicon/kirin: Fix 64bit divisions Ville Syrjala
2024-04-08 17:09 ` John Stultz
2024-04-08 17:04 ` [PATCH 10/21] drm/hisilicon/kirin: Fix MASK(32) on 32bit architectures Ville Syrjala
2024-04-08 17:09 ` John Stultz
2024-04-08 17:04 ` [PATCH 11/21] drm/hisilicon/kirin: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-08 17:11 ` John Stultz
2024-04-08 17:04 ` [PATCH 12/21] drm/tilcdc: Allow build without __iowmb() Ville Syrjala
2024-04-10 9:06 ` Tomi Valkeinen
2024-04-10 15:25 ` Ville Syrjälä
2024-04-10 15:47 ` Tomi Valkeinen
2024-04-10 17:04 ` Ville Syrjälä
2024-04-10 17:12 ` Tomi Valkeinen
2024-04-11 13:40 ` jyri.sarha
2024-04-08 17:04 ` [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-10 9:06 ` Tomi Valkeinen
2024-04-08 17:04 ` [PATCH 14/21] drm/omap: Open code phys_to_page() Ville Syrjala
2024-04-10 9:14 ` Tomi Valkeinen
2024-04-08 17:04 ` [PATCH 15/21] drm/omap: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-08 17:12 ` Ville Syrjälä
2024-04-10 9:15 ` Tomi Valkeinen
2024-04-08 17:04 ` [PATCH 16/21] drm/atmel-hlcdc: " Ville Syrjala
2024-04-09 16:55 ` Sam Ravnborg
2024-04-08 17:04 ` [PATCH 17/21] drm/fsl-dcu: " Ville Syrjala
2024-04-08 17:04 ` [PATCH 18/21] drm/mediatek: " Ville Syrjala
2024-04-08 17:04 ` [PATCH 19/21] drm/meson: " Ville Syrjala
2024-04-08 17:23 ` Martin Blumenstingl
2024-04-08 17:04 ` [PATCH 20/21] drm/rcar-du: " Ville Syrjala
2024-04-09 7:26 ` Geert Uytterhoeven
2024-04-10 22:36 ` Laurent Pinchart
2024-04-08 17:04 ` [PATCH 21/21] drm/stm: " Ville Syrjala
2024-04-10 12:15 ` Raphael Gallais-Pou
2024-04-10 6:07 ` [PATCH 12/21] drm/tilcdc: Allow build without __iowmb() sarha
2024-04-10 6:07 ` [PATCH 13/21] drm/tilcdc: Allow build with COMPILE_TEST=y sarha
2024-05-08 19:40 ` [PATCH 00/21] drm: Increase COMPILE_TEST=y coverage Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).