From: Simon Ser <contact@emersion.fr>
To: Albert Esteve <aesteve@redhat.com>
Cc: linux-doc@vger.kernel.org, qemu-devel@nongnu.org,
banackm@vmware.com, virtualization@lists.linux-foundation.org,
Gerd Hoffmann <kraxel@redhat.com>,
mombasawalam@vmware.com, iforbes@vmware.com,
Jonathan Corbet <corbet@lwn.net>,
javierm@redhat.com,
VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>,
David Airlie <airlied@redhat.com>,
Maxime Ripard <mripard@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
ppaalanen@gmail.com, dri-devel@lists.freedesktop.org,
spice-devel@lists.freedesktop.org,
Gurchetan Singh <gurchetansingh@chromium.org>,
Matt Roper <matthew.d.roper@intel.com>,
linux-kernel@vger.kernel.org, krastevm@vmware.com,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v6 0/9] Fix cursor planes with virtualized drivers
Date: Mon, 23 Oct 2023 08:19:05 +0000 [thread overview]
Message-ID: <219B7sJmmuzo8lj-2i5F6y0pc8XM03X6NdxHUq_R76N71AcTptEPcpjKLO9Rutriw88YtJDRNqibuR-YICIkhPnrBnQSM-Uu9YCc2uZoOiM=@emersion.fr> (raw)
In-Reply-To: <CADSE00KW4+hpbAbZAusBngq5FYSa067wYJCGeetqngWRJaD9Kg@mail.gmail.com>
On Monday, October 23rd, 2023 at 10:14, Albert Esteve <aesteve@redhat.com> wrote:
> On Mon, Oct 23, 2023 at 9:55 AM Simon Ser <contact@emersion.fr> wrote:
>
> > On Monday, October 23rd, 2023 at 09:46, Albert Esteve <aesteve@redhat.com> wrote:
> >
> > > Link to the IGT test covering this patch (already merged):
> > > https://lists.freedesktop.org/archives/igt-dev/2023-July/058427.html
> >
> > Hmm. IGT should not be merged before the kernel, because as long as the
> > kernel is not merged there might be some uAPI changes.
>
> Right, but uAPI header was not updated on the IGT side. As per suggestion of the
> maintainers, I added a static variable that matches the definition on this patch:
> https://lists.freedesktop.org/archives/igt-dev/2023-August/058803.html
>
> +/**
> + * Clients which do set cursor hotspot and treat the cursor plane
> + * like a mouse cursor should set this property.
> + */
> +#define LOCAL_DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT 6
>
> Once this patch gets upstreamed, the localized definition will be removed,
> replaced by the real one.
What if this patch gets delayed and another patch using the same number
is merged into the kernel first? What if someone finds a design flaw in
the uAPI and it needs to be completely changed? The IGT test would then
be completely broken.
As a rule of thumb: never merge user-space patches before kernel. As
soon as the kernel part is merged, it's fine to locally copy definitions
if desirable.
> > > Mutter patch:
> > > https://lists.freedesktop.org/archives/igt-dev/2023-July/058427.html
> >
> > Seems like this link is same as IGT? Copy-pasta fail maybe?
>
> Ah yes, my bad, this is the correct link:
> https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3337
Thanks!
next prev parent reply other threads:[~2023-10-23 8:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 7:46 [PATCH v6 0/9] Fix cursor planes with virtualized drivers Albert Esteve
2023-10-23 7:46 ` [PATCH v6 1/9] drm: Disable the cursor plane on atomic contexts " Albert Esteve
2023-10-23 7:53 ` Simon Ser
2023-10-23 7:46 ` [PATCH v6 2/9] drm/atomic: Add support for mouse hotspots Albert Esteve
2023-10-23 7:46 ` [PATCH v6 3/9] drm/vmwgfx: Use the hotspot properties from cursor planes Albert Esteve
2023-10-23 7:46 ` [PATCH v6 4/9] drm/qxl: " Albert Esteve
2023-10-23 7:46 ` [PATCH v6 5/9] drm/vboxvideo: " Albert Esteve
2023-10-23 7:46 ` [PATCH v6 6/9] drm/virtio: " Albert Esteve
2023-10-23 7:46 ` [PATCH v6 7/9] drm: Remove legacy cursor hotspot code Albert Esteve
2023-10-23 7:46 ` [PATCH v6 8/9] drm: Introduce DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT Albert Esteve
2023-10-23 7:46 ` [PATCH v6 9/9] drm: Introduce documentation for hotspot properties Albert Esteve
2023-10-23 8:23 ` Pekka Paalanen
2023-10-23 21:29 ` Javier Martinez Canillas
2023-10-24 19:34 ` Michael Banack
2023-10-25 6:36 ` Javier Martinez Canillas
2023-10-23 7:55 ` [PATCH v6 0/9] Fix cursor planes with virtualized drivers Simon Ser
2023-10-23 8:14 ` Albert Esteve
2023-10-23 8:19 ` Simon Ser [this message]
2023-11-22 12:49 ` Javier Martinez Canillas
2023-11-23 22:11 ` Simon Ser
2023-11-24 10:56 ` Javier Martinez Canillas
2023-11-24 14:41 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='219B7sJmmuzo8lj-2i5F6y0pc8XM03X6NdxHUq_R76N71AcTptEPcpjKLO9Rutriw88YtJDRNqibuR-YICIkhPnrBnQSM-Uu9YCc2uZoOiM=@emersion.fr' \
--to=contact@emersion.fr \
--cc=aesteve@redhat.com \
--cc=airlied@redhat.com \
--cc=banackm@vmware.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=hdegoede@redhat.com \
--cc=iforbes@vmware.com \
--cc=javierm@redhat.com \
--cc=krastevm@vmware.com \
--cc=kraxel@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.d.roper@intel.com \
--cc=mombasawalam@vmware.com \
--cc=mripard@kernel.org \
--cc=ppaalanen@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).