From: Liu Ying <victor.liu@nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: s.hauer@pengutronix.de, stable@vger.kernel.org,
p.zable@pengutronix.de, dri-devel@lists.freedesktop.org,
kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH] drm/imx: imx-ldb: Disable both channels for split mode in enc->disable()
Date: Thu, 28 May 2020 18:02:53 +0800 [thread overview]
Message-ID: <31843bf5ba23d0693cab85fdbb5e3ee8a7453527.camel@nxp.com> (raw)
In-Reply-To: <20200528093145.kmpzbnesv25k7wvc@pengutronix.de>
Hi Marco,
On Thu, 2020-05-28 at 11:31 +0200, Marco Felsch wrote:
> Hi Liu
>
> On 20-05-28 10:58, Liu Ying wrote:
> > Gentle ping...
>
> Please check my "spring cleanup series" [1] which do the split:
It looks that your series doesn't disable both lvds channels in the
encoder disablement callback for the ldb split mode.
So, I think this patch still stands.
Regards,
Liu Ying
>
> [1]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Farm-kernel%2Fmsg789309.html&data=02%7C01%7Cvictor.liu%40nxp.com%7Cd177bf874b8f41c404e108d802e9f179%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637262551086663318&sdata=PIMNspESt%2BYqEMV1Vh0eBn5PNjKPfz5GdJ6NrnM2bUw%3D&reserved=0
>
> Regards,
> Marco
>
> > On Tue, 2020-05-12 at 15:31 +0800, Liu Ying wrote:
> > > Both of the two LVDS channels should be disabled for split mode
> > > in the encoder's ->disable() callback, because they are enabled
> > > in the encoder's ->enable() callback.
> > >
> > > Fixes: 6556f7f82b9c ("drm: imx: Move imx-drm driver out of
> > > staging")
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > > Cc: NXP Linux Team <linux-imx@nxp.com>
> > > Cc: <stable@vger.kernel.org>
> > > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > > ---
> > > drivers/gpu/drm/imx/imx-ldb.c | 7 ++++---
> > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/imx/imx-ldb.c
> > > b/drivers/gpu/drm/imx/imx-
> > > ldb.c
> > > index 4da22a9..af4d0d8 100644
> > > --- a/drivers/gpu/drm/imx/imx-ldb.c
> > > +++ b/drivers/gpu/drm/imx/imx-ldb.c
> > > @@ -303,18 +303,19 @@ static void imx_ldb_encoder_disable(struct
> > > drm_encoder *encoder)
> > > {
> > > struct imx_ldb_channel *imx_ldb_ch =
> > > enc_to_imx_ldb_ch(encoder);
> > > struct imx_ldb *ldb = imx_ldb_ch->ldb;
> > > + int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN;
> > > int mux, ret;
> > >
> > > drm_panel_disable(imx_ldb_ch->panel);
> > >
> > > - if (imx_ldb_ch == &ldb->channel[0])
> > > + if (imx_ldb_ch == &ldb->channel[0] || dual)
> > > ldb->ldb_ctrl &= ~LDB_CH0_MODE_EN_MASK;
> > > - else if (imx_ldb_ch == &ldb->channel[1])
> > > + if (imx_ldb_ch == &ldb->channel[1] || dual)
> > > ldb->ldb_ctrl &= ~LDB_CH1_MODE_EN_MASK;
> > >
> > > regmap_write(ldb->regmap, IOMUXC_GPR2, ldb->ldb_ctrl);
> > >
> > > - if (ldb->ldb_ctrl & LDB_SPLIT_MODE_EN) {
> > > + if (dual) {
> > > clk_disable_unprepare(ldb->clk[0]);
> > > clk_disable_unprepare(ldb->clk[1]);
> > > }
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cvictor.liu%40nxp.com%7Cd177bf874b8f41c404e108d802e9f179%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637262551086663318&sdata=lNC4lwLUqM0upUxrrBtk1ap423lBIQlAAqDjdHv92LI%3D&reserved=0
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-05-28 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 7:31 [PATCH] drm/imx: imx-ldb: Disable both channels for split mode in enc->disable() Liu Ying
2020-05-28 2:58 ` Liu Ying
2020-05-28 9:31 ` Marco Felsch
2020-05-28 10:02 ` Liu Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31843bf5ba23d0693cab85fdbb5e3ee8a7453527.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=m.felsch@pengutronix.de \
--cc=p.zable@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).