From: Liu Ying <victor.liu@nxp.com>
To: dri-devel@lists.freedesktop.org
Cc: stable@vger.kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH] drm/imx: imx-ldb: Disable both channels for split mode in enc->disable()
Date: Thu, 28 May 2020 10:58:01 +0800 [thread overview]
Message-ID: <ce17fb3798b208e63eabee6c1e1197bfce6b77a9.camel@nxp.com> (raw)
In-Reply-To: <1589268718-29837-1-git-send-email-victor.liu@nxp.com>
Gentle ping...
On Tue, 2020-05-12 at 15:31 +0800, Liu Ying wrote:
> Both of the two LVDS channels should be disabled for split mode
> in the encoder's ->disable() callback, because they are enabled
> in the encoder's ->enable() callback.
>
> Fixes: 6556f7f82b9c ("drm: imx: Move imx-drm driver out of staging")
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> drivers/gpu/drm/imx/imx-ldb.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-
> ldb.c
> index 4da22a9..af4d0d8 100644
> --- a/drivers/gpu/drm/imx/imx-ldb.c
> +++ b/drivers/gpu/drm/imx/imx-ldb.c
> @@ -303,18 +303,19 @@ static void imx_ldb_encoder_disable(struct
> drm_encoder *encoder)
> {
> struct imx_ldb_channel *imx_ldb_ch =
> enc_to_imx_ldb_ch(encoder);
> struct imx_ldb *ldb = imx_ldb_ch->ldb;
> + int dual = ldb->ldb_ctrl & LDB_SPLIT_MODE_EN;
> int mux, ret;
>
> drm_panel_disable(imx_ldb_ch->panel);
>
> - if (imx_ldb_ch == &ldb->channel[0])
> + if (imx_ldb_ch == &ldb->channel[0] || dual)
> ldb->ldb_ctrl &= ~LDB_CH0_MODE_EN_MASK;
> - else if (imx_ldb_ch == &ldb->channel[1])
> + if (imx_ldb_ch == &ldb->channel[1] || dual)
> ldb->ldb_ctrl &= ~LDB_CH1_MODE_EN_MASK;
>
> regmap_write(ldb->regmap, IOMUXC_GPR2, ldb->ldb_ctrl);
>
> - if (ldb->ldb_ctrl & LDB_SPLIT_MODE_EN) {
> + if (dual) {
> clk_disable_unprepare(ldb->clk[0]);
> clk_disable_unprepare(ldb->clk[1]);
> }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-28 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 7:31 [PATCH] drm/imx: imx-ldb: Disable both channels for split mode in enc->disable() Liu Ying
2020-05-28 2:58 ` Liu Ying [this message]
2020-05-28 9:31 ` Marco Felsch
2020-05-28 10:02 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce17fb3798b208e63eabee6c1e1197bfce6b77a9.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).