* [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup
@ 2023-03-23 10:25 Neil Armstrong
2023-03-23 10:25 ` [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible Neil Armstrong
` (7 more replies)
0 siblings, 8 replies; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
A few fixes to pass the DT bindings check successfully
for sm8450 qrd & hdk DTs.
The following are still needed to pass all the checks:
- https://lore.kernel.org/r/20230308082424.140224-3-manivannan.sadhasivam@linaro.org
- https://lore.kernel.org/r/20230130-topic-sm8450-upstream-pmic-glink-v5-5-552f3b721f9e@linaro.org
- https://lore.kernel.org/all/20230308075648.134119-1-manivannan.sadhasivam@linaro.org/
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Neil Armstrong (8):
dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible
dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic
dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core
arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes
arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes
arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node
arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
arm64: dts: qcom: sm8450: fix pcie1 gpios properties name
.../bindings/display/msm/qcom,sm8450-mdss.yaml | 2 +-
.../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
arch/arm64/boot/dts/qcom/sm8450.dtsi | 16 ++++------------
4 files changed, 7 insertions(+), 14 deletions(-)
---
base-commit: b9e9869138880e668fa8cb3b186d04cd13bd57a6
change-id: 20230323-topic-sm8450-upstream-dt-bindings-fixes-81630722ee31
Best regards,
--
Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
@ 2023-03-23 10:25 ` Neil Armstrong
2023-03-23 13:58 ` Rob Herring
2023-03-23 10:25 ` [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic Neil Armstrong
` (6 subsequent siblings)
7 siblings, 1 reply; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
The DSI compatible changed between patchset revisions, but that wasn't
reflected in the bindings. Fix it.
0eda3c6cb1c5 ("dt-bindings: display/msm: add support for the display on SM8450")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
index 4c6929e2534c..48781cc56434 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
@@ -54,7 +54,7 @@ patternProperties:
type: object
properties:
compatible:
- const: qcom,dsi-phy-5nm-8450
+ const: qcom,sm8450-dsi-phy-5nm
required:
- compatible
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
2023-03-23 10:25 ` [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible Neil Armstrong
@ 2023-03-23 10:25 ` Neil Armstrong
2023-03-23 10:45 ` Krzysztof Kozlowski
2023-03-23 13:58 ` Rob Herring
2023-03-23 10:25 ` [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core Neil Armstrong
` (5 subsequent siblings)
7 siblings, 2 replies; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
Add a compatible for PM8450, commonly found with SM8450.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 975c30aad23c..15deeff2d447 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -57,6 +57,7 @@ properties:
- qcom,pm8350
- qcom,pm8350b
- qcom,pm8350c
+ - qcom,pm8450
- qcom,pm8550
- qcom,pm8550b
- qcom,pm8550ve
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
2023-03-23 10:25 ` [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible Neil Armstrong
2023-03-23 10:25 ` [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic Neil Armstrong
@ 2023-03-23 10:25 ` Neil Armstrong
2023-03-23 13:58 ` Rob Herring
2023-03-23 10:25 ` [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Neil Armstrong
` (4 subsequent siblings)
7 siblings, 1 reply; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
Move the qcom,sm8450-ufshc to the right allOf:if allowing the ICE clocks
and registers to be specified.
Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index c5a06c048389..4527bcb949b7 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -108,7 +108,6 @@ allOf:
- qcom,sc8280xp-ufshc
- qcom,sm8250-ufshc
- qcom,sm8350-ufshc
- - qcom,sm8450-ufshc
- qcom,sm8550-ufshc
then:
properties:
@@ -137,6 +136,7 @@ allOf:
- qcom,sdm845-ufshc
- qcom,sm6350-ufshc
- qcom,sm8150-ufshc
+ - qcom,sm8450-ufshc
then:
properties:
clocks:
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
` (2 preceding siblings ...)
2023-03-23 10:25 ` [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core Neil Armstrong
@ 2023-03-23 10:25 ` Neil Armstrong
2023-03-23 10:51 ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 5/8] arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes Neil Armstrong
` (3 subsequent siblings)
7 siblings, 1 reply; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
Fixes the following DT bindings check error:
domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
'pinctrl-[0-9]+'
domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
'pinctrl-[0-9]+'
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 78fb65bd15cc..ff55fcfdd676 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -255,22 +255,18 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
domain-idle-states {
CLUSTER_SLEEP_0: cluster-sleep-0 {
compatible = "domain-idle-state";
- idle-state-name = "cluster-l3-off";
arm,psci-suspend-param = <0x41000044>;
entry-latency-us = <1050>;
exit-latency-us = <2500>;
min-residency-us = <5309>;
- local-timer-stop;
};
CLUSTER_SLEEP_1: cluster-sleep-1 {
compatible = "domain-idle-state";
- idle-state-name = "cluster-power-collapse";
arm,psci-suspend-param = <0x4100c344>;
entry-latency-us = <2700>;
exit-latency-us = <3500>;
min-residency-us = <13959>;
- local-timer-stop;
};
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 5/8] arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
` (3 preceding siblings ...)
2023-03-23 10:25 ` [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Neil Armstrong
@ 2023-03-23 10:25 ` Neil Armstrong
2023-03-23 10:25 ` [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node Neil Armstrong
` (2 subsequent siblings)
7 siblings, 0 replies; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
Fixes the following DT bindings check error:
pci@1c00000: Unevaluated properties are not allowed ('power-domain-names' were unexpected)
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index ff55fcfdd676..bcb51e612261 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1792,7 +1792,6 @@ pcie0: pci@1c00000 {
reset-names = "pci";
power-domains = <&gcc PCIE_0_GDSC>;
- power-domain-names = "gdsc";
phys = <&pcie0_lane>;
phy-names = "pciephy";
@@ -1905,7 +1904,6 @@ pcie1: pci@1c08000 {
reset-names = "pci";
power-domains = <&gcc PCIE_1_GDSC>;
- power-domain-names = "gdsc";
phys = <&pcie1_lane>;
phy-names = "pciephy";
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
` (4 preceding siblings ...)
2023-03-23 10:25 ` [PATCH 5/8] arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes Neil Armstrong
@ 2023-03-23 10:25 ` Neil Armstrong
2023-03-23 10:47 ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node Neil Armstrong
2023-03-23 10:25 ` [PATCH 8/8] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name Neil Armstrong
7 siblings, 1 reply; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
Fixes the following DT bindings check error:
codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long
codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed:
['mclk', 'macro', 'dcodec', 'npl'] is too long
The implementation was checked and this npl clock isn't used for the VA macro.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index bcb51e612261..ef9bae2e6acc 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -2321,9 +2321,8 @@ vamacro: codec@33f0000 {
reg = <0 0x033f0000 0 0x1000>;
clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
- <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
- <&q6prmcc LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
- clock-names = "mclk", "macro", "dcodec", "npl";
+ <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+ clock-names = "mclk", "macro", "dcodec";
assigned-clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
assigned-clock-rates = <19200000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
` (5 preceding siblings ...)
2023-03-23 10:25 ` [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node Neil Armstrong
@ 2023-03-23 10:25 ` Neil Armstrong
2023-03-23 10:49 ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 8/8] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name Neil Armstrong
7 siblings, 1 reply; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
Fixes the following DT bindings check error:
ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index ef9bae2e6acc..8ecc48c7c5ef 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
"jedec,ufs-2.0";
reg = <0 0x01d84000 0 0x3000>,
<0 0x01d88000 0 0x8000>;
- reg-names = "std", "ice";
interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>;
phys = <&ufs_mem_phy_lanes>;
phy-names = "ufsphy";
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 8/8] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
` (6 preceding siblings ...)
2023-03-23 10:25 ` [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node Neil Armstrong
@ 2023-03-23 10:25 ` Neil Armstrong
7 siblings, 0 replies; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 10:25 UTC (permalink / raw)
To: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Lee Jones,
Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar, Avri Altman,
Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, Neil Armstrong,
linux-kernel, dri-devel, Krzysztof Kozlowski, freedreno
Add the final "s" to the pgio properties and fix the invalid "enable"
name to the correct "wake", checked against the HDK8450 schematics.
Fixes: bc6588bc25fb ("arm64: dts: qcom: sm8450: add PCIe1 root device")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 8ecc48c7c5ef..d964d3fbe20c 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1908,8 +1908,8 @@ pcie1: pci@1c08000 {
phys = <&pcie1_lane>;
phy-names = "pciephy";
- perst-gpio = <&tlmm 97 GPIO_ACTIVE_LOW>;
- enable-gpio = <&tlmm 99 GPIO_ACTIVE_HIGH>;
+ perst-gpios = <&tlmm 97 GPIO_ACTIVE_LOW>;
+ wake-gpios = <&tlmm 99 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&pcie1_default_state>;
--
2.34.1
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic
2023-03-23 10:25 ` [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic Neil Armstrong
@ 2023-03-23 10:45 ` Krzysztof Kozlowski
2023-03-23 13:58 ` Rob Herring
1 sibling, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-23 10:45 UTC (permalink / raw)
To: Neil Armstrong, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 23/03/2023 11:25, Neil Armstrong wrote:
> Add a compatible for PM8450, commonly found with SM8450.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)
Already sent:
https://lore.kernel.org/linux-arm-msm/20230306112129.3687744-1-dmitry.baryshkov@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node
2023-03-23 10:25 ` [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node Neil Armstrong
@ 2023-03-23 10:47 ` Krzysztof Kozlowski
2023-03-23 13:13 ` Neil Armstrong
0 siblings, 1 reply; 28+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-23 10:47 UTC (permalink / raw)
To: Neil Armstrong, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 23/03/2023 11:25, Neil Armstrong wrote:
> Fixes the following DT bindings check error:
> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long
> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed:
> ['mclk', 'macro', 'dcodec', 'npl'] is too long
>
> The implementation was checked and this npl clock isn't used for the VA macro.
>
This does not look correct. DTS looks good, you miss some patches in
your tree.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
2023-03-23 10:25 ` [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node Neil Armstrong
@ 2023-03-23 10:49 ` Krzysztof Kozlowski
2023-03-23 13:10 ` Neil Armstrong
0 siblings, 1 reply; 28+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-23 10:49 UTC (permalink / raw)
To: Neil Armstrong, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 23/03/2023 11:25, Neil Armstrong wrote:
> Fixes the following DT bindings check error:
> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index ef9bae2e6acc..8ecc48c7c5ef 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
> "jedec,ufs-2.0";
> reg = <0 0x01d84000 0 0x3000>,
> <0 0x01d88000 0 0x8000>;
> - reg-names = "std", "ice";
This is also part of:
https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
but I actually wonder whether you just missed some binding patch?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes
2023-03-23 10:25 ` [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Neil Armstrong
@ 2023-03-23 10:51 ` Krzysztof Kozlowski
2023-03-23 13:14 ` Neil Armstrong
0 siblings, 1 reply; 28+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-23 10:51 UTC (permalink / raw)
To: Neil Armstrong, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 23/03/2023 11:25, Neil Armstrong wrote:
> Fixes the following DT bindings check error:
> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
> 'pinctrl-[0-9]+'
> domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
> 'pinctrl-[0-9]+'
I don't get from the commit msg why these properties are not correct
here. The idle states allow them, so maybe something is missing in the
binding? At least commit msg should explain this.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
2023-03-23 10:49 ` Krzysztof Kozlowski
@ 2023-03-23 13:10 ` Neil Armstrong
2023-03-24 6:52 ` Eric Biggers
0 siblings, 1 reply; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 13:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
Hi,
On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
> On 23/03/2023 11:25, Neil Armstrong wrote:
>> Fixes the following DT bindings check error:
>> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index ef9bae2e6acc..8ecc48c7c5ef 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
>> "jedec,ufs-2.0";
>> reg = <0 0x01d84000 0 0x3000>,
>> <0 0x01d88000 0 0x8000>;
>> - reg-names = "std", "ice";
>
> This is also part of:
> https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
> but I actually wonder whether you just missed some binding patch?
I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT,
and the current bindings schema doesn't document reg-names.
Neil
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node
2023-03-23 10:47 ` Krzysztof Kozlowski
@ 2023-03-23 13:13 ` Neil Armstrong
2023-03-24 7:17 ` Krzysztof Kozlowski
0 siblings, 1 reply; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 13:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 23/03/2023 11:47, Krzysztof Kozlowski wrote:
> On 23/03/2023 11:25, Neil Armstrong wrote:
>> Fixes the following DT bindings check error:
>> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long
>> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed:
>> ['mclk', 'macro', 'dcodec', 'npl'] is too long
>>
>> The implementation was checked and this npl clock isn't used for the VA macro.
>>
>
> This does not look correct. DTS looks good, you miss some patches in
> your tree.
I'm based on today's linux-next, while the other lpass macros uses the npl clock,
the lpass vamacro bindings doesn't document the npl clock.
And I found no fixes whatsover to add the npl clock to bindings.
Neil
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes
2023-03-23 10:51 ` Krzysztof Kozlowski
@ 2023-03-23 13:14 ` Neil Armstrong
2023-03-24 7:12 ` Krzysztof Kozlowski
0 siblings, 1 reply; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 13:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 23/03/2023 11:51, Krzysztof Kozlowski wrote:
> On 23/03/2023 11:25, Neil Armstrong wrote:
>> Fixes the following DT bindings check error:
>> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
>> 'pinctrl-[0-9]+'
>> domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
>> 'pinctrl-[0-9]+'
>
> I don't get from the commit msg why these properties are not correct
> here. The idle states allow them, so maybe something is missing in the
> binding? At least commit msg should explain this.
The domain-idle-states bindings doesn't document those 2 properties, so perhaps it's missing ?
Neil
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible
2023-03-23 10:25 ` [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible Neil Armstrong
@ 2023-03-23 13:58 ` Rob Herring
2023-03-23 14:44 ` Neil Armstrong
0 siblings, 1 reply; 28+ messages in thread
From: Rob Herring @ 2023-03-23 13:58 UTC (permalink / raw)
To: Neil Armstrong
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Andy Gross,
devicetree, Manivannan Sadhasivam, linux-arm-msm, Abhinav Kumar,
Avri Altman, Rob Herring, Sean Paul, Stephen Boyd,
Bjorn Andersson, linux-kernel, Konrad Dybcio, Dmitry Baryshkov,
freedreno
On Thu, 23 Mar 2023 11:25:16 +0100, Neil Armstrong wrote:
> The DSI compatible changed between patchset revisions, but that wasn't
> reflected in the bindings. Fix it.
>
> 0eda3c6cb1c5 ("dt-bindings: display/msm: add support for the display on SM8450")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.example.dtb: display-subsystem@ae00000: phy@ae94400:compatible:0: 'qcom,sm8450-dsi-phy-5nm' was expected
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.example.dtb: display-subsystem@ae00000: phy@ae96400:compatible:0: 'qcom,sm8450-dsi-phy-5nm' was expected
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.example.dtb: /example-0/display-subsystem@ae00000/phy@ae94400: failed to match any schema with compatible: ['qcom,dsi-phy-5nm-8450']
Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.example.dtb: /example-0/display-subsystem@ae00000/phy@ae96400: failed to match any schema with compatible: ['qcom,dsi-phy-5nm-8450']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-1-3ead1e418fe4@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core
2023-03-23 10:25 ` [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core Neil Armstrong
@ 2023-03-23 13:58 ` Rob Herring
2023-03-23 14:45 ` Neil Armstrong
0 siblings, 1 reply; 28+ messages in thread
From: Rob Herring @ 2023-03-23 13:58 UTC (permalink / raw)
To: Neil Armstrong
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Andy Gross,
devicetree, Manivannan Sadhasivam, linux-arm-msm, Abhinav Kumar,
Avri Altman, Rob Herring, Sean Paul, Stephen Boyd,
Bjorn Andersson, linux-kernel, Konrad Dybcio, Dmitry Baryshkov,
freedreno
On Thu, 23 Mar 2023 11:25:18 +0100, Neil Armstrong wrote:
> Move the qcom,sm8450-ufshc to the right allOf:if allowing the ICE clocks
> and registers to be specified.
>
> Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-3-3ead1e418fe4@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic
2023-03-23 10:25 ` [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic Neil Armstrong
2023-03-23 10:45 ` Krzysztof Kozlowski
@ 2023-03-23 13:58 ` Rob Herring
1 sibling, 0 replies; 28+ messages in thread
From: Rob Herring @ 2023-03-23 13:58 UTC (permalink / raw)
To: Neil Armstrong
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Andy Gross,
devicetree, Manivannan Sadhasivam, linux-arm-msm, Abhinav Kumar,
Avri Altman, Rob Herring, Sean Paul, Stephen Boyd,
Bjorn Andersson, linux-kernel, Konrad Dybcio, Dmitry Baryshkov,
freedreno
On Thu, 23 Mar 2023 11:25:17 +0100, Neil Armstrong wrote:
> Add a compatible for PM8450, commonly found with SM8450.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-2-3ead1e418fe4@linaro.org
pm8941@0: gpio@c000: 'otg' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dtb
pm8941@0: 'pwrkey@800' does not match any of the regexes: '(.*)?(wled|leds)@[0-9a-f]+$', '^adc-tm@[0-9a-f]+$', '^adc@[0-9a-f]+$', '^audio-codec@[0-9a-f]+$', '^charger@[0-9a-f]+$', '^mpps@[0-9a-f]+$', '^rtc@[0-9a-f]+$', '^temp-alarm@[0-9a-f]+$', '^usb-detect@[0-9a-f]+$', '^usb-vbus-regulator@[0-9a-f]+$', '^vibrator@[0-9a-f]+$', 'gpio@[0-9a-f]+$', 'pinctrl-[0-9]+', 'pon@[0-9a-f]+$'
arch/arm/boot/dts/qcom-apq8074-dragonboard.dtb
arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dtb
arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dtb
arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dtb
arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dtb
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb
arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-honami.dtb
pma8084@0: 'pwrkey@800' does not match any of the regexes: '(.*)?(wled|leds)@[0-9a-f]+$', '^adc-tm@[0-9a-f]+$', '^adc@[0-9a-f]+$', '^audio-codec@[0-9a-f]+$', '^charger@[0-9a-f]+$', '^mpps@[0-9a-f]+$', '^rtc@[0-9a-f]+$', '^temp-alarm@[0-9a-f]+$', '^usb-detect@[0-9a-f]+$', '^usb-vbus-regulator@[0-9a-f]+$', '^vibrator@[0-9a-f]+$', 'gpio@[0-9a-f]+$', 'pinctrl-[0-9]+', 'pon@[0-9a-f]+$'
arch/arm/boot/dts/qcom-apq8084-ifc6540.dtb
arch/arm/boot/dts/qcom-apq8084-mtp.dtb
arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dtb
pmic@0: 'extcon@1300' does not match any of the regexes: '(.*)?(wled|leds)@[0-9a-f]+$', '^adc-tm@[0-9a-f]+$', '^adc@[0-9a-f]+$', '^audio-codec@[0-9a-f]+$', '^charger@[0-9a-f]+$', '^mpps@[0-9a-f]+$', '^rtc@[0-9a-f]+$', '^temp-alarm@[0-9a-f]+$', '^usb-detect@[0-9a-f]+$', '^usb-vbus-regulator@[0-9a-f]+$', '^vibrator@[0-9a-f]+$', 'gpio@[0-9a-f]+$', 'pinctrl-[0-9]+', 'pon@[0-9a-f]+$'
arch/arm64/boot/dts/qcom/apq8016-sbc.dtb
arch/arm64/boot/dts/qcom/msm8916-acer-a1-724.dtb
arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dtb
arch/arm64/boot/dts/qcom/msm8916-asus-z00l.dtb
arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dtb
arch/arm64/boot/dts/qcom/msm8916-huawei-g7.dtb
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dtb
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dtb
arch/arm64/boot/dts/qcom/msm8916-mtp.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-a3u-eur.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-a5u-eur.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-e5.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-e7.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-grandmax.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-gt510.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-gt58.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dtb
arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dtb
arch/arm64/boot/dts/qcom/msm8916-thwc-uf896.dtb
arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dtb
arch/arm64/boot/dts/qcom/msm8916-wingtech-wt88047.dtb
arch/arm/boot/dts/qcom-apq8016-sbc.dtb
arch/arm/boot/dts/qcom-msm8916-samsung-e5.dtb
arch/arm/boot/dts/qcom-msm8916-samsung-e7.dtb
arch/arm/boot/dts/qcom-msm8916-samsung-grandmax.dtb
arch/arm/boot/dts/qcom-msm8916-samsung-serranove.dtb
pmic@2: adc@3100:adc-chan@8:qcom,pre-scaling: 'oneOf' conditional failed, one must be fixed:
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb
pmic@2: adc@3100: 'oneOf' conditional failed, one must be fixed:
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb
pmic@2: adc@4500:compatible: 'oneOf' conditional failed, one must be fixed:
arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dtb
arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dtb
arch/arm64/boot/dts/qcom/sdm845-db845c.dtb
arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtb
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dtb
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb
pmic@2: adc@4500: 'oneOf' conditional failed, one must be fixed:
arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dtb
arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dtb
arch/arm64/boot/dts/qcom/sdm845-db845c.dtb
arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtb
arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dtb
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb
pmic@2: gpio@c000:button-backlight-state: 'oneOf' conditional failed, one must be fixed:
arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dtb
pmic@3: leds@d800:interrupt-names:0: 'ovp' was expected
arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-mido.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dtb
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-kugo.dtb
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-suzu.dtb
arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dtb
pmic@3: leds@d800:interrupt-names: ['ovp'] is too short
arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dtb
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-discovery.dtb
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-pioneer.dtb
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-voyager.dtb
arch/arm64/boot/dts/qcom/sdm636-sony-xperia-ganges-mermaid.dtb
arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dtb
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dtb
pmic@3: leds@d800:interrupt-names: ['short'] is too short
arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-mido.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dtb
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-kugo.dtb
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-suzu.dtb
arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dtb
pmic@3: leds@d800:interrupts: [[3, 216, 1, 1]] is too short
arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dtb
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-ganges-kirin.dtb
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-discovery.dtb
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-pioneer.dtb
arch/arm64/boot/dts/qcom/sdm630-sony-xperia-nile-voyager.dtb
arch/arm64/boot/dts/qcom/sdm636-sony-xperia-ganges-mermaid.dtb
arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dtb
arch/arm64/boot/dts/qcom/sdm670-google-sargo.dtb
pmic@3: leds@d800:interrupts: [[3, 216, 2, 1]] is too short
arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-mido.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dtb
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-kugo.dtb
arch/arm64/boot/dts/qcom/msm8956-sony-xperia-loire-suzu.dtb
arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dtb
pmic@3: leds@d800: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
arch/arm64/boot/dts/qcom/msm8953-motorola-potter.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-tissot.dtb
arch/arm64/boot/dts/qcom/msm8953-xiaomi-vince.dtb
arch/arm64/boot/dts/qcom/sdm450-motorola-ali.dtb
pmic@3: regulators: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 's2@1700' were unexpected)
arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dtb
arch/arm64/boot/dts/qcom/apq8096-db820c.dtb
arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dtb
arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dtb
pmic@3: regulators: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dtb
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dtb
arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dtb
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dtb
arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dtb
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dtb
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-scorpio.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dtb
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dtb
pmic@3: wled@d800:interrupt-names:0: 'ovp' was expected
arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dtb
arch/arm64/boot/dts/qcom/apq8096-db820c.dtb
arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dtb
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dtb
arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dtb
arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dtb
arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dtb
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dtb
arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dtb
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dtb
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-scorpio.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dtb
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dtb
pmic@3: wled@d800:interrupt-names: ['short'] is too short
arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dtb
arch/arm64/boot/dts/qcom/apq8096-db820c.dtb
arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dtb
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dtb
arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dtb
arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dtb
arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dtb
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dtb
arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dtb
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dtb
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-scorpio.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dtb
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dtb
pmic@3: wled@d800:interrupts: [[3, 216, 2, 1]] is too short
arch/arm64/boot/dts/qcom/apq8094-sony-xperia-kitakami-karin_windy.dtb
arch/arm64/boot/dts/qcom/apq8096-db820c.dtb
arch/arm64/boot/dts/qcom/apq8096-ifc6640.dtb
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-101.dtb
arch/arm64/boot/dts/qcom/msm8992-lg-bullhead-rev-10.dtb
arch/arm64/boot/dts/qcom/msm8992-msft-lumia-octagon-talkman.dtb
arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dtb
arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon-cityman.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-ivy.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-karin.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-satsuki.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-sumire.dtb
arch/arm64/boot/dts/qcom/msm8994-sony-xperia-kitakami-suzuran.dtb
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dtb
arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dtb
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dtb
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-scorpio.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dtb
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dtb
pmic@3: wled@d800: 'label' is a required property
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dtb
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dtb
pmic@3: wled@d800: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dtb
arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dtb
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dtb
pmic@5: 'led-controller@d300' does not match any of the regexes: '(.*)?(wled|leds)@[0-9a-f]+$', '^adc-tm@[0-9a-f]+$', '^adc@[0-9a-f]+$', '^audio-codec@[0-9a-f]+$', '^charger@[0-9a-f]+$', '^mpps@[0-9a-f]+$', '^rtc@[0-9a-f]+$', '^temp-alarm@[0-9a-f]+$', '^usb-detect@[0-9a-f]+$', '^usb-vbus-regulator@[0-9a-f]+$', '^vibrator@[0-9a-f]+$', 'gpio@[0-9a-f]+$', 'pinctrl-[0-9]+', 'pon@[0-9a-f]+$'
arch/arm64/boot/dts/qcom/sc7180-idp.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-ti.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-parade.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-ti.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb
pmic@5: leds@d800:interrupt-names: ['ovp'] is too short
arch/arm64/boot/dts/qcom/sc7180-idp.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-ti.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-parade.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-ti.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb
pmic@5: leds@d800:interrupts: [[5, 216, 1, 1]] is too short
arch/arm64/boot/dts/qcom/sc7180-idp.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r2.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r5.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r4.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-kb.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-auo.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev0-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-auo.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-mrbland-rev1-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-parade.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-lte-ti.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-parade.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel-ti.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-pompom-r3-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-quackingstick-r0-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-r1-lte.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb
arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible
2023-03-23 13:58 ` Rob Herring
@ 2023-03-23 14:44 ` Neil Armstrong
0 siblings, 0 replies; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 14:44 UTC (permalink / raw)
To: Rob Herring
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Andy Gross,
devicetree, Manivannan Sadhasivam, linux-arm-msm, Abhinav Kumar,
Avri Altman, Rob Herring, Sean Paul, Stephen Boyd,
Bjorn Andersson, linux-kernel, Konrad Dybcio, Dmitry Baryshkov,
freedreno
On 23/03/2023 14:58, Rob Herring wrote:
>
> On Thu, 23 Mar 2023 11:25:16 +0100, Neil Armstrong wrote:
>> The DSI compatible changed between patchset revisions, but that wasn't
>> reflected in the bindings. Fix it.
>>
>> 0eda3c6cb1c5 ("dt-bindings: display/msm: add support for the display on SM8450")
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.example.dtb: display-subsystem@ae00000: phy@ae94400:compatible:0: 'qcom,sm8450-dsi-phy-5nm' was expected
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.example.dtb: display-subsystem@ae00000: phy@ae96400:compatible:0: 'qcom,sm8450-dsi-phy-5nm' was expected
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.example.dtb: /example-0/display-subsystem@ae00000/phy@ae94400: failed to match any schema with compatible: ['qcom,dsi-phy-5nm-8450']
> Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.example.dtb: /example-0/display-subsystem@ae00000/phy@ae96400: failed to match any schema with compatible: ['qcom,dsi-phy-5nm-8450']
Indeed I forgot to fix the bindings example....
Thx,
Neil
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-1-3ead1e418fe4@linaro.org
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core
2023-03-23 13:58 ` Rob Herring
@ 2023-03-23 14:45 ` Neil Armstrong
0 siblings, 0 replies; 28+ messages in thread
From: Neil Armstrong @ 2023-03-23 14:45 UTC (permalink / raw)
To: Rob Herring
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Andy Gross,
devicetree, Manivannan Sadhasivam, linux-arm-msm, Abhinav Kumar,
Avri Altman, Rob Herring, Sean Paul, Stephen Boyd,
Bjorn Andersson, linux-kernel, Konrad Dybcio, Dmitry Baryshkov,
freedreno
On 23/03/2023 14:58, Rob Herring wrote:
>
> On Thu, 23 Mar 2023 11:25:18 +0100, Neil Armstrong wrote:
>> Move the qcom,sm8450-ufshc to the right allOf:if allowing the ICE clocks
>> and registers to be specified.
>>
>> Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
Same as patch 1, I forgot to fix the example...
Neil
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-3-3ead1e418fe4@linaro.org
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
2023-03-23 13:10 ` Neil Armstrong
@ 2023-03-24 6:52 ` Eric Biggers
2023-03-24 7:14 ` Krzysztof Kozlowski
2023-03-24 7:26 ` Luca Weiss
0 siblings, 2 replies; 28+ messages in thread
From: Eric Biggers @ 2023-03-24 6:52 UTC (permalink / raw)
To: Neil Armstrong
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Krzysztof Kozlowski,
Luca Weiss, Andy Gross, devicetree, Manivannan Sadhasivam,
linux-arm-msm, Abhinav Kumar, Avri Altman, Rob Herring,
Sean Paul, Stephen Boyd, Bjorn Andersson, linux-kernel,
Konrad Dybcio, Dmitry Baryshkov, freedreno
Hi Neil,
On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote:
> Hi,
>
> On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
> > On 23/03/2023 11:25, Neil Armstrong wrote:
> > > Fixes the following DT bindings check error:
> > > ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
> > >
> > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > index ef9bae2e6acc..8ecc48c7c5ef 100644
> > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
> > > "jedec,ufs-2.0";
> > > reg = <0 0x01d84000 0 0x3000>,
> > > <0 0x01d88000 0 0x8000>;
> > > - reg-names = "std", "ice";
> >
> > This is also part of:
> > https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
> > but I actually wonder whether you just missed some binding patch?
>
> I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT,
> and the current bindings schema doesn't document reg-names.
>
The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't
be removed from the device tree. A few months ago there was a patch to fix the
device tree schema for qcom,ufs to include the reg-names. It looks like that
patch got missed, though:
https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com
- Eric
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes
2023-03-23 13:14 ` Neil Armstrong
@ 2023-03-24 7:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-24 7:12 UTC (permalink / raw)
To: neil.armstrong, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 23/03/2023 14:14, Neil Armstrong wrote:
> On 23/03/2023 11:51, Krzysztof Kozlowski wrote:
>> On 23/03/2023 11:25, Neil Armstrong wrote:
>>> Fixes the following DT bindings check error:
>>> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
>>> 'pinctrl-[0-9]+'
>>> domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
>>> 'pinctrl-[0-9]+'
>>
>> I don't get from the commit msg why these properties are not correct
>> here. The idle states allow them, so maybe something is missing in the
>> binding? At least commit msg should explain this.
>
> The domain-idle-states bindings doesn't document those 2 properties, so perhaps it's missing ?
Ah, you are right. These were copied from CPU idle states, so here they
do not make sense.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
2023-03-24 6:52 ` Eric Biggers
@ 2023-03-24 7:14 ` Krzysztof Kozlowski
2023-03-24 7:26 ` Luca Weiss
1 sibling, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-24 7:14 UTC (permalink / raw)
To: Eric Biggers, Neil Armstrong
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Luca Weiss,
Andy Gross, devicetree, Manivannan Sadhasivam, linux-arm-msm,
Abhinav Kumar, Avri Altman, Rob Herring, Sean Paul, Stephen Boyd,
Bjorn Andersson, linux-kernel, Konrad Dybcio, Dmitry Baryshkov,
freedreno
On 24/03/2023 07:52, Eric Biggers wrote:
> Hi Neil,
>
> On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote:
>> Hi,
>>
>> On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
>>> On 23/03/2023 11:25, Neil Armstrong wrote:
>>>> Fixes the following DT bindings check error:
>>>> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
>>>>
>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> index ef9bae2e6acc..8ecc48c7c5ef 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
>>>> "jedec,ufs-2.0";
>>>> reg = <0 0x01d84000 0 0x3000>,
>>>> <0 0x01d88000 0 0x8000>;
>>>> - reg-names = "std", "ice";
>>>
>>> This is also part of:
>>> https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
>>> but I actually wonder whether you just missed some binding patch?
>>
>> I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT,
>> and the current bindings schema doesn't document reg-names.
>>
>
> The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't
> be removed from the device tree. A few months ago there was a patch to fix the
> device tree schema for qcom,ufs to include the reg-names. It looks like that
> patch got missed, though:
> https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com
Exactly. This is why I never saw these warnings.
Neil, there are a lot of pending patches, so you need to be sure you run
dtbs_check with them applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node
2023-03-23 13:13 ` Neil Armstrong
@ 2023-03-24 7:17 ` Krzysztof Kozlowski
2023-03-24 8:59 ` neil.armstrong
0 siblings, 1 reply; 28+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-24 7:17 UTC (permalink / raw)
To: neil.armstrong, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 23/03/2023 14:13, Neil Armstrong wrote:
> On 23/03/2023 11:47, Krzysztof Kozlowski wrote:
>> On 23/03/2023 11:25, Neil Armstrong wrote:
>>> Fixes the following DT bindings check error:
>>> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long
>>> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed:
>>> ['mclk', 'macro', 'dcodec', 'npl'] is too long
>>>
>>> The implementation was checked and this npl clock isn't used for the VA macro.
>>>
>>
>> This does not look correct. DTS looks good, you miss some patches in
>> your tree.
>
> I'm based on today's linux-next,
Which is unfortunately not enough. Several things were
fixed/added/changed and are pending. I brought the topic of pending
branch few times on IRC for that reason.
> while the other lpass macros uses the npl clock,
> the lpass vamacro bindings doesn't document the npl clock.
>
> And I found no fixes whatsover to add the npl clock to bindings.
Really? lore finds it easily:
https://lore.kernel.org/all/20221118071849.25506-2-srinivas.kandagatla@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
2023-03-24 6:52 ` Eric Biggers
2023-03-24 7:14 ` Krzysztof Kozlowski
@ 2023-03-24 7:26 ` Luca Weiss
2023-03-24 7:27 ` Krzysztof Kozlowski
1 sibling, 1 reply; 28+ messages in thread
From: Luca Weiss @ 2023-03-24 7:26 UTC (permalink / raw)
To: Eric Biggers, Neil Armstrong
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Krzysztof Kozlowski,
Andy Gross, devicetree, Manivannan Sadhasivam, linux-arm-msm,
Abhinav Kumar, Avri Altman, Rob Herring, Sean Paul, Stephen Boyd,
Bjorn Andersson, linux-kernel, Konrad Dybcio, Dmitry Baryshkov,
freedreno
Hi Eric,
On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote:
> Hi Neil,
>
> On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote:
> > Hi,
> >
> > On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
> > > On 23/03/2023 11:25, Neil Armstrong wrote:
> > > > Fixes the following DT bindings check error:
> > > > ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
> > > >
> > > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> > > > ---
> > > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > > index ef9bae2e6acc..8ecc48c7c5ef 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > > > @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
> > > > "jedec,ufs-2.0";
> > > > reg = <0 0x01d84000 0 0x3000>,
> > > > <0 0x01d88000 0 0x8000>;
> > > > - reg-names = "std", "ice";
> > >
> > > This is also part of:
> > > https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
> > > but I actually wonder whether you just missed some binding patch?
> >
> > I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT,
> > and the current bindings schema doesn't document reg-names.
> >
>
> The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't
> be removed from the device tree. A few months ago there was a patch to fix the
> device tree schema for qcom,ufs to include the reg-names. It looks like that
> patch got missed, though:
> https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com
Are you implying that I should resend the patch or something? Not sure
who to bug about applying this patch.
Regards
Luca
>
> - Eric
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node
2023-03-24 7:26 ` Luca Weiss
@ 2023-03-24 7:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-24 7:27 UTC (permalink / raw)
To: Luca Weiss, Eric Biggers, Neil Armstrong
Cc: Alim Akhtar, dri-devel, Krzysztof Kozlowski, Bart Van Assche,
linux-scsi, Lee Jones, Krzysztof Kozlowski, Andy Gross,
devicetree, Manivannan Sadhasivam, linux-arm-msm, Abhinav Kumar,
Avri Altman, Rob Herring, Sean Paul, Stephen Boyd,
Bjorn Andersson, linux-kernel, Konrad Dybcio, Dmitry Baryshkov,
freedreno
On 24/03/2023 08:26, Luca Weiss wrote:
> Hi Eric,
>
> On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote:
>> Hi Neil,
>>
>> On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote:
>>> Hi,
>>>
>>> On 23/03/2023 11:49, Krzysztof Kozlowski wrote:
>>>> On 23/03/2023 11:25, Neil Armstrong wrote:
>>>>> Fixes the following DT bindings check error:
>>>>> ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' was unexpected)
>>>>>
>>>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>>>> ---
>>>>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 -
>>>>> 1 file changed, 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> index ef9bae2e6acc..8ecc48c7c5ef 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>>>>> @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 {
>>>>> "jedec,ufs-2.0";
>>>>> reg = <0 0x01d84000 0 0x3000>,
>>>>> <0 0x01d88000 0 0x8000>;
>>>>> - reg-names = "std", "ice";
>>>>
>>>> This is also part of:
>>>> https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.vesa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi
>>>> but I actually wonder whether you just missed some binding patch?
>>>
>>> I'm aware of Abel's RFC patchset to support shared ICE, but this is a cleanup of the current DT,
>>> and the current bindings schema doesn't document reg-names.
>>>
>>
>> The ufs-qcom driver accesses the "ice" registers by name, so the reg-names can't
>> be removed from the device tree. A few months ago there was a patch to fix the
>> device tree schema for qcom,ufs to include the reg-names. It looks like that
>> patch got missed, though:
>> https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairphone.com
>
> Are you implying that I should resend the patch or something? Not sure
> who to bug about applying this patch.
Yes, you should. It has been almost three months...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node
2023-03-24 7:17 ` Krzysztof Kozlowski
@ 2023-03-24 8:59 ` neil.armstrong
0 siblings, 0 replies; 28+ messages in thread
From: neil.armstrong @ 2023-03-24 8:59 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Clark, Abhinav Kumar, Dmitry Baryshkov,
Sean Paul, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Lee Jones, Stephen Boyd, Manivannan Sadhasivam, Alim Akhtar,
Avri Altman, Bart Van Assche
Cc: linux-scsi, devicetree, linux-arm-msm, linux-kernel, dri-devel,
Krzysztof Kozlowski, freedreno
On 24/03/2023 08:17, Krzysztof Kozlowski wrote:
> On 23/03/2023 14:13, Neil Armstrong wrote:
>> On 23/03/2023 11:47, Krzysztof Kozlowski wrote:
>>> On 23/03/2023 11:25, Neil Armstrong wrote:
>>>> Fixes the following DT bindings check error:
>>>> codec@33f0000: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, 70, 1]] is too long
>>>> codec@33f0000: clock-names: 'oneOf' conditional failed, one must be fixed:
>>>> ['mclk', 'macro', 'dcodec', 'npl'] is too long
>>>>
>>>> The implementation was checked and this npl clock isn't used for the VA macro.
>>>>
>>>
>>> This does not look correct. DTS looks good, you miss some patches in
>>> your tree.
>>
>> I'm based on today's linux-next,
>
> Which is unfortunately not enough. Several things were
> fixed/added/changed and are pending. I brought the topic of pending
> branch few times on IRC for that reason.
>
>> while the other lpass macros uses the npl clock,
>> the lpass vamacro bindings doesn't document the npl clock.
>>
>> And I found no fixes whatsover to add the npl clock to bindings.
>
> Really? lore finds it easily:
>
> https://lore.kernel.org/all/20221118071849.25506-2-srinivas.kandagatla@linaro.org/
You're better at lore than me... thx anyway...
Neil
>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 28+ messages in thread
end of thread, other threads:[~2023-03-24 8:59 UTC | newest]
Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 10:25 [PATCH 0/8] arm64: qcom: sm8450: bindings check cleanup Neil Armstrong
2023-03-23 10:25 ` [PATCH 1/8] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible Neil Armstrong
2023-03-23 13:58 ` Rob Herring
2023-03-23 14:44 ` Neil Armstrong
2023-03-23 10:25 ` [PATCH 2/8] dt-bindings: mfd: qcom,spmi-pmic: document pm8450 pmic Neil Armstrong
2023-03-23 10:45 ` Krzysztof Kozlowski
2023-03-23 13:58 ` Rob Herring
2023-03-23 10:25 ` [PATCH 3/8] dt-bindings: ufs: qcom: document the fact the UFS controller can have an ICE core Neil Armstrong
2023-03-23 13:58 ` Rob Herring
2023-03-23 14:45 ` Neil Armstrong
2023-03-23 10:25 ` [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes Neil Armstrong
2023-03-23 10:51 ` Krzysztof Kozlowski
2023-03-23 13:14 ` Neil Armstrong
2023-03-24 7:12 ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 5/8] arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes Neil Armstrong
2023-03-23 10:25 ` [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node Neil Armstrong
2023-03-23 10:47 ` Krzysztof Kozlowski
2023-03-23 13:13 ` Neil Armstrong
2023-03-24 7:17 ` Krzysztof Kozlowski
2023-03-24 8:59 ` neil.armstrong
2023-03-23 10:25 ` [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node Neil Armstrong
2023-03-23 10:49 ` Krzysztof Kozlowski
2023-03-23 13:10 ` Neil Armstrong
2023-03-24 6:52 ` Eric Biggers
2023-03-24 7:14 ` Krzysztof Kozlowski
2023-03-24 7:26 ` Luca Weiss
2023-03-24 7:27 ` Krzysztof Kozlowski
2023-03-23 10:25 ` [PATCH 8/8] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).