dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: add dmcub check on RENOIR
@ 2020-07-08  8:16 Aaron Ma
  2020-07-08 14:15 ` Deucher, Alexander
  0 siblings, 1 reply; 3+ messages in thread
From: Aaron Ma @ 2020-07-08  8:16 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, amd-gfx, dri-devel, linux-kernel, mapengyu,
	aaron.ma

RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram,
it breaks backlight control.

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=208277
Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 10ac8076d4f2..db5e0bb0d935 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)
 	struct dmcu *dmcu = NULL;
 	bool ret;
 
-	if (!adev->dm.fw_dmcu)
+	if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
 		return detect_mst_link_for_all_connectors(adev->ddev);
 
 	dmcu = adev->dm.dc->res_pool->dmcu;
-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: add dmcub check on RENOIR
  2020-07-08  8:16 [PATCH] drm/amd/display: add dmcub check on RENOIR Aaron Ma
@ 2020-07-08 14:15 ` Deucher, Alexander
  2020-07-08 14:30   ` Kazlauskas, Nicholas
  0 siblings, 1 reply; 3+ messages in thread
From: Deucher, Alexander @ 2020-07-08 14:15 UTC (permalink / raw)
  To: Aaron Ma, Wentland, Harry, Li, Sun peng (Leo),
	Koenig,  Christian, airlied, daniel, amd-gfx, dri-devel,
	linux-kernel, mapengyu


[-- Attachment #1.1: Type: text/plain, Size: 2003 bytes --]

[AMD Public Use]

Acked-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: Aaron Ma <aaron.ma@canonical.com>
Sent: Wednesday, July 8, 2020 4:16 AM
To: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; airlied@linux.ie <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; mapengyu@gmail.com <mapengyu@gmail.com>; aaron.ma@canonical.com <aaron.ma@canonical.com>
Subject: [PATCH] drm/amd/display: add dmcub check on RENOIR

RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram,
it breaks backlight control.

Bug: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D208277&amp;data=02%7C01%7Calexander.deucher%40amd.com%7Cf922a1848f1f4cc4934f08d823174036%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637297930080282163&amp;sdata=limstWv5pwvdqDRpKoKpCZcutV4pmqhdqR7CFEimR2Q%3D&amp;reserved=0
Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 10ac8076d4f2..db5e0bb0d935 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)
         struct dmcu *dmcu = NULL;
         bool ret;

-       if (!adev->dm.fw_dmcu)
+       if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
                 return detect_mst_link_for_all_connectors(adev->ddev);

         dmcu = adev->dm.dc->res_pool->dmcu;
--
2.25.1


[-- Attachment #1.2: Type: text/html, Size: 3717 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: add dmcub check on RENOIR
  2020-07-08 14:15 ` Deucher, Alexander
@ 2020-07-08 14:30   ` Kazlauskas, Nicholas
  0 siblings, 0 replies; 3+ messages in thread
From: Kazlauskas, Nicholas @ 2020-07-08 14:30 UTC (permalink / raw)
  To: Deucher, Alexander, Aaron Ma, Wentland, Harry, Li, Sun peng (Leo),
	Koenig, Christian, airlied, daniel, amd-gfx, dri-devel,
	linux-kernel, mapengyu

Looks good to me.

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Regards,
Nicholas Kazlauskas

On 2020-07-08 10:15 a.m., Deucher, Alexander wrote:
> [AMD Public Use]
> 
> 
> [AMD Public Use]
> 
> 
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ------------------------------------------------------------------------
> *From:* Aaron Ma <aaron.ma@canonical.com>
> *Sent:* Wednesday, July 8, 2020 4:16 AM
> *To:* Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) 
> <Sunpeng.Li@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; 
> Koenig, Christian <Christian.Koenig@amd.com>; airlied@linux.ie 
> <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch>; 
> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; 
> dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; 
> linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; 
> mapengyu@gmail.com <mapengyu@gmail.com>; aaron.ma@canonical.com 
> <aaron.ma@canonical.com>
> *Subject:* [PATCH] drm/amd/display: add dmcub check on RENOIR
> RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram,
> it breaks backlight control.
> 
> Bug: 
> https://bugzilla.kernel.org/show_bug.cgi?id=208277 
> <https://bugzilla.kernel.org/show_bug.cgi?id=208277>
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 10ac8076d4f2..db5e0bb0d935 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)
>           struct dmcu *dmcu = NULL;
>           bool ret;
> 
> -       if (!adev->dm.fw_dmcu)
> +       if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
>                   return detect_mst_link_for_all_connectors(adev->ddev);
> 
>           dmcu = adev->dm.dc->res_pool->dmcu;
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-09  7:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08  8:16 [PATCH] drm/amd/display: add dmcub check on RENOIR Aaron Ma
2020-07-08 14:15 ` Deucher, Alexander
2020-07-08 14:30   ` Kazlauskas, Nicholas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).