* [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()
@ 2018-07-06 19:04 Peter Jones
2018-07-06 20:30 ` Rodrigo Vivi
0 siblings, 1 reply; 3+ messages in thread
From: Peter Jones @ 2018-07-06 19:04 UTC (permalink / raw)
To: Jani Nikula
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Peter Jones,
Rodrigo Vivi
This was sort of annoying me:
random:~$ dmesg | tail -1
[523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
random:~$ dmesg | grep -c "Reducing the compressed"
47
This patch makes it DRM_INFO_ONCE() just like the similar message
farther down in that function is pr_info_once().
Signed-off-by: Peter Jones <pjones@redhat.com>
---
drivers/gpu/drm/i915/intel_fbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index b431b6733cc..88b013758da 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
if (!ret)
goto err_llb;
else if (ret > 1) {
- DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
+ DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
}
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()
2018-07-06 19:04 [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE() Peter Jones
@ 2018-07-06 20:30 ` Rodrigo Vivi
2020-04-07 9:02 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Rodrigo Vivi @ 2018-07-06 20:30 UTC (permalink / raw)
To: Peter Jones; +Cc: Jani Nikula, David Airlie, intel-gfx, linux-kernel, dri-devel
On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote:
> This was sort of annoying me:
>
> random:~$ dmesg | tail -1
> [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
> random:~$ dmesg | grep -c "Reducing the compressed"
> 47
>
> This patch makes it DRM_INFO_ONCE() just like the similar message
> farther down in that function is pr_info_once().
>
> Signed-off-by: Peter Jones <pjones@redhat.com>
> ---
> drivers/gpu/drm/i915/intel_fbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
> index b431b6733cc..88b013758da 100644
> --- a/drivers/gpu/drm/i915/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/intel_fbc.c
> @@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
> if (!ret)
> goto err_llb;
> else if (ret > 1) {
> - DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
> + DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
I know the feeling of seeing a message over and over again when you are already aware of that.
Specially something that tells you to change BIOS configuration...
for this reason I think it makes sense, so:
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
I will just wait for CI and give a couple days to someone else to challenge.
If I end up forgetting to push it please ping me...
>
> }
>
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()
2018-07-06 20:30 ` Rodrigo Vivi
@ 2020-04-07 9:02 ` Jiri Slaby
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2020-04-07 9:02 UTC (permalink / raw)
To: Rodrigo Vivi, Peter Jones
Cc: David Airlie, intel-gfx, dri-devel, linux-kernel
On 06. 07. 18, 22:30, Rodrigo Vivi wrote:
> On Fri, Jul 06, 2018 at 03:04:24PM -0400, Peter Jones wrote:
>> This was sort of annoying me:
>>
>> random:~$ dmesg | tail -1
>> [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
>> random:~$ dmesg | grep -c "Reducing the compressed"
>> 47
>>
>> This patch makes it DRM_INFO_ONCE() just like the similar message
>> farther down in that function is pr_info_once().
>>
>> Signed-off-by: Peter Jones <pjones@redhat.com>
>> ---
>> drivers/gpu/drm/i915/intel_fbc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
>> index b431b6733cc..88b013758da 100644
>> --- a/drivers/gpu/drm/i915/intel_fbc.c
>> +++ b/drivers/gpu/drm/i915/intel_fbc.c
>> @@ -585,7 +585,7 @@ static int intel_fbc_alloc_cfb(struct intel_crtc *crtc)
>> if (!ret)
>> goto err_llb;
>> else if (ret > 1) {
>> - DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
>> + DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
>
> I know the feeling of seeing a message over and over again when you are already aware of that.
> Specially something that tells you to change BIOS configuration...
> for this reason I think it makes sense, so:
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> I will just wait for CI and give a couple days to someone else to challenge.
> If I end up forgetting to push it please ping me...
After almost two years, ping :).
>
>>
>> }
>>
>> --
>> 2.17.1
thanks,
--
js
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-07 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-06 19:04 [PATCH] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE() Peter Jones
2018-07-06 20:30 ` Rodrigo Vivi
2020-04-07 9:02 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).