From: Robin Murphy <robin.murphy@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonas Karlman <jonas@kwiboo.se>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Neil Armstrong <narmstrong@baylibre.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types
Date: Wed, 24 Jun 2020 16:16:48 +0100 [thread overview]
Message-ID: <381de683-df5e-4112-5690-13dd9272ae22@arm.com> (raw)
In-Reply-To: <20200624150434.GH5472@sirena.org.uk>
On 2020-06-24 16:04, Mark Brown wrote:
> On Wed, Jun 24, 2020 at 03:25:33PM +0100, Robin Murphy wrote:
>
>> And yeah, anyone who pipes up suggesting that places where an ERR_PTR value
>> could be passed to probe_err() could simply refactor IS_ERR() checks with
>> more uses of the god-awful PTR_ERR_OR_ZERO() obfuscator gets a long stare of
>> disapproval...
>
> We could also have a probe_err_ptr() or something that took an ERR_PTR()
> instead if there really were an issue with explicitly doing this.
Yeah, for all my lyrical objection, a static inline <blah>_ptr_err()
helper to wrap <blah>_err() with sensible type checking might actually
be an OK compromise if people really feel strongly for having that utility.
(and then we can debate whether it should also convert NULL to -ENOMEM
and !IS_ERR to 0... :D)
Robin.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-24 15:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200624114134eucas1p2799e0ae76fcb026a0e4bcccc2026b732@eucas1p2.samsung.com>
2020-06-24 11:41 ` [RESEND PATCH v5 0/5] driver core: add probe error check helper Andrzej Hajda
[not found] ` <CGME20200624114135eucas1p26e2e4683d60cebdce7acd55177013992@eucas1p2.samsung.com>
2020-06-24 11:41 ` [RESEND PATCH v5 1/5] driver core: add probe_err log helper Andrzej Hajda
2020-06-24 11:52 ` Rafael J. Wysocki
2020-06-24 12:31 ` Greg Kroah-Hartman
2020-06-24 13:23 ` Laurent Pinchart
2020-06-24 14:04 ` Andrzej Hajda
2020-06-24 13:27 ` Mark Brown
2020-06-24 13:45 ` Andy Shevchenko
2020-06-24 14:02 ` Mark Brown
2020-06-24 15:00 ` Robin Murphy
2020-06-24 15:28 ` Mark Brown
[not found] ` <CGME20200624114136eucas1p1a3a31d95d86754201c7965f26ccd5de0@eucas1p1.samsung.com>
2020-06-24 11:41 ` [RESEND PATCH v5 2/5] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda
2020-06-24 12:11 ` Rafael J. Wysocki
2020-06-24 13:28 ` Andrzej Hajda
2020-06-24 12:34 ` Greg Kroah-Hartman
2020-06-24 13:26 ` Andrzej Hajda
[not found] ` <CGME20200624114136eucas1p1c84f81b1d78e2dbad7ac1b762f0a4b4f@eucas1p1.samsung.com>
2020-06-24 11:41 ` [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types Andrzej Hajda
2020-06-24 12:14 ` Rafael J. Wysocki
2020-06-24 14:44 ` Andrzej Hajda
2020-06-24 14:55 ` Rafael J. Wysocki
2020-06-24 12:30 ` Greg Kroah-Hartman
2020-06-24 14:48 ` Andrzej Hajda
2020-06-24 12:37 ` Robin Murphy
2020-06-24 12:55 ` Andy Shevchenko
2020-06-24 14:25 ` Robin Murphy
2020-06-24 15:04 ` Mark Brown
2020-06-24 15:16 ` Robin Murphy [this message]
2020-06-24 19:39 ` Andrzej Hajda
2020-06-25 8:41 ` Andy Shevchenko
2020-06-25 10:19 ` Andrzej Hajda
2020-06-24 13:29 ` Laurent Pinchart
2020-06-24 12:53 ` Andy Shevchenko
2020-06-24 13:12 ` Andrzej Hajda
[not found] ` <CGME20200624114137eucas1p13599d33a0c4a9abf7708bf8c8e77264b@eucas1p1.samsung.com>
2020-06-24 11:41 ` [RESEND PATCH v5 4/5] drm/bridge/sii8620: fix resource acquisition error handling Andrzej Hajda
2020-06-24 13:25 ` Mark Brown
2020-06-24 13:43 ` Andrzej Hajda
2020-06-24 14:11 ` Mark Brown
[not found] ` <CGME20200624114138eucas1p262505da3ad1067720080d20209ff32de@eucas1p2.samsung.com>
2020-06-24 11:41 ` [RESEND PATCH v5 5/5] drm/bridge: lvds-codec: simplify error handling code Andrzej Hajda
2020-06-24 13:33 ` Laurent Pinchart
2020-06-24 14:03 ` Andrzej Hajda
2020-06-24 21:18 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=381de683-df5e-4112-5690-13dd9272ae22@arm.com \
--to=robin.murphy@arm.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).