* [PATCH] drm/amdkfd: Check for null pointer after calling kmemdup
@ 2022-01-05 9:09 Jiasheng Jiang
2022-01-05 15:56 ` Felix Kuehling
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2022-01-05 9:09 UTC (permalink / raw)
To: Felix.Kuehling, alexander.deucher, christian.koenig, airlied, daniel
Cc: Jiasheng Jiang, dri-devel, amd-gfx, linux-kernel
As the possible failure of the allocation, kmemdup() may return NULL
pointer.
Therefore, it should be better to check the 'props2' in order to prevent
the dereference of NULL pointer.
Fixes: 3a87177eb141 ("drm/amdkfd: Add topology support for dGPUs")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index c60e82697385..d15380c65c6d 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -410,6 +410,9 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
return -ENODEV;
/* same everything but the other direction */
props2 = kmemdup(props, sizeof(*props2), GFP_KERNEL);
+ if (!props2)
+ return -ENOMEM;
+
props2->node_from = id_to;
props2->node_to = id_from;
props2->kobj = NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdkfd: Check for null pointer after calling kmemdup
2022-01-05 9:09 [PATCH] drm/amdkfd: Check for null pointer after calling kmemdup Jiasheng Jiang
@ 2022-01-05 15:56 ` Felix Kuehling
2022-01-10 21:23 ` Felix Kuehling
0 siblings, 1 reply; 3+ messages in thread
From: Felix Kuehling @ 2022-01-05 15:56 UTC (permalink / raw)
To: Jiasheng Jiang, alexander.deucher, christian.koenig, airlied, daniel
Cc: dri-devel, amd-gfx, linux-kernel
Am 2022-01-05 um 4:09 a.m. schrieb Jiasheng Jiang:
> As the possible failure of the allocation, kmemdup() may return NULL
> pointer.
> Therefore, it should be better to check the 'props2' in order to prevent
> the dereference of NULL pointer.
>
> Fixes: 3a87177eb141 ("drm/amdkfd: Add topology support for dGPUs")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index c60e82697385..d15380c65c6d 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -410,6 +410,9 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
> return -ENODEV;
> /* same everything but the other direction */
> props2 = kmemdup(props, sizeof(*props2), GFP_KERNEL);
> + if (!props2)
> + return -ENOMEM;
> +
> props2->node_from = id_to;
> props2->node_to = id_from;
> props2->kobj = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdkfd: Check for null pointer after calling kmemdup
2022-01-05 15:56 ` Felix Kuehling
@ 2022-01-10 21:23 ` Felix Kuehling
0 siblings, 0 replies; 3+ messages in thread
From: Felix Kuehling @ 2022-01-10 21:23 UTC (permalink / raw)
To: Jiasheng Jiang, alexander.deucher, christian.koenig, airlied, daniel
Cc: amd-gfx, dri-devel, linux-kernel
On 2022-01-05 10:56 a.m., Felix Kuehling wrote:
> Am 2022-01-05 um 4:09 a.m. schrieb Jiasheng Jiang:
>> As the possible failure of the allocation, kmemdup() may return NULL
>> pointer.
>> Therefore, it should be better to check the 'props2' in order to prevent
>> the dereference of NULL pointer.
>>
>> Fixes: 3a87177eb141 ("drm/amdkfd: Add topology support for dGPUs")
>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
I applied the patch to amd-staging-drm-next.
Regards,
Felix
>
>> ---
>> drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> index c60e82697385..d15380c65c6d 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
>> @@ -410,6 +410,9 @@ static int kfd_parse_subtype_iolink(struct crat_subtype_iolink *iolink,
>> return -ENODEV;
>> /* same everything but the other direction */
>> props2 = kmemdup(props, sizeof(*props2), GFP_KERNEL);
>> + if (!props2)
>> + return -ENOMEM;
>> +
>> props2->node_from = id_to;
>> props2->node_to = id_from;
>> props2->kobj = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-10 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 9:09 [PATCH] drm/amdkfd: Check for null pointer after calling kmemdup Jiasheng Jiang
2022-01-05 15:56 ` Felix Kuehling
2022-01-10 21:23 ` Felix Kuehling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).