dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/tegra: Turn off and reset hardware across suspend-resume
Date: Fri, 15 Nov 2019 14:39:54 +0300	[thread overview]
Message-ID: <3b8e79ad-598c-f0f7-4589-00bb0acc1867@gmail.com> (raw)
In-Reply-To: <20191114203117.GA761559@ulmo>

14.11.2019 23:31, Thierry Reding пишет:
> On Sun, Aug 11, 2019 at 09:39:32PM +0300, Dmitry Osipenko wrote:
>> The drivers core bumps runtime PM refcount during of entering into
>> suspend to workaround some problem where parent device may become turned
>> off before its children. In order to disable and reset CRTCs/HDMI/etc
>> hardware, the runtime PM needs to be "forced" into suspend mode.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>
>> Changelog:
>>
>> v2: The SYSTEM_SLEEP_PM_OPS are now set for all of the relevant drivers and
>>     not only for the DC because turned out that they all should enforce the
>>     suspending.
>>
>>  drivers/gpu/drm/tegra/dc.c    | 2 ++
>>  drivers/gpu/drm/tegra/dpaux.c | 2 ++
>>  drivers/gpu/drm/tegra/dsi.c   | 2 ++
>>  drivers/gpu/drm/tegra/hdmi.c  | 2 ++
>>  drivers/gpu/drm/tegra/hub.c   | 2 ++
>>  drivers/gpu/drm/tegra/sor.c   | 2 ++
>>  drivers/gpu/drm/tegra/vic.c   | 2 ++
>>  7 files changed, 14 insertions(+)
> 
> I'm not exactly sure I understand why this is necessary. Runtime PM is
> controlled by the drivers themselves so that when an output (say SOR) is
> disabled, it drops the runtime PM reference. The idea is that since the
> disabled output is no longer needed it can just go into a low power mode
> which on Tegra usually means clocks off and reset asserted (and in some
> cases also power domain off).
> 
> DRM/KMS has system-level suspend support, which we use to disable all
> outputs when entering suspend. I see that, unfortunately, this doesn't
> seem to actually cause the devices to runtime suspend. I'm pretty sure
> that this used to work at some point, so I don't know what changed. I'd
> have to look into this a little more. The core doing something like this
> behind the driver's back seems wrong and having to force the device into
> suspend mode seems like it's just piling up on the workarounds.

Please let me know if you'll find a better solution.

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/tegra: Turn off and reset hardware across suspend-resume
Date: Fri, 15 Nov 2019 14:39:54 +0300	[thread overview]
Message-ID: <3b8e79ad-598c-f0f7-4589-00bb0acc1867@gmail.com> (raw)
Message-ID: <20191115113954.B4fU5CSd7_peejfu3CmlVVEyhcz7XzKHgtheJ5Qpge4@z> (raw)
In-Reply-To: <20191114203117.GA761559@ulmo>

14.11.2019 23:31, Thierry Reding пишет:
> On Sun, Aug 11, 2019 at 09:39:32PM +0300, Dmitry Osipenko wrote:
>> The drivers core bumps runtime PM refcount during of entering into
>> suspend to workaround some problem where parent device may become turned
>> off before its children. In order to disable and reset CRTCs/HDMI/etc
>> hardware, the runtime PM needs to be "forced" into suspend mode.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>
>> Changelog:
>>
>> v2: The SYSTEM_SLEEP_PM_OPS are now set for all of the relevant drivers and
>>     not only for the DC because turned out that they all should enforce the
>>     suspending.
>>
>>  drivers/gpu/drm/tegra/dc.c    | 2 ++
>>  drivers/gpu/drm/tegra/dpaux.c | 2 ++
>>  drivers/gpu/drm/tegra/dsi.c   | 2 ++
>>  drivers/gpu/drm/tegra/hdmi.c  | 2 ++
>>  drivers/gpu/drm/tegra/hub.c   | 2 ++
>>  drivers/gpu/drm/tegra/sor.c   | 2 ++
>>  drivers/gpu/drm/tegra/vic.c   | 2 ++
>>  7 files changed, 14 insertions(+)
> 
> I'm not exactly sure I understand why this is necessary. Runtime PM is
> controlled by the drivers themselves so that when an output (say SOR) is
> disabled, it drops the runtime PM reference. The idea is that since the
> disabled output is no longer needed it can just go into a low power mode
> which on Tegra usually means clocks off and reset asserted (and in some
> cases also power domain off).
> 
> DRM/KMS has system-level suspend support, which we use to disable all
> outputs when entering suspend. I see that, unfortunately, this doesn't
> seem to actually cause the devices to runtime suspend. I'm pretty sure
> that this used to work at some point, so I don't know what changed. I'd
> have to look into this a little more. The core doing something like this
> behind the driver's back seems wrong and having to force the device into
> suspend mode seems like it's just piling up on the workarounds.

Please let me know if you'll find a better solution.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-11-15 11:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-11 18:39 [PATCH v2] drm/tegra: Turn off and reset hardware across suspend-resume Dmitry Osipenko
2019-11-09 17:01 ` Dmitry Osipenko
2019-11-09 17:01   ` Dmitry Osipenko
2019-11-14 20:31 ` Thierry Reding
2019-11-14 20:31   ` Thierry Reding
2019-11-15 11:39   ` Dmitry Osipenko [this message]
2019-11-15 11:39     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b8e79ad-598c-f0f7-4589-00bb0acc1867@gmail.com \
    --to=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).