Re: [PATCH 20/22] drm/vkms: Use simple encoder

From: Thomas Zimmermann <tzimmermann@suse.de>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: hamohammed.sa@gmail.com, alexandre.belloni@bootlin.com,
	airlied@linux.ie, dri-devel@lists.freedesktop.org,
	sebastian.reichel@collabora.com, paul@crapouillou.net,
	matthias.bgg@gmail.com, wens@csie.org, thierry.reding@gmail.com,
	kraxel@redhat.com, sam@ravnborg.org,
	linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com,
	linux-rockchip@lists.infradead.org, tomi.valkeinen@ti.com,
	abrodkin@synopsys.com, linux@armlinux.org.uk, krzk@kernel.org,
	jonathanh@nvidia.com, xinliang.liu@linaro.org,
	kong.kongxinwei@hisilicon.com, kgene@kernel.org,
	linux-imx@nxp.com, nicolas.ferre@microchip.com,
	puck.chen@hisilicon.com, s.hauer@pengutronix.de,
	alison.wang@nxp.com, jsarha@ti.com,
	linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	jernej.skrabec@siol.net, bbrezillon@kernel.org,
	jingoohan1@gmail.com, sw0312.kim@samsung.com, hjc@rock-chips.com,
	kyungmin.park@samsung.com,
	kieran.bingham+renesas@ideasonboard.com,
	ludovic.desroches@microchip.com, kernel@pengutronix.de,
	zourongrong@gmail.com, shawnguo@kernel.org,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 20/22] drm/vkms: Use simple encoder
Date: Wed, 1 Apr 2020 09:17:20 +0200	[thread overview]
Message-ID: <3c8c9567-2eca-55a7-072e-5d5c9517ba7d@suse.de> (raw)
In-Reply-To: <20200324115905.dp5jqzbmvhbmk2rn@smtp.gmail.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 2852 bytes --]

Hi

Am 24.03.20 um 12:59 schrieb Rodrigo Siqueira:
> Hi Thomas,
> 
> First of all, thanks for your patch!
> 
> I applied all your series, compiled it, and when I tried
> `make INSTALL_MOD_PATH=/PATH/ modules_instal` I got the following
> message:
> 
>  depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper
>  depmod: ERROR: Found 2 modules in dependency cycles!
>  make: *** [Makefile:1317: _modinst_post] Error 1
> 
> I cleaned up my local files and tried again, but I got the same error;
> If I just use `drm-misc-next` everything is fine.  Did I miss something?

I figured out that this problem is caused by the patch for the writeback
encoder, which is located in the DRM core. I'll drop the patch. Thanks
for testing!

Best regards
Thomas

> 
> Thanks
> 
> On 03/05, Thomas Zimmermann wrote:
>> The vkms driver uses an empty implementation for its encoder. Replace
>> the code with the generic simple encoder.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> ---
>>  drivers/gpu/drm/vkms/vkms_output.c | 8 ++------
>>  1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms_output.c
>> index fb1941a6522c..85afb77e97f0 100644
>> --- a/drivers/gpu/drm/vkms/vkms_output.c
>> +++ b/drivers/gpu/drm/vkms/vkms_output.c
>> @@ -3,6 +3,7 @@
>>  #include "vkms_drv.h"
>>  #include <drm/drm_atomic_helper.h>
>>  #include <drm/drm_probe_helper.h>
>> +#include <drm/drm_simple_kms_helper.h>
>>  
>>  static void vkms_connector_destroy(struct drm_connector *connector)
>>  {
>> @@ -17,10 +18,6 @@ static const struct drm_connector_funcs vkms_connector_funcs = {
>>  	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
>>  };
>>  
>> -static const struct drm_encoder_funcs vkms_encoder_funcs = {
>> -	.destroy = drm_encoder_cleanup,
>> -};
>> -
>>  static int vkms_conn_get_modes(struct drm_connector *connector)
>>  {
>>  	int count;
>> @@ -70,8 +67,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int index)
>>  
>>  	drm_connector_helper_add(connector, &vkms_conn_helper_funcs);
>>  
>> -	ret = drm_encoder_init(dev, encoder, &vkms_encoder_funcs,
>> -			       DRM_MODE_ENCODER_VIRTUAL, NULL);
>> +	ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_VIRTUAL);
>>  	if (ret) {
>>  		DRM_ERROR("Failed to init encoder\n");
>>  		goto err_encoder;
>> -- 
>> 2.25.1
>>
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel