From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: hamohammed.sa@gmail.com, alexandre.belloni@bootlin.com,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
sebastian.reichel@collabora.com, paul@crapouillou.net,
matthias.bgg@gmail.com, wens@csie.org, thierry.reding@gmail.com,
kraxel@redhat.com, sam@ravnborg.org,
linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com,
linux-rockchip@lists.infradead.org, tomi.valkeinen@ti.com,
abrodkin@synopsys.com, linux@armlinux.org.uk, krzk@kernel.org,
jonathanh@nvidia.com, xinliang.liu@linaro.org,
kong.kongxinwei@hisilicon.com, kgene@kernel.org,
linux-imx@nxp.com, nicolas.ferre@microchip.com,
puck.chen@hisilicon.com, s.hauer@pengutronix.de,
alison.wang@nxp.com, jsarha@ti.com,
linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org,
jernej.skrabec@siol.net, rodrigosiqueiramelo@gmail.com,
bbrezillon@kernel.org, jingoohan1@gmail.com,
sw0312.kim@samsung.com, hjc@rock-chips.com,
kyungmin.park@samsung.com,
kieran.bingham+renesas@ideasonboard.com,
ludovic.desroches@microchip.com, kernel@pengutronix.de,
zourongrong@gmail.com, shawnguo@kernel.org,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 00/22] drm: Convert drivers to drm_simple_encoder_init()
Date: Fri, 6 Mar 2020 16:10:37 +0100 [thread overview]
Message-ID: <cd96a901-286c-76b3-3fd6-e1bf3c6f6145@suse.de> (raw)
In-Reply-To: <20200306105659.GY2363188@phenom.ffwll.local>
[-- Attachment #1.1.1: Type: text/plain, Size: 7525 bytes --]
Hi
Am 06.03.20 um 11:56 schrieb Daniel Vetter:
> On Thu, Mar 05, 2020 at 04:59:28PM +0100, Thomas Zimmermann wrote:
>> A call to drm_simple_encoder_init() initializes an encoder without
>> further functionality. It only provides the destroy callback to
>> cleanup the encoder's state. Only few drivers implement more
>> sophisticated encoders than that. Most drivers implement such a
>> simple encoder and can use drm_simple_encoder_init() instead.
>>
>> The patchset converts drivers where the encoder's instance is
>> embedded in a larger data structure. The driver releases the
>> memory during cleanup. Each patch replaces drm_encoder_init() with
>> drm_simple_encoder_init() and removes the (now unused) driver's
>> encoder functions.
>>
>> While the patchset is fairly large, the indiviual patches are self-
>> contained and can be merged independently from each other. The
>> simple-encoder functionality is currently in drm-misc-next, where
>> these patches could go as well.
>>
>> Future directions: There's another common case where the driver
>> calls kzalloc() plus drm_encoder_init(). Such drivers are not
>> handled by this patchset. The plan here is to use a simple encoder
>> with either managed memory allocation (once it's merged), or embed
>> the encoder in a larger data structure and drop kzalloc() entirely.
>>
>> The patchset has been compile-tested on x86-64, aarch64 and arm.
>
> So from a cursory look all these drivers get it wrong and devm_kzalloc
> their encoders. But I guess simplifying stuff like you do here will at
> least give us a nice list of things to look at once we get to the
> drmm_simple_encoder_init version of all this. On the series:
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thanks!
>
>>
>> Thomas Zimmermann (22):
>> drm/arc: Use simple encoder
>> drm/atmel-hlcdc: Use simple encoder
>> drm/exynos: Use simple encoder
>> drm/fsl-dcu: Use simple encoder
>> drm/gma500: Use simple encoder
>> drm/hisilicon/kirin: Use simple encoder
>> drm/i2c/tda998x: Use simple encoder
>> drm/imx: Use simple encoder
>> drm/ingenic: Use simple encoder
>> drm/mediatek: Use simple encoder
>> drm/rcar-du: Use simple encoder
>> drm/rockchip: Use simple encoder
>> drm/shmobile: Use simple encoder
>> drm/sun4i: Use simple encoder
>> drm/tegra: Use simple encoder
>> drm/tidss: Use simple encoder
>> drm/tilcdc: Use simple encoder
>> drm/vc4: Use simple encoder
>> drm/virtgpu: Use simple encoder
>> drm/vkms: Use simple encoder
>> drm/writeback: Use simple encoder
>> drm/zte: Use simple encoder
>>
>> drivers/gpu/drm/arc/arcpgu_hdmi.c | 10 +++-------
>> drivers/gpu/drm/arc/arcpgu_sim.c | 8 ++------
>> .../gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 12 ++++--------
>> drivers/gpu/drm/drm_writeback.c | 10 +++-------
>> drivers/gpu/drm/exynos/exynos_dp.c | 8 ++------
>> drivers/gpu/drm/exynos/exynos_drm_dpi.c | 8 ++------
>> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++------
>> drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 ++------
>> drivers/gpu/drm/exynos/exynos_hdmi.c | 8 ++------
>> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 14 +++-----------
>> drivers/gpu/drm/gma500/cdv_intel_crt.c | 14 +++-----------
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 16 +++-------------
>> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 4 ++--
>> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 17 +++--------------
>> drivers/gpu/drm/gma500/mdfld_dsi_dpi.c | 7 +++----
>> drivers/gpu/drm/gma500/mdfld_output.h | 1 -
>> drivers/gpu/drm/gma500/mdfld_tmd_vid.c | 6 ------
>> drivers/gpu/drm/gma500/mdfld_tpo_vid.c | 6 ------
>> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 14 ++------------
>> drivers/gpu/drm/gma500/oaktrail_lvds.c | 5 +++--
>> drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
>> drivers/gpu/drm/gma500/psb_intel_lvds.c | 18 +++---------------
>> drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 5 -----
>> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 8 ++------
>> drivers/gpu/drm/i2c/tda998x_drv.c | 14 +++-----------
>> drivers/gpu/drm/imx/dw_hdmi-imx.c | 8 ++------
>> drivers/gpu/drm/imx/imx-drm-core.c | 6 ------
>> drivers/gpu/drm/imx/imx-drm.h | 1 -
>> drivers/gpu/drm/imx/imx-ldb.c | 8 ++------
>> drivers/gpu/drm/imx/imx-tve.c | 8 ++------
>> drivers/gpu/drm/imx/parallel-display.c | 8 ++------
>> drivers/gpu/drm/ingenic/ingenic-drm.c | 9 +++------
>> drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++-----------
>> drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +++-----------
>> drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 14 +++-----------
>> .../gpu/drm/rockchip/analogix_dp-rockchip.c | 9 +++------
>> drivers/gpu/drm/rockchip/cdn-dp-core.c | 9 +++------
>> .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 8 ++------
>> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 8 ++------
>> drivers/gpu/drm/rockchip/inno_hdmi.c | 8 ++------
>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 8 ++------
>> drivers/gpu/drm/rockchip/rockchip_lvds.c | 10 +++-------
>> drivers/gpu/drm/rockchip/rockchip_rgb.c | 8 ++------
>> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 14 +++-----------
>> drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 12 +++---------
>> drivers/gpu/drm/sun4i/sun4i_lvds.c | 12 +++---------
>> drivers/gpu/drm/sun4i/sun4i_rgb.c | 17 +++--------------
>> drivers/gpu/drm/sun4i/sun4i_tv.c | 17 +++--------------
>> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 12 +++---------
>> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 8 ++------
>> drivers/gpu/drm/tegra/drm.h | 2 --
>> drivers/gpu/drm/tegra/dsi.c | 10 +++-------
>> drivers/gpu/drm/tegra/hdmi.c | 9 +++------
>> drivers/gpu/drm/tegra/output.c | 6 +-----
>> drivers/gpu/drm/tegra/rgb.c | 8 ++------
>> drivers/gpu/drm/tegra/sor.c | 8 ++------
>> drivers/gpu/drm/tidss/tidss_encoder.c | 10 +++-------
>> drivers/gpu/drm/tilcdc/tilcdc_external.c | 10 +++-------
>> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 8 ++------
>> drivers/gpu/drm/vc4/vc4_dpi.c | 8 ++------
>> drivers/gpu/drm/vc4/vc4_dsi.c | 15 +++------------
>> drivers/gpu/drm/vc4/vc4_hdmi.c | 17 ++++-------------
>> drivers/gpu/drm/vc4/vc4_vec.c | 8 ++------
>> drivers/gpu/drm/virtio/virtgpu_display.c | 8 ++------
>> drivers/gpu/drm/vkms/vkms_output.c | 8 ++------
>> drivers/gpu/drm/zte/zx_hdmi.c | 8 ++------
>> drivers/gpu/drm/zte/zx_tvenc.c | 8 ++------
>> drivers/gpu/drm/zte/zx_vga.c | 8 ++------
>> 68 files changed, 151 insertions(+), 488 deletions(-)
>>
>> --
>> 2.25.1
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-06 15:10 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 15:59 [PATCH 00/22] drm: Convert drivers to drm_simple_encoder_init() Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 01/22] drm/arc: Use simple encoder Thomas Zimmermann
2020-03-05 23:48 ` kbuild test robot
2020-03-06 21:18 ` Sam Ravnborg
2020-03-09 7:55 ` Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 02/22] drm/atmel-hlcdc: " Thomas Zimmermann
2020-03-06 0:32 ` kbuild test robot
2020-03-06 21:26 ` Sam Ravnborg
2020-03-05 15:59 ` [PATCH 03/22] drm/exynos: " Thomas Zimmermann
2020-03-06 0:55 ` kbuild test robot
2020-03-06 5:14 ` kbuild test robot
2020-03-06 21:28 ` Sam Ravnborg
2020-03-05 15:59 ` [PATCH 04/22] drm/fsl-dcu: " Thomas Zimmermann
2020-03-06 0:02 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 05/22] drm/gma500: " Thomas Zimmermann
2020-03-06 0:44 ` kbuild test robot
2020-03-06 21:35 ` Sam Ravnborg
2020-03-09 7:32 ` Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 06/22] drm/hisilicon/kirin: " Thomas Zimmermann
2020-03-06 6:16 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 07/22] drm/i2c/tda998x: " Thomas Zimmermann
2020-03-06 7:30 ` kbuild test robot
2020-03-07 15:40 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 08/22] drm/imx: " Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 09/22] drm/ingenic: " Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 10/22] drm/mediatek: " Thomas Zimmermann
2020-03-07 21:26 ` Matthias Brugger
2020-03-10 2:37 ` CK Hu
2020-03-05 15:59 ` [PATCH 11/22] drm/rcar-du: " Thomas Zimmermann
2020-03-06 8:43 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 12/22] drm/rockchip: " Thomas Zimmermann
2020-03-05 23:59 ` kbuild test robot
2020-03-06 10:05 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 13/22] drm/shmobile: " Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 14/22] drm/sun4i: " Thomas Zimmermann
2020-03-06 11:12 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 15/22] drm/tegra: " Thomas Zimmermann
2020-03-06 12:38 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 16/22] drm/tidss: " Thomas Zimmermann
2020-03-06 16:02 ` Jyri Sarha
2020-03-05 15:59 ` [PATCH 17/22] drm/tilcdc: " Thomas Zimmermann
2020-03-06 16:03 ` Jyri Sarha
2020-03-05 15:59 ` [PATCH 18/22] drm/vc4: " Thomas Zimmermann
2020-03-05 17:03 ` Eric Anholt
2020-03-06 13:54 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 19/22] drm/virtgpu: " Thomas Zimmermann
2020-03-07 15:40 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 20/22] drm/vkms: " Thomas Zimmermann
2020-03-06 0:24 ` kbuild test robot
2020-03-07 13:59 ` kbuild test robot
2020-03-24 11:59 ` Rodrigo Siqueira
2020-03-31 9:20 ` Thomas Zimmermann
2020-04-01 7:17 ` Thomas Zimmermann
2020-03-05 15:59 ` [PATCH 21/22] drm/writeback: " Thomas Zimmermann
2020-03-06 0:54 ` kbuild test robot
2020-03-06 1:17 ` kbuild test robot
2020-03-06 14:54 ` kbuild test robot
2020-03-05 15:59 ` [PATCH 22/22] drm/zte: " Thomas Zimmermann
2020-03-06 10:56 ` [PATCH 00/22] drm: Convert drivers to drm_simple_encoder_init() Daniel Vetter
2020-03-06 15:10 ` Thomas Zimmermann [this message]
2020-03-06 14:22 ` Laurent Pinchart
2020-03-06 15:18 ` Thomas Zimmermann
2020-03-07 20:08 ` Sam Ravnborg
2020-03-07 20:34 ` Laurent Pinchart
2020-03-07 20:51 ` Sam Ravnborg
2020-03-09 7:24 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd96a901-286c-76b3-3fd6-e1bf3c6f6145@suse.de \
--to=tzimmermann@suse.de \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=alison.wang@nxp.com \
--cc=bbrezillon@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@siol.net \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=jsarha@ti.com \
--cc=jy0922.shim@samsung.com \
--cc=kernel@pengutronix.de \
--cc=kgene@kernel.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=paul@crapouillou.net \
--cc=puck.chen@hisilicon.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawnguo@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wens@csie.org \
--cc=xinliang.liu@linaro.org \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).