* [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH()
@ 2022-09-14 10:22 Jiapeng Chong
2022-09-14 10:23 ` [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off() Jiapeng Chong
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-09-14 10:22 UTC (permalink / raw)
To: deller; +Cc: Jiapeng Chong, linux-fbdev, Abaci Robot, linux-kernel, dri-devel
The function VAR_MATCH is defined in the controlfb.c file, but not
called elsewhere, so delete this unused function.
drivers/video/fbdev/controlfb.c:111:19: warning: unused function 'VAR_MATCH'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2153
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/video/fbdev/controlfb.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c
index aba46118b208..6bbcd9fc864e 100644
--- a/drivers/video/fbdev/controlfb.c
+++ b/drivers/video/fbdev/controlfb.c
@@ -108,13 +108,6 @@ static inline int PAR_EQUAL(struct fb_par_control *x, struct fb_par_control *y)
return (!DIRTY(cmode) && !DIRTY(xres) && !DIRTY(yres)
&& !DIRTY(vxres) && !DIRTY(vyres));
}
-static inline int VAR_MATCH(struct fb_var_screeninfo *x, struct fb_var_screeninfo *y)
-{
- return (!DIRTY(bits_per_pixel) && !DIRTY(xres)
- && !DIRTY(yres) && !DIRTY(xres_virtual)
- && !DIRTY(yres_virtual)
- && !DIRTY_CMAP(red) && !DIRTY_CMAP(green) && !DIRTY_CMAP(blue));
-}
struct fb_info_control {
struct fb_info info;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off()
2022-09-14 10:22 [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Jiapeng Chong
@ 2022-09-14 10:23 ` Jiapeng Chong
2022-09-25 11:10 ` Helge Deller
2022-09-14 10:23 ` [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg() Jiapeng Chong
2022-09-25 11:11 ` [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Helge Deller
2 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2022-09-14 10:23 UTC (permalink / raw)
To: deller; +Cc: Jiapeng Chong, linux-fbdev, Abaci Robot, linux-kernel, dri-devel
The function shadowmode_off() is defined in the tridentfb.c file, but not
called elsewhere, so delete this unused function.
drivers/video/fbdev/tridentfb.c:1131:20: warning: unused function 'shadowmode_off'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2154
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/video/fbdev/tridentfb.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
index f9c3b1d38fc2..2154dd5e37bd 100644
--- a/drivers/video/fbdev/tridentfb.c
+++ b/drivers/video/fbdev/tridentfb.c
@@ -1128,11 +1128,6 @@ static inline void shadowmode_on(struct tridentfb_par *par)
write3CE(par, CyberControl, read3CE(par, CyberControl) | 0x81);
}
-static inline void shadowmode_off(struct tridentfb_par *par)
-{
- write3CE(par, CyberControl, read3CE(par, CyberControl) & 0x7E);
-}
-
/* Set the hardware to the requested video mode */
static int tridentfb_set_par(struct fb_info *info)
{
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg()
2022-09-14 10:22 [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Jiapeng Chong
2022-09-14 10:23 ` [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off() Jiapeng Chong
@ 2022-09-14 10:23 ` Jiapeng Chong
2022-09-25 11:09 ` Helge Deller
2022-09-25 11:11 ` [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Helge Deller
2 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2022-09-14 10:23 UTC (permalink / raw)
To: deller; +Cc: Jiapeng Chong, linux-fbdev, Abaci Robot, linux-kernel, dri-devel
The function dac_read_reg() is defined in the arkfb.c file, but not
called elsewhere, so delete this unused function.
drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_reg'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2155
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/video/fbdev/arkfb.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
index a317d9fe1d67..5f8fec9e5fd4 100644
--- a/drivers/video/fbdev/arkfb.c
+++ b/drivers/video/fbdev/arkfb.c
@@ -318,14 +318,6 @@ struct dac_info
void *data;
};
-
-static inline u8 dac_read_reg(struct dac_info *info, u8 reg)
-{
- u8 code[2] = {reg, 0};
- info->dac_read_regs(info->data, code, 1);
- return code[1];
-}
-
static inline void dac_read_regs(struct dac_info *info, u8 *code, int count)
{
info->dac_read_regs(info->data, code, count);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg()
2022-09-14 10:23 ` [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg() Jiapeng Chong
@ 2022-09-25 11:09 ` Helge Deller
0 siblings, 0 replies; 6+ messages in thread
From: Helge Deller @ 2022-09-25 11:09 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-fbdev, Abaci Robot, linux-kernel, dri-devel
On 9/14/22 12:23, Jiapeng Chong wrote:
> The function dac_read_reg() is defined in the arkfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_reg'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2155
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
applied.
Thanks,
Helge
> ---
> drivers/video/fbdev/arkfb.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
> index a317d9fe1d67..5f8fec9e5fd4 100644
> --- a/drivers/video/fbdev/arkfb.c
> +++ b/drivers/video/fbdev/arkfb.c
> @@ -318,14 +318,6 @@ struct dac_info
> void *data;
> };
>
> -
> -static inline u8 dac_read_reg(struct dac_info *info, u8 reg)
> -{
> - u8 code[2] = {reg, 0};
> - info->dac_read_regs(info->data, code, 1);
> - return code[1];
> -}
> -
> static inline void dac_read_regs(struct dac_info *info, u8 *code, int count)
> {
> info->dac_read_regs(info->data, code, count);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off()
2022-09-14 10:23 ` [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off() Jiapeng Chong
@ 2022-09-25 11:10 ` Helge Deller
0 siblings, 0 replies; 6+ messages in thread
From: Helge Deller @ 2022-09-25 11:10 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-fbdev, Abaci Robot, linux-kernel, dri-devel
On 9/14/22 12:23, Jiapeng Chong wrote:
> The function shadowmode_off() is defined in the tridentfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/tridentfb.c:1131:20: warning: unused function 'shadowmode_off'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2154
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
applied.
Thanks,
Helge
> ---
> drivers/video/fbdev/tridentfb.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
> index f9c3b1d38fc2..2154dd5e37bd 100644
> --- a/drivers/video/fbdev/tridentfb.c
> +++ b/drivers/video/fbdev/tridentfb.c
> @@ -1128,11 +1128,6 @@ static inline void shadowmode_on(struct tridentfb_par *par)
> write3CE(par, CyberControl, read3CE(par, CyberControl) | 0x81);
> }
>
> -static inline void shadowmode_off(struct tridentfb_par *par)
> -{
> - write3CE(par, CyberControl, read3CE(par, CyberControl) & 0x7E);
> -}
> -
> /* Set the hardware to the requested video mode */
> static int tridentfb_set_par(struct fb_info *info)
> {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH()
2022-09-14 10:22 [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Jiapeng Chong
2022-09-14 10:23 ` [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off() Jiapeng Chong
2022-09-14 10:23 ` [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg() Jiapeng Chong
@ 2022-09-25 11:11 ` Helge Deller
2 siblings, 0 replies; 6+ messages in thread
From: Helge Deller @ 2022-09-25 11:11 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-fbdev, Abaci Robot, linux-kernel, dri-devel
On 9/14/22 12:22, Jiapeng Chong wrote:
> The function VAR_MATCH is defined in the controlfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/controlfb.c:111:19: warning: unused function 'VAR_MATCH'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2153
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
applied.
Thanks,
Helge
> ---
> drivers/video/fbdev/controlfb.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/controlfb.c b/drivers/video/fbdev/controlfb.c
> index aba46118b208..6bbcd9fc864e 100644
> --- a/drivers/video/fbdev/controlfb.c
> +++ b/drivers/video/fbdev/controlfb.c
> @@ -108,13 +108,6 @@ static inline int PAR_EQUAL(struct fb_par_control *x, struct fb_par_control *y)
> return (!DIRTY(cmode) && !DIRTY(xres) && !DIRTY(yres)
> && !DIRTY(vxres) && !DIRTY(vyres));
> }
> -static inline int VAR_MATCH(struct fb_var_screeninfo *x, struct fb_var_screeninfo *y)
> -{
> - return (!DIRTY(bits_per_pixel) && !DIRTY(xres)
> - && !DIRTY(yres) && !DIRTY(xres_virtual)
> - && !DIRTY(yres_virtual)
> - && !DIRTY_CMAP(red) && !DIRTY_CMAP(green) && !DIRTY_CMAP(blue));
> -}
>
> struct fb_info_control {
> struct fb_info info;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-25 11:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-14 10:22 [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Jiapeng Chong
2022-09-14 10:23 ` [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off() Jiapeng Chong
2022-09-25 11:10 ` Helge Deller
2022-09-14 10:23 ` [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg() Jiapeng Chong
2022-09-25 11:09 ` Helge Deller
2022-09-25 11:11 ` [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).