From: Thomas Zimmermann <tzimmermann@suse.de>
To: Takashi Iwai <tiwai@suse.de>, Dave Airlie <airlied@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/ast: Fix missing conversions to managed API
Date: Mon, 26 Apr 2021 20:01:22 +0200 [thread overview]
Message-ID: <3d6d6217-9c51-6722-5ac9-14134cb198b0@suse.de> (raw)
In-Reply-To: <20210421170458.21178-1-tiwai@suse.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 1659 bytes --]
Am 21.04.21 um 19:04 schrieb Takashi Iwai:
> The commit 7cbb93d89838 ("drm/ast: Use managed pci functions")
> converted a few PCI accessors to the managed API and dropped the
> manual pci_iounmap() calls, but it seems to have forgotten converting
> pci_iomap() to the managed one. It resulted in the leftover resources
> after the driver unbind. Let's fix them.
>
> Fixes: 7cbb93d89838 ("drm/ast: Use managed pci functions")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Added to drm-misc-next. Thanks, Takashi.
> ---
> drivers/gpu/drm/ast/ast_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
> index 0ac3c2039c4b..c29cc7f19863 100644
> --- a/drivers/gpu/drm/ast/ast_main.c
> +++ b/drivers/gpu/drm/ast/ast_main.c
> @@ -413,7 +413,7 @@ struct ast_private *ast_device_create(const struct drm_driver *drv,
>
> pci_set_drvdata(pdev, dev);
>
> - ast->regs = pci_iomap(pdev, 1, 0);
> + ast->regs = pcim_iomap(pdev, 1, 0);
> if (!ast->regs)
> return ERR_PTR(-EIO);
>
> @@ -429,7 +429,7 @@ struct ast_private *ast_device_create(const struct drm_driver *drv,
>
> /* "map" IO regs if the above hasn't done so already */
> if (!ast->ioregs) {
> - ast->ioregs = pci_iomap(pdev, 2, 0);
> + ast->ioregs = pcim_iomap(pdev, 2, 0);
> if (!ast->ioregs)
> return ERR_PTR(-EIO);
> }
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2021-04-26 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 17:04 [PATCH] drm/ast: Fix missing conversions to managed API Takashi Iwai
2021-04-26 18:01 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d6d6217-9c51-6722-5ac9-14134cb198b0@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).