From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Conor Dooley <conor@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: alexandre.belloni@bootlin.com, Nayabbasha.Sayed@microchip.com,
dri-devel@lists.freedesktop.org, Hari.PrasathGE@microchip.com,
krzysztof.kozlowski+dt@linaro.org,
Varshini.Rajendran@microchip.com,
Manikandan Muralidharan <manikandan.m@microchip.com>,
sam@ravnborg.org, Balamanikandan.Gunasundar@microchip.com,
lee@kernel.org, Dharma.B@microchip.com,
devicetree@vger.kernel.org, conor+dt@kernel.org,
robh+dt@kernel.org, Durai.ManickamKR@microchip.com,
linux-arm-kernel@lists.infradead.org,
Balakrishnan.S@microchip.com, bbrezillon@kernel.org,
linux-kernel@vger.kernel.org, claudiu.beznea@microchip.com
Subject: Re: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller
Date: Wed, 14 Jun 2023 16:40:50 +0200 [thread overview]
Message-ID: <423eef3c-54f0-5c88-9bc9-82c0198b6da6@microchip.com> (raw)
In-Reply-To: <20230613-slider-coherent-d508d67afc91@spud>
On 13/06/2023 at 20:21, Conor Dooley wrote:
> On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote:
>> On 13/06/2023 09:04, Manikandan Muralidharan wrote:
>>> Add new compatible string for the XLCD controller on SAM9X7 SoC.
>>>
>>> Signed-off-by: Manikandan Muralidharan<manikandan.m@microchip.com>
>>> ---
>>> Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
>>> index 5f8880cc757e..7c77b6bf4adb 100644
>>> --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
>>> @@ -8,6 +8,7 @@ Required properties:
>>> "atmel,sama5d3-hlcdc"
>>> "atmel,sama5d4-hlcdc"
>>> "microchip,sam9x60-hlcdc"
>>> + "microchip,sam9x7-xlcdc"
>> Google says sam9x7 is a series, not a SoC. Please add compatibles for
>> specific SoCs, not for series.
> We had this one a few weeks ago, see
> https://lore.kernel.org/all/add5e49e-8416-ba9f-819a-da944938c05f@microchip.com/
> and its parents. Outcome of that seemed to be that using "sam9x7" was fine.
And it's where it begins to be funny, as the LCD is precisely one aspect
where we differentiate between sam9x75, sam9x72 and sam9x70...
So please Manikandan sort this out if difference between these chips
will be better handled with different compatibility string, in
particular about //, LVDS and MIPI-DSI variants!
Regards,
Nicolas
--
Nicolas Ferre
next prev parent reply other threads:[~2023-06-14 14:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 7:04 [PATCH 0/9] Add support for XLCDC to sam9x7 SoC family Manikandan Muralidharan
2023-06-13 7:04 ` [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller Manikandan Muralidharan
2023-06-13 18:17 ` Krzysztof Kozlowski
2023-06-13 18:21 ` Conor Dooley
2023-06-14 14:40 ` Nicolas Ferre [this message]
2023-06-14 14:58 ` Conor Dooley
2023-06-16 6:44 ` Manikandan.M
2023-06-21 7:47 ` Nicolas Ferre
2023-06-26 5:31 ` Manikandan.M
2023-06-26 17:16 ` Conor Dooley
2023-06-13 18:18 ` Conor Dooley
2023-06-14 10:11 ` Conor Dooley
2023-06-13 7:04 ` [PATCH 2/9] mfd: atmel-hlcdc: Add compatible for SAM9X7 HLCD controller Manikandan Muralidharan
2023-06-21 17:56 ` Lee Jones
2023-06-21 19:12 ` Conor Dooley
2023-06-21 19:59 ` Lee Jones
2023-06-13 7:04 ` [PATCH 3/9] drm: atmel-hlcdc: add LCD controller layer definition for SAM9X7 Manikandan Muralidharan
2023-06-26 20:19 ` Sam Ravnborg
2023-06-13 7:04 ` [PATCH 4/9] drm: atmel-hlcdc: Define SAM9X7 XLCDC specific registers Manikandan Muralidharan
2023-06-14 6:47 ` Claudiu.Beznea
2023-06-15 5:28 ` Manikandan.M
2023-06-13 7:04 ` [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC Manikandan Muralidharan
2023-06-13 18:16 ` Conor Dooley
2023-06-14 10:12 ` Conor Dooley
2023-06-14 6:49 ` Claudiu.Beznea
2023-06-15 5:52 ` Manikandan.M
2023-06-13 7:04 ` [PATCH 6/9] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver Manikandan Muralidharan
2023-06-13 18:17 ` Conor Dooley
2023-06-15 5:59 ` Manikandan.M
2023-06-14 7:10 ` Claudiu.Beznea
2023-06-15 7:31 ` Manikandan.M
2023-06-26 20:49 ` Sam Ravnborg
2023-06-13 7:04 ` [PATCH 7/9] drm: atmel-hlcdc: add DPI mode support for XLCDC Manikandan Muralidharan
2023-06-13 7:04 ` [PATCH 8/9] drm: atmel-hlcdc: add vertical and horizontal scaling " Manikandan Muralidharan
2023-06-13 7:04 ` [PATCH 9/9] drm: atmel-hlcdc: add support for DSI output formats Manikandan Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423eef3c-54f0-5c88-9bc9-82c0198b6da6@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Balakrishnan.S@microchip.com \
--cc=Balamanikandan.Gunasundar@microchip.com \
--cc=Dharma.B@microchip.com \
--cc=Durai.ManickamKR@microchip.com \
--cc=Hari.PrasathGE@microchip.com \
--cc=Nayabbasha.Sayed@microchip.com \
--cc=Varshini.Rajendran@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikandan.m@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).