From: <Claudiu.Beznea@microchip.com>
To: <Manikandan.M@microchip.com>, <lee@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <sam@ravnborg.org>,
<bbrezillon@kernel.org>, <airlied@gmail.com>, <daniel@ffwll.ch>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>
Cc: Balakrishnan.S@microchip.com, Nayabbasha.Sayed@microchip.com,
Balamanikandan.Gunasundar@microchip.com,
Varshini.Rajendran@microchip.com, Dharma.B@microchip.com,
Durai.ManickamKR@microchip.com, Hari.PrasathGE@microchip.com
Subject: Re: [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC
Date: Wed, 14 Jun 2023 06:49:09 +0000 [thread overview]
Message-ID: <f0797746-ee52-582f-48c8-e6497426a7d6@microchip.com> (raw)
In-Reply-To: <20230613070426.467389-6-manikandan.m@microchip.com>
On 13.06.2023 10:04, Manikandan Muralidharan wrote:
> From: Durai Manickam KR <durai.manickamkr@microchip.com>
>
> Add compatible string check to differentiate XLCDC and HLCDC code
> within the atmel-hlcdc driver files.
>
> Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 +++++++
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 1 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index d7ad828e9e8c..fbbd2592efc7 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -761,6 +761,13 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev)
> if (!dc)
> return -ENOMEM;
>
> + /* SAM9X7 supports XLCDC */
> + if (!strcmp(match->compatible, "microchip,sam9x7-xlcdc"))
This could be avoided if ix_xlcd in added in driver data.
> + dc->is_xlcdc = true;
> + else
> + /* Other SoC's that supports HLCDC IP */
> + dc->is_xlcdc = false;
> +
> dc->desc = match->data;
> dc->hlcdc = dev_get_drvdata(dev->dev->parent);
> dev->dev_private = dc;
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h
> index aed1742b3665..804e4d476f2b 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h
> @@ -451,6 +451,7 @@ struct atmel_hlcdc_dc {
> u32 imr;
> struct drm_atomic_state *state;
> } suspend;
> + bool is_xlcdc;
> };
>
> extern struct atmel_hlcdc_formats atmel_hlcdc_plane_rgb_formats;
next prev parent reply other threads:[~2023-06-14 7:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 7:04 [PATCH 0/9] Add support for XLCDC to sam9x7 SoC family Manikandan Muralidharan
2023-06-13 7:04 ` [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller Manikandan Muralidharan
2023-06-13 18:17 ` Krzysztof Kozlowski
2023-06-13 18:21 ` Conor Dooley
2023-06-14 14:40 ` Nicolas Ferre
2023-06-14 14:58 ` Conor Dooley
2023-06-16 6:44 ` Manikandan.M
2023-06-21 7:47 ` Nicolas Ferre
2023-06-26 5:31 ` Manikandan.M
2023-06-26 17:16 ` Conor Dooley
2023-06-13 18:18 ` Conor Dooley
2023-06-14 10:11 ` Conor Dooley
2023-06-13 7:04 ` [PATCH 2/9] mfd: atmel-hlcdc: Add compatible for SAM9X7 HLCD controller Manikandan Muralidharan
2023-06-21 17:56 ` Lee Jones
2023-06-21 19:12 ` Conor Dooley
2023-06-21 19:59 ` Lee Jones
2023-06-13 7:04 ` [PATCH 3/9] drm: atmel-hlcdc: add LCD controller layer definition for SAM9X7 Manikandan Muralidharan
2023-06-26 20:19 ` Sam Ravnborg
2023-06-13 7:04 ` [PATCH 4/9] drm: atmel-hlcdc: Define SAM9X7 XLCDC specific registers Manikandan Muralidharan
2023-06-14 6:47 ` Claudiu.Beznea
2023-06-15 5:28 ` Manikandan.M
2023-06-13 7:04 ` [PATCH 5/9] drm: atmel-hlcdc: add compatible string check for XLCDC and HLCDC Manikandan Muralidharan
2023-06-13 18:16 ` Conor Dooley
2023-06-14 10:12 ` Conor Dooley
2023-06-14 6:49 ` Claudiu.Beznea [this message]
2023-06-15 5:52 ` Manikandan.M
2023-06-13 7:04 ` [PATCH 6/9] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver Manikandan Muralidharan
2023-06-13 18:17 ` Conor Dooley
2023-06-15 5:59 ` Manikandan.M
2023-06-14 7:10 ` Claudiu.Beznea
2023-06-15 7:31 ` Manikandan.M
2023-06-26 20:49 ` Sam Ravnborg
2023-06-13 7:04 ` [PATCH 7/9] drm: atmel-hlcdc: add DPI mode support for XLCDC Manikandan Muralidharan
2023-06-13 7:04 ` [PATCH 8/9] drm: atmel-hlcdc: add vertical and horizontal scaling " Manikandan Muralidharan
2023-06-13 7:04 ` [PATCH 9/9] drm: atmel-hlcdc: add support for DSI output formats Manikandan Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0797746-ee52-582f-48c8-e6497426a7d6@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Balakrishnan.S@microchip.com \
--cc=Balamanikandan.Gunasundar@microchip.com \
--cc=Dharma.B@microchip.com \
--cc=Durai.ManickamKR@microchip.com \
--cc=Hari.PrasathGE@microchip.com \
--cc=Manikandan.M@microchip.com \
--cc=Nayabbasha.Sayed@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Varshini.Rajendran@microchip.com \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).