* [PATCH] drm/rockchip: vop2: add error check to devm_regmap_init_mmio
@ 2023-03-14 19:15 Alfredo Cruz
2023-03-22 21:57 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Alfredo Cruz @ 2023-03-14 19:15 UTC (permalink / raw)
To: hjc, heiko, dri-devel; +Cc: Alfredo Cruz
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 03ca32cd2050..4bde2d354462 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -2680,6 +2680,8 @@ static int vop2_bind(struct device *dev, struct device *master, void *data)
vop2->len = resource_size(res);
vop2->map = devm_regmap_init_mmio(dev, vop2->regs, &vop2_regmap_config);
+ if (IS_ERR(vop2->map))
+ return PTR_ERR(vop2->map);
ret = vop2_win_init(vop2);
if (ret)
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/rockchip: vop2: add error check to devm_regmap_init_mmio
2023-03-14 19:15 [PATCH] drm/rockchip: vop2: add error check to devm_regmap_init_mmio Alfredo Cruz
@ 2023-03-22 21:57 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2023-03-22 21:57 UTC (permalink / raw)
To: hjc, dri-devel, Alfredo Cruz; +Cc: Alfredo Cruz
Hi Alfredo,
while I do agree with the patch content, there are missing:
a patch description ... just a customary thing for a change like this
but more importantly the Signed-off-by line .
Heiko
Am Dienstag, 14. März 2023, 20:15:32 CET schrieb Alfredo Cruz:
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 03ca32cd2050..4bde2d354462 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -2680,6 +2680,8 @@ static int vop2_bind(struct device *dev, struct device *master, void *data)
> vop2->len = resource_size(res);
>
> vop2->map = devm_regmap_init_mmio(dev, vop2->regs, &vop2_regmap_config);
> + if (IS_ERR(vop2->map))
> + return PTR_ERR(vop2->map);
>
> ret = vop2_win_init(vop2);
> if (ret)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-22 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-14 19:15 [PATCH] drm/rockchip: vop2: add error check to devm_regmap_init_mmio Alfredo Cruz
2023-03-22 21:57 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).