From: neil.armstrong@linaro.org
To: Chris Morgan <macroalpha82@gmail.com>,
linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
Chris Morgan <macromorgan@hotmail.com>,
krzysztof.kozlowski+dt@linaro.org, sboyd@kernel.org,
sam@ravnborg.org, mturquette@baylibre.com, javierm@redhat.com,
dri-devel@lists.freedesktop.org, robh+dt@kernel.org,
mripard@kernel.org, tzimmermann@suse.de,
quic_jesszhan@quicinc.com, linux-clk@vger.kernel.org
Subject: Re: [PATCH V2 04/10] drm/panel: himax-hx8394: Add Panel Rotation Support
Date: Tue, 5 Dec 2023 08:56:58 +0100 [thread overview]
Message-ID: <5502597d-cb2f-4fdd-8a2d-c7b6726b18f3@linaro.org> (raw)
In-Reply-To: <20231204185719.569021-5-macroalpha82@gmail.com>
On 04/12/2023 19:57, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add support for setting the rotation property for the Himax HX8394
> panel.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
> drivers/gpu/drm/panel/panel-himax-hx8394.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-himax-hx8394.c b/drivers/gpu/drm/panel/panel-himax-hx8394.c
> index d8e590d5e1da..b68ea09f4725 100644
> --- a/drivers/gpu/drm/panel/panel-himax-hx8394.c
> +++ b/drivers/gpu/drm/panel/panel-himax-hx8394.c
> @@ -68,6 +68,7 @@ struct hx8394 {
> struct gpio_desc *reset_gpio;
> struct regulator *vcc;
> struct regulator *iovcc;
> + enum drm_panel_orientation orientation;
>
> const struct hx8394_panel_desc *desc;
> };
> @@ -324,12 +325,20 @@ static int hx8394_get_modes(struct drm_panel *panel,
> return 1;
> }
>
> +static enum drm_panel_orientation hx8394_get_orientation(struct drm_panel *panel)
> +{
> + struct hx8394 *ctx = panel_to_hx8394(panel);
> +
> + return ctx->orientation;
> +}
> +
> static const struct drm_panel_funcs hx8394_drm_funcs = {
> .disable = hx8394_disable,
> .unprepare = hx8394_unprepare,
> .prepare = hx8394_prepare,
> .enable = hx8394_enable,
> .get_modes = hx8394_get_modes,
> + .get_orientation = hx8394_get_orientation,
> };
>
> static int hx8394_probe(struct mipi_dsi_device *dsi)
> @@ -347,6 +356,12 @@ static int hx8394_probe(struct mipi_dsi_device *dsi)
> return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
> "Failed to get reset gpio\n");
>
> + ret = of_drm_get_panel_orientation(dev->of_node, &ctx->orientation);
> + if (ret < 0) {
> + dev_err(dev, "%pOF: failed to get orientation %d\n", dev->of_node, ret);
> + return ret;
> + }
> +
> mipi_dsi_set_drvdata(dsi, ctx);
>
> ctx->dev = dev;
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-12-05 7:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 18:57 [PATCH V2 00/10] rockchip: Add Powkiddy X55 Chris Morgan
2023-12-04 18:57 ` [PATCH V2 01/10] drm/panel: himax-hx8394: Drop prepare/unprepare tracking Chris Morgan
2023-12-05 7:55 ` neil.armstrong
2023-12-04 18:57 ` [PATCH V2 02/10] drm/panel: himax-hx8394: Drop shutdown logic Chris Morgan
2023-12-05 7:57 ` neil.armstrong
2023-12-04 18:57 ` [PATCH V2 03/10] dt-bindings: display: Document Himax HX8394 panel rotation Chris Morgan
2023-12-04 18:57 ` [PATCH V2 04/10] drm/panel: himax-hx8394: Add Panel Rotation Support Chris Morgan
2023-12-05 7:56 ` neil.armstrong [this message]
2023-12-04 18:57 ` [PATCH V2 05/10] dt-bindings: display: himax-hx8394: Add Powkiddy X55 panel Chris Morgan
2023-12-04 18:57 ` [PATCH V2 06/10] drm/panel: himax-hx8394: Add Support for " Chris Morgan
2023-12-05 7:57 ` neil.armstrong
2023-12-04 18:57 ` [PATCH V2 07/10] clk: rockchip: Mark pclk_usb as critical on rk3568 Chris Morgan
2023-12-04 18:57 ` [PATCH V2 08/10] clk: rockchip: rk3568: Add PLL rate for 126.4MHz Chris Morgan
2023-12-04 18:57 ` [PATCH V2 09/10] dt-bindings: arm: rockchip: Add Powkiddy X55 Chris Morgan
2023-12-04 18:57 ` [PATCH V2 10/10] arm64: dts: " Chris Morgan
2023-12-05 8:26 ` [PATCH V2 00/10] " Neil Armstrong
2023-12-05 8:28 ` Neil Armstrong
2023-12-05 9:41 ` Heiko Stübner
2023-12-05 9:52 ` (subset) " Heiko Stuebner
2023-12-05 9:59 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5502597d-cb2f-4fdd-8a2d-c7b6726b18f3@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).