* [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK
@ 2015-07-23 23:34 Rodrigo Vivi
2015-07-24 0:51 ` [Intel-gfx] " Sivakumar Thulasimani
2015-07-27 11:23 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Rodrigo Vivi @ 2015-07-23 23:34 UTC (permalink / raw)
To: intel-gfx; +Cc: dri-devel, Rodrigo Vivi
By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].
This mask is wrong since when the counter was introduced by myself
on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee
Author: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Date: Tue Sep 16 19:18:12 2014 -0400
drm/i915: Fix Sink CRC
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
include/drm/drm_dp_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 2e86f64..94898f6 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -420,7 +420,7 @@
#define DP_TEST_SINK_MISC 0x246
# define DP_TEST_CRC_SUPPORTED (1 << 5)
-# define DP_TEST_COUNT_MASK 0x7
+# define DP_TEST_COUNT_MASK 0xf
#define DP_TEST_RESPONSE 0x260
# define DP_TEST_ACK (1 << 0)
--
2.1.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK
2015-07-23 23:34 [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK Rodrigo Vivi
@ 2015-07-24 0:51 ` Sivakumar Thulasimani
2015-07-27 11:23 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Sivakumar Thulasimani @ 2015-07-24 0:51 UTC (permalink / raw)
To: Rodrigo Vivi, intel-gfx; +Cc: dri-devel
Reviewed-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
On 7/24/2015 5:04 AM, Rodrigo Vivi wrote:
> By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].
>
> This mask is wrong since when the counter was introduced by myself
> on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee
> Author: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Date: Tue Sep 16 19:18:12 2014 -0400
>
> drm/i915: Fix Sink CRC
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> include/drm/drm_dp_helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 2e86f64..94898f6 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -420,7 +420,7 @@
>
> #define DP_TEST_SINK_MISC 0x246
> # define DP_TEST_CRC_SUPPORTED (1 << 5)
> -# define DP_TEST_COUNT_MASK 0x7
> +# define DP_TEST_COUNT_MASK 0xf
>
> #define DP_TEST_RESPONSE 0x260
> # define DP_TEST_ACK (1 << 0)
--
regards,
Sivakumar
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK
2015-07-23 23:34 [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK Rodrigo Vivi
2015-07-24 0:51 ` [Intel-gfx] " Sivakumar Thulasimani
@ 2015-07-27 11:23 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2015-07-27 11:23 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1141 bytes --]
On Thu, Jul 23, 2015 at 04:34:58PM -0700, Rodrigo Vivi wrote:
> By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].
>
> This mask is wrong since when the counter was introduced by myself
> on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee
> Author: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Date: Tue Sep 16 19:18:12 2014 -0400
>
> drm/i915: Fix Sink CRC
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> include/drm/drm_dp_helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 2e86f64..94898f6 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -420,7 +420,7 @@
>
> #define DP_TEST_SINK_MISC 0x246
> # define DP_TEST_CRC_SUPPORTED (1 << 5)
> -# define DP_TEST_COUNT_MASK 0x7
> +# define DP_TEST_COUNT_MASK 0xf
According to the specification this field should really be called
DP_TEST_CRC_COUNT_MASK, because it counts the number of times that the
TEST_CRC_* registers are updated. That could be a separate patch,
though.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-27 11:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-23 23:34 [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK Rodrigo Vivi
2015-07-24 0:51 ` [Intel-gfx] " Sivakumar Thulasimani
2015-07-27 11:23 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).