[PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Sascha Hauer]

This series adds support for 4k@30 to the rockchip HDMI controller. This
has been tested on a rk3568 rock3a board. It should be possible to add
4k@60 support the same way, but it doesn't work for me, so let's add
4k@30 as a first step.
														     Sascha

Changes since v1:
- Allow non standard clock rates only on Synopsys phy as suggested by
  Robin Murphy

Sascha Hauer (2):
  drm/rockchip: dw_hdmi: relax mode_valid hook
  drm/rockchip: dw_hdmi: Add support for 4k@30 resolution

 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
 1 file changed, 27 insertions(+), 7 deletions(-)

-- 
2.30.2

[PATCH v2 1/2] drm/rockchip: dw_hdmi: relax mode_valid hook

[Sascha Hauer]

The driver checks if the pixel clock of the given mode matches an entry
in the mpll config table. At least for the Synopsys phy the frequencies
in the mpll table are meant as a frequency range up to which the entry
works, not as a frequency that must match the pixel clock. Return
MODE_OK when the pixelclock is smaller than one of the mpll frequencies
to allow for more display resolutions.
Limit this behaviour to the Synopsys phy at the moment and keep the
current behaviour of forcing exact pixelclock rates for the other phys
until it has been sorted out how and if the vendor specific phys work
with non standard clock rates.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---

Notes:
    Changes since v1:
    - Allow non standard clock rates only for the Synopsys phy and stick the
      vendor specific phys to current behaviour.

 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 26 +++++++++++++++------
 1 file changed, 19 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index c14f888938688..6a387780562b1 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -74,6 +74,7 @@ struct rockchip_hdmi {
 	struct regmap *regmap;
 	struct rockchip_encoder encoder;
 	const struct rockchip_hdmi_chip_data *chip_data;
+	const struct dw_hdmi_plat_data *plat_data;
 	struct clk *ref_clk;
 	struct clk *grf_clk;
 	struct dw_hdmi *hdmi;
@@ -241,23 +242,32 @@ static int rockchip_hdmi_parse_dt(struct rockchip_hdmi *hdmi)
 }
 
 static enum drm_mode_status
-dw_hdmi_rockchip_mode_valid(struct dw_hdmi *hdmi, void *data,
+dw_hdmi_rockchip_mode_valid(struct dw_hdmi *dw_hdmi, void *data,
 			    const struct drm_display_info *info,
 			    const struct drm_display_mode *mode)
 {
+	struct rockchip_hdmi *hdmi = data;
 	const struct dw_hdmi_mpll_config *mpll_cfg = rockchip_mpll_cfg;
 	int pclk = mode->clock * 1000;
-	bool valid = false;
+	bool exact_match = hdmi->plat_data->phy_force_vendor;
 	int i;
 
 	for (i = 0; mpll_cfg[i].mpixelclock != (~0UL); i++) {
-		if (pclk == mpll_cfg[i].mpixelclock) {
-			valid = true;
-			break;
-		}
+		/*
+		 * For vendor specific phys force an exact match of the pixelclock
+		 * to preserve the original behaviour of the driver.
+		 */
+		if (exact_match && pclk == mpll_cfg[i].mpixelclock)
+			return MODE_OK;
+		/*
+		 * The Synopsys phy can work with pixelclocks up to the value given
+		 * in the corresponding mpll_cfg entry.
+		 */
+		if (!exact_match && pclk <= mpll_cfg[i].mpixelclock)
+			return MODE_OK;
 	}
 
-	return (valid) ? MODE_OK : MODE_BAD;
+	return MODE_BAD;
 }
 
 static void dw_hdmi_rockchip_encoder_disable(struct drm_encoder *encoder)
@@ -546,8 +556,10 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
 		return -ENOMEM;
 
 	hdmi->dev = &pdev->dev;
+	hdmi->plat_data = plat_data;
 	hdmi->chip_data = plat_data->phy_data;
 	plat_data->phy_data = hdmi;
+	plat_data->priv_data = hdmi;
 	encoder = &hdmi->encoder.encoder;
 
 	encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node);
-- 
2.30.2

[PATCH v2 2/2] drm/rockchip: dw_hdmi: Add support for 4k@30 resolution

[Sascha Hauer]

This adds the PLL/phy settings to support higher resolutions like 4k@30.
The values were taken from the Rockchip downstream Kernel.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index 6a387780562b1..cf86a2936c4d9 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -161,6 +161,12 @@ static const struct dw_hdmi_mpll_config rockchip_mpll_cfg[] = {
 			{ 0x214c, 0x0003},
 			{ 0x4064, 0x0003}
 		},
+	}, {
+		340000000, {
+			{ 0x0052, 0x0003 },
+			{ 0x214d, 0x0003 },
+			{ 0x4065, 0x0003 },
+		},
 	}, {
 		~0UL, {
 			{ 0x00a0, 0x000a },
@@ -186,6 +192,8 @@ static const struct dw_hdmi_curr_ctrl rockchip_cur_ctr[] = {
 		146250000, { 0x0038, 0x0038, 0x0038 },
 	}, {
 		148500000, { 0x0000, 0x0038, 0x0038 },
+	}, {
+		600000000, { 0x0000, 0x0000, 0x0000 },
 	}, {
 		~0UL,      { 0x0000, 0x0000, 0x0000},
 	}
-- 
2.30.2

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Michael Riesch]

Hi Sascha,

On 9/26/22 10:04, Sascha Hauer wrote:
> This series adds support for 4k@30 to the rockchip HDMI controller. This
> has been tested on a rk3568 rock3a board. It should be possible to add
> 4k@60 support the same way, but it doesn't work for me, so let's add
> 4k@30 as a first step.
> 														     Sascha
> 
> Changes since v1:
> - Allow non standard clock rates only on Synopsys phy as suggested by
>   Robin Murphy
> 
> Sascha Hauer (2):
>   drm/rockchip: dw_hdmi: relax mode_valid hook
>   drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
> 
>  drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
>  1 file changed, 27 insertions(+), 7 deletions(-)
Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor

Tested-by: Michael Riesch <michael.riesch@wolfvision.net>

Best regards,
Michael

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Dan Johansen]

Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
> Hi Sascha,
>
> On 9/26/22 10:04, Sascha Hauer wrote:
>> This series adds support for 4k@30 to the rockchip HDMI controller. This
>> has been tested on a rk3568 rock3a board. It should be possible to add
>> 4k@60 support the same way, but it doesn't work for me, so let's add
>> 4k@30 as a first step.
>> 														     Sascha
>>
>> Changes since v1:
>> - Allow non standard clock rates only on Synopsys phy as suggested by
>>    Robin Murphy
>>
>> Sascha Hauer (2):
>>    drm/rockchip: dw_hdmi: relax mode_valid hook
>>    drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
>>
>>   drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
>>   1 file changed, 27 insertions(+), 7 deletions(-)
> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
>
> Tested-by: Michael Riesch <michael.riesch@wolfvision.net>

Sadly this still doesn't give my display out on my 2k monitor. Not even 
just 1080p picture like the old current implementation does.

>
> Best regards,
> Michael
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Sascha Hauer]

On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
> 
> Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
> > Hi Sascha,
> > 
> > On 9/26/22 10:04, Sascha Hauer wrote:
> > > This series adds support for 4k@30 to the rockchip HDMI controller. This
> > > has been tested on a rk3568 rock3a board. It should be possible to add
> > > 4k@60 support the same way, but it doesn't work for me, so let's add
> > > 4k@30 as a first step.
> > > 														     Sascha
> > > 
> > > Changes since v1:
> > > - Allow non standard clock rates only on Synopsys phy as suggested by
> > >    Robin Murphy
> > > 
> > > Sascha Hauer (2):
> > >    drm/rockchip: dw_hdmi: relax mode_valid hook
> > >    drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
> > > 
> > >   drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
> > >   1 file changed, 27 insertions(+), 7 deletions(-)
> > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
> > 
> > Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
> 
> Sadly this still doesn't give my display out on my 2k monitor. Not even just
> 1080p picture like the old current implementation does.

By "like the old current implementation" you mean that this patchset
introduces a regression for you?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Dan Johansen]

Den 28.09.2022 kl. 10.37 skrev Sascha Hauer:
> On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
>> Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
>>> Hi Sascha,
>>>
>>> On 9/26/22 10:04, Sascha Hauer wrote:
>>>> This series adds support for 4k@30 to the rockchip HDMI controller. This
>>>> has been tested on a rk3568 rock3a board. It should be possible to add
>>>> 4k@60 support the same way, but it doesn't work for me, so let's add
>>>> 4k@30 as a first step.
>>>> 														     Sascha
>>>>
>>>> Changes since v1:
>>>> - Allow non standard clock rates only on Synopsys phy as suggested by
>>>>     Robin Murphy
>>>>
>>>> Sascha Hauer (2):
>>>>     drm/rockchip: dw_hdmi: relax mode_valid hook
>>>>     drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
>>>>
>>>>    drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
>>>>    1 file changed, 27 insertions(+), 7 deletions(-)
>>> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
>>>
>>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
>> Sadly this still doesn't give my display out on my 2k monitor. Not even just
>> 1080p picture like the old current implementation does.
> By "like the old current implementation" you mean that this patchset
> introduces a regression for you?
Yes. What currently in the kernel at least shows as 1080p on my 2K 
monitor, while this patchset turns off the screen.
>
> Sascha
>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Sascha Hauer]

On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote:
> 
> Den 28.09.2022 kl. 10.37 skrev Sascha Hauer:
> > On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
> > > Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
> > > > Hi Sascha,
> > > > 
> > > > On 9/26/22 10:04, Sascha Hauer wrote:
> > > > > This series adds support for 4k@30 to the rockchip HDMI controller. This
> > > > > has been tested on a rk3568 rock3a board. It should be possible to add
> > > > > 4k@60 support the same way, but it doesn't work for me, so let's add
> > > > > 4k@30 as a first step.
> > > > > 														     Sascha
> > > > > 
> > > > > Changes since v1:
> > > > > - Allow non standard clock rates only on Synopsys phy as suggested by
> > > > >     Robin Murphy
> > > > > 
> > > > > Sascha Hauer (2):
> > > > >     drm/rockchip: dw_hdmi: relax mode_valid hook
> > > > >     drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
> > > > > 
> > > > >    drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
> > > > >    1 file changed, 27 insertions(+), 7 deletions(-)
> > > > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
> > > > 
> > > > Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
> > > Sadly this still doesn't give my display out on my 2k monitor. Not even just
> > > 1080p picture like the old current implementation does.
> > By "like the old current implementation" you mean that this patchset
> > introduces a regression for you?
> Yes. What currently in the kernel at least shows as 1080p on my 2K monitor,
> while this patchset turns off the screen.

Which SoC are you testing this on? I assume RK3568, right? Which patch
introduces that regression, the first or the second one?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Dan Johansen]

Den 05.10.2022 kl. 12.06 skrev Sascha Hauer:
> On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote:
>> Den 28.09.2022 kl. 10.37 skrev Sascha Hauer:
>>> On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
>>>> Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
>>>>> Hi Sascha,
>>>>>
>>>>> On 9/26/22 10:04, Sascha Hauer wrote:
>>>>>> This series adds support for 4k@30 to the rockchip HDMI controller. This
>>>>>> has been tested on a rk3568 rock3a board. It should be possible to add
>>>>>> 4k@60 support the same way, but it doesn't work for me, so let's add
>>>>>> 4k@30 as a first step.
>>>>>> 														     Sascha
>>>>>>
>>>>>> Changes since v1:
>>>>>> - Allow non standard clock rates only on Synopsys phy as suggested by
>>>>>>      Robin Murphy
>>>>>>
>>>>>> Sascha Hauer (2):
>>>>>>      drm/rockchip: dw_hdmi: relax mode_valid hook
>>>>>>      drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
>>>>>>
>>>>>>     drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
>>>>>>     1 file changed, 27 insertions(+), 7 deletions(-)
>>>>> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
>>>>>
>>>>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
>>>> Sadly this still doesn't give my display out on my 2k monitor. Not even just
>>>> 1080p picture like the old current implementation does.
>>> By "like the old current implementation" you mean that this patchset
>>> introduces a regression for you?
>> Yes. What currently in the kernel at least shows as 1080p on my 2K monitor,
>> while this patchset turns off the screen.
> Which SoC are you testing this on? I assume RK3568, right? Which patch
> introduces that regression, the first or the second one?
I tested on the Odroid M, which is rk3568.
I have only applied them both, as I was under the impression that both 
are needed for the 4k support.
>
> Sascha
>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Sascha Hauer]

On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote:
> 
> Den 05.10.2022 kl. 12.06 skrev Sascha Hauer:
> > On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote:
> > > Den 28.09.2022 kl. 10.37 skrev Sascha Hauer:
> > > > On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
> > > > > Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
> > > > > > Hi Sascha,
> > > > > > 
> > > > > > On 9/26/22 10:04, Sascha Hauer wrote:
> > > > > > > This series adds support for 4k@30 to the rockchip HDMI controller. This
> > > > > > > has been tested on a rk3568 rock3a board. It should be possible to add
> > > > > > > 4k@60 support the same way, but it doesn't work for me, so let's add
> > > > > > > 4k@30 as a first step.
> > > > > > > 														     Sascha
> > > > > > > 
> > > > > > > Changes since v1:
> > > > > > > - Allow non standard clock rates only on Synopsys phy as suggested by
> > > > > > >      Robin Murphy
> > > > > > > 
> > > > > > > Sascha Hauer (2):
> > > > > > >      drm/rockchip: dw_hdmi: relax mode_valid hook
> > > > > > >      drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
> > > > > > > 
> > > > > > >     drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
> > > > > > >     1 file changed, 27 insertions(+), 7 deletions(-)
> > > > > > Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
> > > > > > 
> > > > > > Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
> > > > > Sadly this still doesn't give my display out on my 2k monitor. Not even just
> > > > > 1080p picture like the old current implementation does.
> > > > By "like the old current implementation" you mean that this patchset
> > > > introduces a regression for you?
> > > Yes. What currently in the kernel at least shows as 1080p on my 2K monitor,
> > > while this patchset turns off the screen.
> > Which SoC are you testing this on? I assume RK3568, right? Which patch
> > introduces that regression, the first or the second one?
> I tested on the Odroid M, which is rk3568.
> I have only applied them both, as I was under the impression that both are
> needed for the 4k support.

Yes, both I needed, but I am interested which one introduces the
regression as I can't reproduce it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Robin Murphy]

On 2022-10-05 12:10, Sascha Hauer wrote:
> On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote:
>>
>> Den 05.10.2022 kl. 12.06 skrev Sascha Hauer:
>>> On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote:
>>>> Den 28.09.2022 kl. 10.37 skrev Sascha Hauer:
>>>>> On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
>>>>>> Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
>>>>>>> Hi Sascha,
>>>>>>>
>>>>>>> On 9/26/22 10:04, Sascha Hauer wrote:
>>>>>>>> This series adds support for 4k@30 to the rockchip HDMI controller. This
>>>>>>>> has been tested on a rk3568 rock3a board. It should be possible to add
>>>>>>>> 4k@60 support the same way, but it doesn't work for me, so let's add
>>>>>>>> 4k@30 as a first step.
>>>>>>>> 														     Sascha
>>>>>>>>
>>>>>>>> Changes since v1:
>>>>>>>> - Allow non standard clock rates only on Synopsys phy as suggested by
>>>>>>>>       Robin Murphy
>>>>>>>>
>>>>>>>> Sascha Hauer (2):
>>>>>>>>       drm/rockchip: dw_hdmi: relax mode_valid hook
>>>>>>>>       drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
>>>>>>>>
>>>>>>>>      drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
>>>>>>>>      1 file changed, 27 insertions(+), 7 deletions(-)
>>>>>>> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
>>>>>>>
>>>>>>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
>>>>>> Sadly this still doesn't give my display out on my 2k monitor. Not even just
>>>>>> 1080p picture like the old current implementation does.
>>>>> By "like the old current implementation" you mean that this patchset
>>>>> introduces a regression for you?
>>>> Yes. What currently in the kernel at least shows as 1080p on my 2K monitor,
>>>> while this patchset turns off the screen.
>>> Which SoC are you testing this on? I assume RK3568, right? Which patch
>>> introduces that regression, the first or the second one?
>> I tested on the Odroid M, which is rk3568.
>> I have only applied them both, as I was under the impression that both are
>> needed for the 4k support.
> 
> Yes, both I needed, but I am interested which one introduces the
> regression as I can't reproduce it.

One thing that might be worthwhile is to compare what "drm.debug=4" 
output says about the chosen mode and its clock rate vs. what 
/sys/kernel/debug/clk/clk_summary says about how things ended up in 
practice, to see whether it's a case of the clock not being able to get 
close enough to the correct rate at all.

Robin.

Re: [PATCH v2 0/2] drm/rockchip: dw_hdmi: Add 4k@30 support

[Dan Johansen]

Den 05.10.2022 kl. 13.10 skrev Sascha Hauer:
> On Wed, Oct 05, 2022 at 12:51:57PM +0200, Dan Johansen wrote:
>> Den 05.10.2022 kl. 12.06 skrev Sascha Hauer:
>>> On Wed, Sep 28, 2022 at 10:39:27AM +0200, Dan Johansen wrote:
>>>> Den 28.09.2022 kl. 10.37 skrev Sascha Hauer:
>>>>> On Tue, Sep 27, 2022 at 07:53:54PM +0200, Dan Johansen wrote:
>>>>>> Den 26.09.2022 kl. 12.30 skrev Michael Riesch:
>>>>>>> Hi Sascha,
>>>>>>>
>>>>>>> On 9/26/22 10:04, Sascha Hauer wrote:
>>>>>>>> This series adds support for 4k@30 to the rockchip HDMI controller. This
>>>>>>>> has been tested on a rk3568 rock3a board. It should be possible to add
>>>>>>>> 4k@60 support the same way, but it doesn't work for me, so let's add
>>>>>>>> 4k@30 as a first step.
>>>>>>>> 														     Sascha
>>>>>>>>
>>>>>>>> Changes since v1:
>>>>>>>> - Allow non standard clock rates only on Synopsys phy as suggested by
>>>>>>>>       Robin Murphy
>>>>>>>>
>>>>>>>> Sascha Hauer (2):
>>>>>>>>       drm/rockchip: dw_hdmi: relax mode_valid hook
>>>>>>>>       drm/rockchip: dw_hdmi: Add support for 4k@30 resolution
>>>>>>>>
>>>>>>>>      drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 34 ++++++++++++++++-----
>>>>>>>>      1 file changed, 27 insertions(+), 7 deletions(-)
>>>>>>> Thanks for the v2! On a RK3568 EVB1 with a HP 27f 4k monitor
>>>>>>>
>>>>>>> Tested-by: Michael Riesch <michael.riesch@wolfvision.net>
>>>>>> Sadly this still doesn't give my display out on my 2k monitor. Not even just
>>>>>> 1080p picture like the old current implementation does.
>>>>> By "like the old current implementation" you mean that this patchset
>>>>> introduces a regression for you?
>>>> Yes. What currently in the kernel at least shows as 1080p on my 2K monitor,
>>>> while this patchset turns off the screen.
>>> Which SoC are you testing this on? I assume RK3568, right? Which patch
>>> introduces that regression, the first or the second one?
>> I tested on the Odroid M, which is rk3568.
>> I have only applied them both, as I was under the impression that both are
>> needed for the 4k support.
> Yes, both I needed, but I am interested which one introduces the
> regression as I can't reproduce it.

Okay. Here's the result of some more tests of mine.

Patch 1 by itself does not introduce any regressions on either 1080p or 
2k monitors.

Patch 2 by itself does not introduce any regressions on either 1080p or 
2k monitors.

Applying both Patch 1 and 2, _does_ introduce the regression on my 2k 
monitor, but _not_ on my 1080p monitor.

The 2k monitor is a Dell P2418D with up to 2560x1440 resolution.

The 1080p monitor is a Sony Bravia 46" TV with up to 1920x1080 resolution.

>
> Sascha
>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>