From: Jyri Sarha <jsarha@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<dri-devel@lists.freedesktop.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH] drm/tidss: Use drm_for_each_bridge_in_chain()
Date: Thu, 27 Feb 2020 12:00:24 +0200 [thread overview]
Message-ID: <5c43bfaa-9f53-5a42-d467-7a78966943e3@ti.com> (raw)
In-Reply-To: <20200222110718.26272-1-laurent.pinchart@ideasonboard.com>
On 22/02/2020 13:07, Laurent Pinchart wrote:
> Replace the manual encoder->bridge_chain walk with the
> drm_for_each_bridge_in_chain() macro. Drivers should not touch the
> bridge_chain field directly.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jyri Sarha <jsarha@ti.com>
Tested-by: Jyri Sarha <jsarha@ti.com>
I'll merge this to drm-misc-next tomorrow.
Thank you for the patch,
Jyri
> ---
> drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c
> index f7fe3a43ead0..83785b0a66a9 100644
> --- a/drivers/gpu/drm/tidss/tidss_encoder.c
> +++ b/drivers/gpu/drm/tidss/tidss_encoder.c
> @@ -32,7 +32,7 @@ static int tidss_encoder_atomic_check(struct drm_encoder *encoder,
> * bridge timings, or from the connector's display_info if no
> * bridge defines the timings.
> */
> - list_for_each_entry(bridge, &encoder->bridge_chain, chain_node) {
> + drm_for_each_bridge_in_chain(encoder, bridge) {
> if (!bridge->timings)
> continue;
>
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-02-27 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 11:07 [PATCH] drm/tidss: Use drm_for_each_bridge_in_chain() Laurent Pinchart
2020-02-27 10:00 ` Jyri Sarha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c43bfaa-9f53-5a42-d467-7a78966943e3@ti.com \
--to=jsarha@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).