dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/tidss: Use drm_for_each_bridge_in_chain()
@ 2020-02-22 11:07 Laurent Pinchart
  2020-02-27 10:00 ` Jyri Sarha
  0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2020-02-22 11:07 UTC (permalink / raw)
  To: dri-devel; +Cc: Tomi Valkeinen, Jyri Sarha

Replace the manual encoder->bridge_chain walk with the
drm_for_each_bridge_in_chain() macro. Drivers should not touch the
bridge_chain field directly.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c
index f7fe3a43ead0..83785b0a66a9 100644
--- a/drivers/gpu/drm/tidss/tidss_encoder.c
+++ b/drivers/gpu/drm/tidss/tidss_encoder.c
@@ -32,7 +32,7 @@ static int tidss_encoder_atomic_check(struct drm_encoder *encoder,
 	 * bridge timings, or from the connector's display_info if no
 	 * bridge defines the timings.
 	 */
-	list_for_each_entry(bridge, &encoder->bridge_chain, chain_node) {
+	drm_for_each_bridge_in_chain(encoder, bridge) {
 		if (!bridge->timings)
 			continue;
 
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/tidss: Use drm_for_each_bridge_in_chain()
  2020-02-22 11:07 [PATCH] drm/tidss: Use drm_for_each_bridge_in_chain() Laurent Pinchart
@ 2020-02-27 10:00 ` Jyri Sarha
  0 siblings, 0 replies; 2+ messages in thread
From: Jyri Sarha @ 2020-02-27 10:00 UTC (permalink / raw)
  To: Laurent Pinchart, dri-devel; +Cc: Tomi Valkeinen

On 22/02/2020 13:07, Laurent Pinchart wrote:
> Replace the manual encoder->bridge_chain walk with the
> drm_for_each_bridge_in_chain() macro. Drivers should not touch the
> bridge_chain field directly.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jyri Sarha <jsarha@ti.com>
Tested-by: Jyri Sarha <jsarha@ti.com>

I'll merge this to drm-misc-next tomorrow.

Thank you for the patch,
Jyri

> ---
>  drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c
> index f7fe3a43ead0..83785b0a66a9 100644
> --- a/drivers/gpu/drm/tidss/tidss_encoder.c
> +++ b/drivers/gpu/drm/tidss/tidss_encoder.c
> @@ -32,7 +32,7 @@ static int tidss_encoder_atomic_check(struct drm_encoder *encoder,
>  	 * bridge timings, or from the connector's display_info if no
>  	 * bridge defines the timings.
>  	 */
> -	list_for_each_entry(bridge, &encoder->bridge_chain, chain_node) {
> +	drm_for_each_bridge_in_chain(encoder, bridge) {
>  		if (!bridge->timings)
>  			continue;
>  
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-27 10:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-22 11:07 [PATCH] drm/tidss: Use drm_for_each_bridge_in_chain() Laurent Pinchart
2020-02-27 10:00 ` Jyri Sarha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).