* [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
@ 2022-09-02 13:01 Greg Kroah-Hartman
2022-09-02 13:10 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-02 13:01 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deuc her,
Christian König, Xinhui.Pan
Cc: Jiapeng Chong, Leo Li, Greg Kroah-Hartman, dri-devel,
Bhanuprakash Modem, Wenjing Liu, linux-kernel, David Airlie,
Fangzhi Zuo, hersen wu, amd-gfx, Wayne Lin, Sean Paul,
Yongzhi Liu, Mikita Lipski, Thelford Williams
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. Fix this up by properly
calling dput().
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Wayne Lin <Wayne.Lin@amd.com>
Cc: hersen wu <hersenxs.wu@amd.com>
Cc: Wenjing Liu <wenjing.liu@amd.com>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: Thelford Williams <tdwilliamsiv@gmail.com>
Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
Cc: Mikita Lipski <mikita.lipski@amd.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
index 0e48824f55e3..ee242d9d8b06 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -3288,6 +3288,7 @@ void crtc_debugfs_init(struct drm_crtc *crtc)
&crc_win_y_end_fops);
debugfs_create_file_unsafe("crc_win_update", 0644, dir, crtc,
&crc_win_update_fops);
+ dput(dir);
#endif
debugfs_create_file("amdgpu_current_bpc", 0644, crtc->debugfs_entry,
crtc, &amdgpu_current_bpc_fops);
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
2022-09-02 13:01 [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup() Greg Kroah-Hartman
@ 2022-09-02 13:10 ` Greg Kroah-Hartman
2022-09-06 14:52 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-02 13:10 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deuc her,
Christian König, Xinhui.Pan
Cc: Jiapeng Chong, Leo Li, dri-devel, Bhanuprakash Modem,
Wenjing Liu, linux-kernel, David Airlie, Fangzhi Zuo, hersen wu,
amd-gfx, Wayne Lin, Sean Paul, Yongzhi Liu, Mikita Lipski,
Thelford Williams
On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs_lookup() the result must have dput() called on it,
> otherwise the memory will leak over time. Fix this up by properly
> calling dput().
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Wayne Lin <Wayne.Lin@amd.com>
> Cc: hersen wu <hersenxs.wu@amd.com>
> Cc: Wenjing Liu <wenjing.liu@amd.com>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Cc: Thelford Williams <tdwilliamsiv@gmail.com>
> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
> Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
> Cc: Mikita Lipski <mikita.lipski@amd.com>
> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
Despite a zillion cc: items, I forgot to cc: stable on this. Can the
maintainer add that here, or do you all want me to resend it with that
item added?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
2022-09-02 13:10 ` Greg Kroah-Hartman
@ 2022-09-06 14:52 ` Rodrigo Siqueira Jordao
2022-09-06 15:06 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-06 14:52 UTC (permalink / raw)
To: Greg Kroah-Hartman, Harry Wentland, Leo Li, Alex Deuc her,
Christian König, Xinhui.Pan
Cc: Jiapeng Chong, David Airlie, dri-devel, Bhanuprakash Modem,
Wenjing Liu, linux-kernel, Yongzhi Liu, Fangzhi Zuo, hersen wu,
amd-gfx, Wayne Lin, Sean Paul, Mikita Lipski, Thelford Williams
On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
>> When calling debugfs_lookup() the result must have dput() called on it,
>> otherwise the memory will leak over time. Fix this up by properly
>> calling dput().
>>
>> Cc: Harry Wentland <harry.wentland@amd.com>
>> Cc: Leo Li <sunpeng.li@amd.com>
>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Cc: "Christian König" <christian.koenig@amd.com>
>> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Wayne Lin <Wayne.Lin@amd.com>
>> Cc: hersen wu <hersenxs.wu@amd.com>
>> Cc: Wenjing Liu <wenjing.liu@amd.com>
>> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>> Cc: Thelford Williams <tdwilliamsiv@gmail.com>
>> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
>> Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
>> Cc: Mikita Lipski <mikita.lipski@amd.com>
>> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> Cc: Sean Paul <seanpaul@chromium.org>
>> Cc: amd-gfx@lists.freedesktop.org
>> Cc: dri-devel@lists.freedesktop.org
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
>
> Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> maintainer add that here, or do you all want me to resend it with that
> item added?
>
> thanks,
>
> greg k-h
Hi Greg,
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Is 'Cc: stable@vger.kernel.org' enough here? I can make this change
before I merge it into amd-staging-drm-next.
Thanks
Siqueira
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
2022-09-06 14:52 ` Rodrigo Siqueira Jordao
@ 2022-09-06 15:06 ` Greg Kroah-Hartman
2022-09-06 15:39 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-06 15:06 UTC (permalink / raw)
To: Rodrigo Siqueira Jordao
Cc: Sean Paul, Jiapeng Chong, Leo Li, dri-devel, Xinhui.Pan,
Wenjing Liu, linux-kernel, David Airlie, Fangzhi Zuo, hersen wu,
amd-gfx, Wayne Lin, Alex Deuc her, Bhanuprakash Modem,
Yongzhi Liu, Mikita Lipski, Christian König,
Thelford Williams
On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs_lookup() the result must have dput() called on it,
> > > otherwise the memory will leak over time. Fix this up by properly
> > > calling dput().
> > >
> > > Cc: Harry Wentland <harry.wentland@amd.com>
> > > Cc: Leo Li <sunpeng.li@amd.com>
> > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > Cc: "Christian König" <christian.koenig@amd.com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > Cc: David Airlie <airlied@linux.ie>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: Wayne Lin <Wayne.Lin@amd.com>
> > > Cc: hersen wu <hersenxs.wu@amd.com>
> > > Cc: Wenjing Liu <wenjing.liu@amd.com>
> > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > > Cc: Thelford Williams <tdwilliamsiv@gmail.com>
> > > Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
> > > Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
> > > Cc: Mikita Lipski <mikita.lipski@amd.com>
> > > Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > > Cc: Sean Paul <seanpaul@chromium.org>
> > > Cc: amd-gfx@lists.freedesktop.org
> > > Cc: dri-devel@lists.freedesktop.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> >
> > Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> > maintainer add that here, or do you all want me to resend it with that
> > item added?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>
> Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I
> merge it into amd-staging-drm-next.
Yes, please add the cc: stable@ line to the body of the patch, sorry I
forgot that.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
2022-09-06 15:06 ` Greg Kroah-Hartman
@ 2022-09-06 15:39 ` Rodrigo Siqueira Jordao
2022-09-06 15:49 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Rodrigo Siqueira Jordao @ 2022-09-06 15:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Sean Paul, Jiapeng Chong, Leo Li, dri-devel, Xinhui.Pan,
Wenjing Liu, linux-kernel, David Airlie, Fangzhi Zuo, hersen wu,
amd-gfx, Wayne Lin, Alex Deuc her, Bhanuprakash Modem,
Yongzhi Liu, Mikita Lipski, Christian König,
Thelford Williams
On 2022-09-06 11:06, Greg Kroah-Hartman wrote:
> On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>>
>>
>> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
>>> On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
>>>> When calling debugfs_lookup() the result must have dput() called on it,
>>>> otherwise the memory will leak over time. Fix this up by properly
>>>> calling dput().
>>>>
>>>> Cc: Harry Wentland <harry.wentland@amd.com>
>>>> Cc: Leo Li <sunpeng.li@amd.com>
>>>> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>>> Cc: "Christian König" <christian.koenig@amd.com>
>>>> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
>>>> Cc: David Airlie <airlied@linux.ie>
>>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>>> Cc: Wayne Lin <Wayne.Lin@amd.com>
>>>> Cc: hersen wu <hersenxs.wu@amd.com>
>>>> Cc: Wenjing Liu <wenjing.liu@amd.com>
>>>> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
>>>> Cc: Thelford Williams <tdwilliamsiv@gmail.com>
>>>> Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
>>>> Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
>>>> Cc: Mikita Lipski <mikita.lipski@amd.com>
>>>> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>>>> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>>>> Cc: Sean Paul <seanpaul@chromium.org>
>>>> Cc: amd-gfx@lists.freedesktop.org
>>>> Cc: dri-devel@lists.freedesktop.org
>>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>> ---
>>>
>>> Despite a zillion cc: items, I forgot to cc: stable on this. Can the
>>> maintainer add that here, or do you all want me to resend it with that
>>> item added?
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Hi Greg,
>>
>> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
>>
>> Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I
>> merge it into amd-staging-drm-next.
>
> Yes, please add the cc: stable@ line to the body of the patch, sorry I
> forgot that.
>
Change applied to amd-staging-drm-next, with the Cc to the stable branch.
Thanks
Siqueira
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()
2022-09-06 15:39 ` Rodrigo Siqueira Jordao
@ 2022-09-06 15:49 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-09-06 15:49 UTC (permalink / raw)
To: Rodrigo Siqueira Jordao
Cc: Sean Paul, Jiapeng Chong, Leo Li, dri-devel, Xinhui.Pan,
Wenjing Liu, linux-kernel, David Airlie, Fangzhi Zuo, hersen wu,
amd-gfx, Wayne Lin, Alex Deuc her, Bhanuprakash Modem,
Yongzhi Liu, Mikita Lipski, Christian König,
Thelford Williams
On Tue, Sep 06, 2022 at 11:39:44AM -0400, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-09-06 11:06, Greg Kroah-Hartman wrote:
> > On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
> > >
> > >
> > > On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > > > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > > > When calling debugfs_lookup() the result must have dput() called on it,
> > > > > otherwise the memory will leak over time. Fix this up by properly
> > > > > calling dput().
> > > > >
> > > > > Cc: Harry Wentland <harry.wentland@amd.com>
> > > > > Cc: Leo Li <sunpeng.li@amd.com>
> > > > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > > > > Cc: Alex Deucher <alexander.deucher@amd.com>
> > > > > Cc: "Christian König" <christian.koenig@amd.com>
> > > > > Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> > > > > Cc: David Airlie <airlied@linux.ie>
> > > > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > > > Cc: Wayne Lin <Wayne.Lin@amd.com>
> > > > > Cc: hersen wu <hersenxs.wu@amd.com>
> > > > > Cc: Wenjing Liu <wenjing.liu@amd.com>
> > > > > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > > > > Cc: Thelford Williams <tdwilliamsiv@gmail.com>
> > > > > Cc: Fangzhi Zuo <Jerry.Zuo@amd.com>
> > > > > Cc: Yongzhi Liu <lyz_cs@pku.edu.cn>
> > > > > Cc: Mikita Lipski <mikita.lipski@amd.com>
> > > > > Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > > > > Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > > > > Cc: Sean Paul <seanpaul@chromium.org>
> > > > > Cc: amd-gfx@lists.freedesktop.org
> > > > > Cc: dri-devel@lists.freedesktop.org
> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > > ---
> > > >
> > > > Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> > > > maintainer add that here, or do you all want me to resend it with that
> > > > item added?
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > Hi Greg,
> > >
> > > Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> > >
> > > Is 'Cc: stable@vger.kernel.org' enough here? I can make this change before I
> > > merge it into amd-staging-drm-next.
> >
> > Yes, please add the cc: stable@ line to the body of the patch, sorry I
> > forgot that.
> >
>
> Change applied to amd-staging-drm-next, with the Cc to the stable branch.
Wonderful, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-06 15:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-02 13:01 [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup() Greg Kroah-Hartman
2022-09-02 13:10 ` Greg Kroah-Hartman
2022-09-06 14:52 ` Rodrigo Siqueira Jordao
2022-09-06 15:06 ` Greg Kroah-Hartman
2022-09-06 15:39 ` Rodrigo Siqueira Jordao
2022-09-06 15:49 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).