* [PATCH] drm/imx: imx-tve: Delete an error message in imx_tve_bind()
@ 2020-04-05 9:16 Markus Elfring
2020-07-20 13:22 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-04-05 9:16 UTC (permalink / raw)
To: dri-devel, linux-arm-kernel, linux-imx, kernel, Fabio Estevam,
Daniel Vetter, David Airlie, Philipp Zabel, Sascha Hauer,
Shawn Guo
Cc: kernel-janitors, LKML, Tang Bin
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 11:01:49 +0200
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/imx/imx-tve.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index 5bbfaa2cd0f4..23adbb818d92 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -598,10 +598,8 @@ static int imx_tve_bind(struct device *dev, struct device *master, void *data)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "failed to get irq\n");
+ if (irq < 0)
return irq;
- }
ret = devm_request_threaded_irq(dev, irq, NULL,
imx_tve_irq_handler, IRQF_ONESHOT,
--
2.26.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/imx: imx-tve: Delete an error message in imx_tve_bind()
2020-04-05 9:16 [PATCH] drm/imx: imx-tve: Delete an error message in imx_tve_bind() Markus Elfring
@ 2020-07-20 13:22 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2020-07-20 13:22 UTC (permalink / raw)
To: Markus Elfring, dri-devel, linux-arm-kernel, linux-imx, kernel,
Fabio Estevam, Daniel Vetter, David Airlie, Sascha Hauer,
Shawn Guo
Cc: kernel-janitors, LKML, Tang Bin
On Sun, 2020-04-05 at 11:16 +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 11:01:49 +0200
>
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Thank you, applied to imx-drm/next.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-20 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-05 9:16 [PATCH] drm/imx: imx-tve: Delete an error message in imx_tve_bind() Markus Elfring
2020-07-20 13:22 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).