* [PATCH] drm/nouveau: fix dma syncing for loops
@ 2021-03-08 1:49 Dave Airlie
2021-03-09 13:52 ` Ruhl, Michael J
0 siblings, 1 reply; 2+ messages in thread
From: Dave Airlie @ 2021-03-08 1:49 UTC (permalink / raw)
To: dri-devel; +Cc: skeggsb
From: Dave Airlie <airlied@redhat.com>
The index variable should only be increased in one place.
Noticed this while trying to track down another oops.
Fixes: f295c8cfec83 ("drm/nouveau: fix dma syncing warning with debugging on.")
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 2375711877cf..4f693843def5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -556,7 +556,7 @@ nouveau_bo_sync_for_device(struct nouveau_bo *nvbo)
if (nvbo->force_coherent)
return;
- for (i = 0; i < ttm_dma->num_pages; ++i) {
+ for (i = 0; i < ttm_dma->num_pages;) {
struct page *p = ttm_dma->pages[i];
size_t num_pages = 1;
@@ -587,7 +587,7 @@ nouveau_bo_sync_for_cpu(struct nouveau_bo *nvbo)
if (nvbo->force_coherent)
return;
- for (i = 0; i < ttm_dma->num_pages; ++i) {
+ for (i = 0; i < ttm_dma->num_pages;) {
struct page *p = ttm_dma->pages[i];
size_t num_pages = 1;
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] drm/nouveau: fix dma syncing for loops
2021-03-08 1:49 [PATCH] drm/nouveau: fix dma syncing for loops Dave Airlie
@ 2021-03-09 13:52 ` Ruhl, Michael J
0 siblings, 0 replies; 2+ messages in thread
From: Ruhl, Michael J @ 2021-03-09 13:52 UTC (permalink / raw)
To: Dave Airlie, dri-devel; +Cc: skeggsb
>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>Dave Airlie
>Sent: Sunday, March 7, 2021 8:49 PM
>To: dri-devel@lists.freedesktop.org
>Cc: skeggsb@gmail.com
>Subject: [PATCH] drm/nouveau: fix dma syncing for loops
>
>From: Dave Airlie <airlied@redhat.com>
>
>The index variable should only be increased in one place.
>
>Noticed this while trying to track down another oops.
>
>Fixes: f295c8cfec83 ("drm/nouveau: fix dma syncing warning with debugging
>on.")
>Signed-off-by: Dave Airlie <airlied@redhat.com>
>---
> drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c
>b/drivers/gpu/drm/nouveau/nouveau_bo.c
>index 2375711877cf..4f693843def5 100644
>--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
>+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
>@@ -556,7 +556,7 @@ nouveau_bo_sync_for_device(struct nouveau_bo
>*nvbo)
> if (nvbo->force_coherent)
> return;
>
>- for (i = 0; i < ttm_dma->num_pages; ++i) {
>+ for (i = 0; i < ttm_dma->num_pages;) {
This took a bit to see how the increment worked.
Would calling it out with a comment be out of line?
With or without the comment:
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
M
> struct page *p = ttm_dma->pages[i];
> size_t num_pages = 1;
>
>@@ -587,7 +587,7 @@ nouveau_bo_sync_for_cpu(struct nouveau_bo
>*nvbo)
> if (nvbo->force_coherent)
> return;
>
>- for (i = 0; i < ttm_dma->num_pages; ++i) {
>+ for (i = 0; i < ttm_dma->num_pages;) {
> struct page *p = ttm_dma->pages[i];
> size_t num_pages = 1;
>
>--
>2.27.0
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-09 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 1:49 [PATCH] drm/nouveau: fix dma syncing for loops Dave Airlie
2021-03-09 13:52 ` Ruhl, Michael J
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).