* [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon.
@ 2018-04-09 20:58 Eric Anholt
2018-04-12 9:14 ` Boris Brezillon
0 siblings, 1 reply; 3+ messages in thread
From: Eric Anholt @ 2018-04-09 20:58 UTC (permalink / raw)
To: dri-devel; +Cc: boris.brezillon, linux-kernel
Signed-off-by: Eric Anholt <eric@anholt.net>
Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace")
---
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 94b99c90425a..7c95ed5c5cac 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -130,6 +130,7 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
struct vc4_file *vc4file = file->driver_priv;
vc4_perfmon_close_file(vc4file);
+ kfree(vc4file);
}
static const struct vm_operations_struct vc4_vm_ops = {
--
2.17.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon.
2018-04-09 20:58 [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon Eric Anholt
@ 2018-04-12 9:14 ` Boris Brezillon
2018-04-12 23:09 ` Eric Anholt
0 siblings, 1 reply; 3+ messages in thread
From: Boris Brezillon @ 2018-04-12 9:14 UTC (permalink / raw)
To: Eric Anholt; +Cc: linux-kernel, dri-devel
On Mon, 9 Apr 2018 13:58:13 -0700
Eric Anholt <eric@anholt.net> wrote:
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace")
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> drivers/gpu/drm/vc4/vc4_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 94b99c90425a..7c95ed5c5cac 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -130,6 +130,7 @@ static void vc4_close(struct drm_device *dev, struct drm_file *file)
> struct vc4_file *vc4file = file->driver_priv;
>
> vc4_perfmon_close_file(vc4file);
> + kfree(vc4file);
> }
>
> static const struct vm_operations_struct vc4_vm_ops = {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon.
2018-04-12 9:14 ` Boris Brezillon
@ 2018-04-12 23:09 ` Eric Anholt
0 siblings, 0 replies; 3+ messages in thread
From: Eric Anholt @ 2018-04-12 23:09 UTC (permalink / raw)
To: Boris Brezillon; +Cc: linux-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 363 bytes --]
Boris Brezillon <boris.brezillon@bootlin.com> writes:
> On Mon, 9 Apr 2018 13:58:13 -0700
> Eric Anholt <eric@anholt.net> wrote:
>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace")
>
> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
Applied to drm-misc-next-fixes. Thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-12 23:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 20:58 [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon Eric Anholt
2018-04-12 9:14 ` Boris Brezillon
2018-04-12 23:09 ` Eric Anholt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).