* [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192
@ 2022-04-08 1:39 Nícolas F. R. A. Prado
2022-04-08 8:18 ` AngeloGioacchino Del Regno
2022-04-20 12:23 ` Rex-BC Chen
0 siblings, 2 replies; 4+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-04-08 1:39 UTC (permalink / raw)
To: Philipp Zabel, Chun-Kuang Hu
Cc: Jitao Shi, Nícolas F. R. A. Prado, David Airlie,
linux-kernel, dri-devel, Rex-BC Chen, linux-mediatek,
Matthias Brugger, kernel, linux-arm-kernel,
AngeloGioacchino Del Regno
The configuration for mt8192 was incorrectly using the output formats
from mt8173. Since the output formats for mt8192 are instead the same
ones as for mt8183, which require two bus samples per pixel, the
pixelclock and DDR edge setting were misconfigured. This made external
displays unable to show the image.
Fix the issue by correcting the output format for mt8192 to be the same
as for mt8183, fixing the usage of external displays for mt8192.
Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to driver data")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Changes in v2:
- Added Fixes tag
drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..e61cd67b978f 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = {
.cal_factor = mt8183_calculate_factor,
.reg_h_fre_con = 0xe0,
.max_clock_khz = 150000,
- .output_fmts = mt8173_output_fmts,
- .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
};
static int mtk_dpi_probe(struct platform_device *pdev)
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192
2022-04-08 1:39 [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192 Nícolas F. R. A. Prado
@ 2022-04-08 8:18 ` AngeloGioacchino Del Regno
2022-04-20 12:23 ` Rex-BC Chen
1 sibling, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-04-08 8:18 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Philipp Zabel, Chun-Kuang Hu
Cc: Jitao Shi, David Airlie, linux-kernel, dri-devel, Rex-BC Chen,
linux-mediatek, Matthias Brugger, kernel, linux-arm-kernel
Il 08/04/22 03:39, Nícolas F. R. A. Prado ha scritto:
> The configuration for mt8192 was incorrectly using the output formats
> from mt8173. Since the output formats for mt8192 are instead the same
> ones as for mt8183, which require two bus samples per pixel, the
> pixelclock and DDR edge setting were misconfigured. This made external
> displays unable to show the image.
>
> Fix the issue by correcting the output format for mt8192 to be the same
> as for mt8183, fixing the usage of external displays for mt8192.
>
> Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to driver data")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
Lovely!
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192
2022-04-08 1:39 [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192 Nícolas F. R. A. Prado
2022-04-08 8:18 ` AngeloGioacchino Del Regno
@ 2022-04-20 12:23 ` Rex-BC Chen
2022-04-22 1:03 ` CK Hu
1 sibling, 1 reply; 4+ messages in thread
From: Rex-BC Chen @ 2022-04-20 12:23 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Philipp Zabel, Chun-Kuang Hu
Cc: Jitao Shi, David Airlie, linux-kernel, dri-devel, linux-mediatek,
Matthias Brugger, kernel, linux-arm-kernel,
AngeloGioacchino Del Regno
On Thu, 2022-04-07 at 21:39 -0400, Nícolas F. R. A. Prado wrote:
> The configuration for mt8192 was incorrectly using the output formats
> from mt8173. Since the output formats for mt8192 are instead the same
> ones as for mt8183, which require two bus samples per pixel, the
> pixelclock and DDR edge setting were misconfigured. This made
> external
> displays unable to show the image.
>
> Fix the issue by correcting the output format for mt8192 to be the
> same
> as for mt8183, fixing the usage of external displays for mt8192.
>
> Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to
> driver data")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
>
> Changes in v2:
> - Added Fixes tag
>
> drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..e61cd67b978f 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = {
> .cal_factor = mt8183_calculate_factor,
> .reg_h_fre_con = 0xe0,
> .max_clock_khz = 150000,
> - .output_fmts = mt8173_output_fmts,
> - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> };
>
> static int mtk_dpi_probe(struct platform_device *pdev)
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Hello CK,
Gentle ping for this patch.
This patch is confirmed by Xinlei and Jitao.
BRs,
Rex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192
2022-04-20 12:23 ` Rex-BC Chen
@ 2022-04-22 1:03 ` CK Hu
0 siblings, 0 replies; 4+ messages in thread
From: CK Hu @ 2022-04-22 1:03 UTC (permalink / raw)
To: Rex-BC Chen, Nícolas F. R. A. Prado, Philipp Zabel, Chun-Kuang Hu
Cc: Jitao Shi, David Airlie, linux-kernel, dri-devel, linux-mediatek,
Matthias Brugger, kernel, linux-arm-kernel,
AngeloGioacchino Del Regno
Hi,
On Wed, 2022-04-20 at 20:23 +0800, Rex-BC Chen wrote:
> On Thu, 2022-04-07 at 21:39 -0400, Nícolas F. R. A. Prado wrote:
> > The configuration for mt8192 was incorrectly using the output
> > formats
> > from mt8173. Since the output formats for mt8192 are instead the
> > same
> > ones as for mt8183, which require two bus samples per pixel, the
> > pixelclock and DDR edge setting were misconfigured. This made
> > external
> > displays unable to show the image.
> >
> > Fix the issue by correcting the output format for mt8192 to be the
> > same
> > as for mt8183, fixing the usage of external displays for mt8192.
> >
> > Fixes: be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to
> > driver data")
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > ---
> >
> > Changes in v2:
> > - Added Fixes tag
> >
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..e61cd67b978f 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> > .cal_factor = mt8183_calculate_factor,
> > .reg_h_fre_con = 0xe0,
> > .max_clock_khz = 150000,
> > - .output_fmts = mt8173_output_fmts,
> > - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> > + .output_fmts = mt8183_output_fmts,
> > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > };
> >
> > static int mtk_dpi_probe(struct platform_device *pdev)
>
> Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
>
> Hello CK,
>
> Gentle ping for this patch.
> This patch is confirmed by Xinlei and Jitao.
Applied to mediatek-drm-next [1].
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
CK
>
> BRs,
> Rex
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-22 1:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 1:39 [PATCH v2] drm/mediatek: dpi: Use mt8183 output formats for mt8192 Nícolas F. R. A. Prado
2022-04-08 8:18 ` AngeloGioacchino Del Regno
2022-04-20 12:23 ` Rex-BC Chen
2022-04-22 1:03 ` CK Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).