dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Zack Rusin <zackr@vmware.com>
To: "daniel@ffwll.ch" <daniel@ffwll.ch>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>,
	"contact@emersion.fr" <contact@emersion.fr>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers
Date: Fri, 16 Jun 2023 03:59:43 +0000	[thread overview]
Message-ID: <9a8ec363a38e78b1848483baab52c9c61cb2e188.camel@vmware.com> (raw)
In-Reply-To: <20230615094206.4424-1-tzimmermann@suse.de>

On Thu, 2023-06-15 at 11:31 +0200, Thomas Zimmermann wrote:
> Set drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle()
> for all DRM drivers. Even drivers that do not support PRIME import
> or export of dma-bufs can now import their own buffer objects. This
> is required by some userspace, such as wlroots-based compositors, to
> share buffers among processes.
> 
> The only driver that does not use the drm_gem_prime_*() helpers is
> vmwgfx. Once it has been converted, the callbacks in struct drm_driver
> can be removed.

Hmm, I'm not sure that's ever going to be possible on vmwgfx. Or at least not until
Xorg is used by anything. Some things in vmwgfx stack create "surfaces" which are
not GEM's (they can be backed by a GEM object, but don't have to) and the prime
implementation on vmwgfx has to be able to export and import those. 

In an ideal world I'd just delete the ioctl's that allow creating those "surfaces",
but of course that's a no-no, so possibility of introducing vmwgfx2 with a
saner/modern ioctl model has been floating around internally. Which at least would
open a path to removing vmwgfx at some point in the future, but there's not much
that can be done about vmwgfx having to be able to prime import/export GEM's and
wonky non-GEM objects.

z


  parent reply	other threads:[~2023-06-16  3:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15  9:31 [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers Thomas Zimmermann
2023-06-15  9:31 ` [PATCH 1/3] drm: Enable PRIME import/export " Thomas Zimmermann
2023-06-15 14:47   ` Simon Ser
2023-06-15  9:31 ` [PATCH 2/3] drm: Clear fd/handle callbacks in struct drm_driver Thomas Zimmermann
2023-06-15  9:31 ` [PATCH 3/3] drm/prime: Unexport helpers for fd/handle conversion Thomas Zimmermann
2023-06-15 14:50 ` [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers Simon Ser
2023-06-15 14:56   ` Thomas Zimmermann
2023-06-16  3:59 ` Zack Rusin [this message]
2023-06-16  7:11   ` Thomas Zimmermann
2023-06-16 17:00 ` Jeffrey Hugo
2023-06-19  8:52   ` Thomas Zimmermann
2023-06-16 17:22 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a8ec363a38e78b1848483baab52c9c61cb2e188.camel@vmware.com \
    --to=zackr@vmware.com \
    --cc=Linux-graphics-maintainer@vmware.com \
    --cc=airlied@gmail.com \
    --cc=contact@emersion.fr \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).